From patchwork Tue May 16 19:40:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 682376 Delivered-To: patch@linaro.org Received: by 2002:a05:6504:558:b0:22d:db33:bb6d with SMTP id w24csp640739ltp; Tue, 16 May 2023 12:47:50 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5lHfUlQZyqQuP3EO0OT/BiTcieW94IJwqSpl7+LvCiWPLmGHvIMRp0YnAVQPIxSQi4JNUC X-Received: by 2002:a05:6214:2462:b0:5df:47e2:8df5 with SMTP id im2-20020a056214246200b005df47e28df5mr66735929qvb.31.1684266469923; Tue, 16 May 2023 12:47:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684266469; cv=none; d=google.com; s=arc-20160816; b=enMnfJSHvNkHBXUSW6n9usUsNB8rP64C2v42H5qRmfun4q4xn6mRAGwzyEVwaaDFQf rjXsLK3867hr7J/CdUt/i7IflkAZQRH4ujyRhazJs/N3AWDMwJwufkMEwPW/15t7pnyj n9y4BYdhXqdJdu+aNbPs7ZFPPPHq0I1sxgmwPaOlXec3yvWIEqxkv+7oI5DxDSE8wu1k ku84ynjQ4DJH1UT5FxZGkbHuVu9BkMRdrb/YAb3IHzs5P3fWZzLVLCE5H4ccJfyieu4F aMqN7tOpKZDTfBftWX6g4yf6glgWlSmYm05uzJEXCmDV06KhjO/ZG7yW4tH7pez/uwXq jXKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=03Saz/Ae1+wLFRqHrvpgcnIMM8UibULuCXSb3tQDXYE=; b=upD0ovlvJ0tgy/wMRyi8kF+GWw8yMBimXMp6rUwQjHktCdXBbSOimoP5XxBVPe0EW7 e6O8E5iJ3PggtVcZfX1CONWRA/7O3kLFfwPQmrlPyO4XmvC9CfxkceApPEjILWThSTUc DzfUXmTEBPRs+eRXVrAkf/QTKfa/ofbAbSbTru3LO07fqgt6Xh5GbKV4+hth4wQQ7Hvw cV/i7rRJxrfDYbA4fiTftmq2X1UpIaj27l7b7Hsuam+o28p4zr9VexgSrDMIVLi3WDMD JdRLstfKNUVWYrdkBFJOeY9yZDXSx25fw/NTbi6RoTQ6sQvxYS9Yd9l2t4MdudJ2cu7k yUHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qtT+Pdeq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id m19-20020ae9e713000000b007578ee2138csi207771qka.380.2023.05.16.12.47.49 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 16 May 2023 12:47:49 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=qtT+Pdeq; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pz0Yo-0006jf-6J; Tue, 16 May 2023 15:42:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pz0Yl-0006il-CH for qemu-devel@nongnu.org; Tue, 16 May 2023 15:42:11 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pz0Yj-0002rN-R7 for qemu-devel@nongnu.org; Tue, 16 May 2023 15:42:11 -0400 Received: by mail-pg1-x530.google.com with SMTP id 41be03b00d2f7-52079a12451so10504194a12.3 for ; Tue, 16 May 2023 12:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684266128; x=1686858128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=03Saz/Ae1+wLFRqHrvpgcnIMM8UibULuCXSb3tQDXYE=; b=qtT+PdeqQZ8Q4G7WB6SKOklaEmeHqzjTfL4HvBwgX/RJKSS0Z8Fc3CjqB3mV1wpL4z aVxUBck0eZ4uvvuKkT96k2s4xYngTXJce2hRQHZKbd4wZRjqOCg7BAXscHCSCfHuh72w BO4XcZxBnV+rJZgNOkD1FkHtAYYQdnTP9Mz2Pf1nVgg8V3WZhOeuURkXonheQ1VPbjm4 KlG0c+vadRegMVtIdRB1ixAAavlq62OMABsgBNj7uUgkD0WiDeGL4HBMEn4a7vit+y3w 6V2075D8nUlxCMdvAWU/c8FB0BkzDWT7zjVcPsEAco5L//IOhyvXng/37zGgieDtF+MN 7T1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684266128; x=1686858128; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=03Saz/Ae1+wLFRqHrvpgcnIMM8UibULuCXSb3tQDXYE=; b=bbg9SHQmyx/GZcWD1CHD7L9PLHw91ydKt01sHfsEXSjKSNxwnNugl+n6FYvP4Aquj2 ADgMVNPomYTpp3B4FjcjE8tmcWrp2lwOqoXBcckWESJYt1jWv2fYjkUEisgsSXAhz5P0 SkMChtgxbRqeUfGfUW57+n227FaLn64XTGXw9us6o13rZNsr6U9EydGpkGxWfXvKDiKm MscI+P3W6N3/UBS3oXQFERb13M6KAUKj+Nz0ObL2buGcixjN4aczu6Z90L5MOWlje4e4 lOxglBzwItkd4c1PTmMkcTy9V8KUtZIcIQICWpJ7bJu88nELpO/NWuWJXtfGWZK/WROI Q7Pg== X-Gm-Message-State: AC+VfDzmnhrvbDJns8FHeg1F78mgLkN4Wa5j0ZkSZvEFu56b8sTS7Zm6 yMs3n5+rXY/Ydx81W4PoB6ktRgMD4PAJMn5XNww= X-Received: by 2002:a05:6a20:7354:b0:101:1d1d:43a4 with SMTP id v20-20020a056a20735400b001011d1d43a4mr34273036pzc.15.1684266128632; Tue, 16 May 2023 12:42:08 -0700 (PDT) Received: from stoup.. ([2602:ae:1598:4c01:ec81:440e:33a4:40b9]) by smtp.gmail.com with ESMTPSA id z21-20020aa791d5000000b006260526cf0csm13771165pfa.116.2023.05.16.12.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 12:42:08 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Peter Maydell Subject: [PULL 24/80] target/sparc64: Remove tcg_out_movi_s13 case from tcg_out_movi_imm32 Date: Tue, 16 May 2023 12:40:49 -0700 Message-Id: <20230516194145.1749305-25-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230516194145.1749305-1-richard.henderson@linaro.org> References: <20230516194145.1749305-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Shuffle the order in tcg_out_movi_int to check s13 first, and drop this check from tcg_out_movi_imm32. This might make the sequence for in_prologue larger, but not worth worrying about. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- tcg/sparc64/tcg-target.c.inc | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/tcg/sparc64/tcg-target.c.inc b/tcg/sparc64/tcg-target.c.inc index 15d6a9fd73..2689599fd6 100644 --- a/tcg/sparc64/tcg-target.c.inc +++ b/tcg/sparc64/tcg-target.c.inc @@ -407,15 +407,10 @@ static void tcg_out_movi_s13(TCGContext *s, TCGReg ret, int32_t arg) static void tcg_out_movi_imm32(TCGContext *s, TCGReg ret, int32_t arg) { - if (check_fit_i32(arg, 13)) { - /* A 13-bit constant sign-extended to 64-bits. */ - tcg_out_movi_s13(s, ret, arg); - } else { - /* A 32-bit constant zero-extended to 64 bits. */ - tcg_out_sethi(s, ret, arg); - if (arg & 0x3ff) { - tcg_out_arithi(s, ret, ret, arg & 0x3ff, ARITH_OR); - } + /* A 32-bit constant zero-extended to 64 bits. */ + tcg_out_sethi(s, ret, arg); + if (arg & 0x3ff) { + tcg_out_arithi(s, ret, ret, arg & 0x3ff, ARITH_OR); } } @@ -426,18 +421,18 @@ static void tcg_out_movi_int(TCGContext *s, TCGType type, TCGReg ret, tcg_target_long hi, lo = (int32_t)arg; tcg_target_long test, lsb; - /* A 32-bit constant, or 32-bit zero-extended to 64-bits. */ - if (type == TCG_TYPE_I32 || arg == (uint32_t)arg) { - tcg_out_movi_imm32(s, ret, arg); - return; - } - /* A 13-bit constant sign-extended to 64-bits. */ if (check_fit_tl(arg, 13)) { tcg_out_movi_s13(s, ret, arg); return; } + /* A 32-bit constant, or 32-bit zero-extended to 64-bits. */ + if (type == TCG_TYPE_I32 || arg == (uint32_t)arg) { + tcg_out_movi_imm32(s, ret, arg); + return; + } + /* A 13-bit constant relative to the TB. */ if (!in_prologue) { test = tcg_tbrel_diff(s, (void *)arg);