From patchwork Thu May 18 04:40:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 683340 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp181582wrt; Wed, 17 May 2023 21:41:57 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ41PKgbP6D+Cg24IhhnV9Kyxce6UCj2oGnrimR0RsYF4KWwxefl6qTDS1TthejDd2kBiyuv X-Received: by 2002:a05:6214:5194:b0:5ef:8b9c:aa86 with SMTP id kl20-20020a056214519400b005ef8b9caa86mr2953146qvb.44.1684384917638; Wed, 17 May 2023 21:41:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684384917; cv=none; d=google.com; s=arc-20160816; b=e0NE51CVkA3oar437VKHZPhzkkts8qiEqBOzzfZL1wrIe/DkvQ7g/VBpATbFnP2T0v YqzN2wIACSA9YZHB/W/25pkZ2Q8dU9oOb7IGUsTsU18np+1DOTFArvOFLrh6LU2E9VLg s9qBxjmxpQ+ApWml5la1n5WwwEZt+IGagjJH7VTc28XNxZH1dGy/xT8dYhBc9MHw7BxC s6A9MK60uVxAi691lb9QEBuD4FzVCloBWZdlLDs7hlqdE1N88Vl7rZ1qAahqFmkUcPPv A7lHKzgUtNZvcG2gMTT4vU41HYRpQVwaMhv6rHjEROOV0c0NsZ7NVPil4JVu1ZZbTuK6 pkdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ykx3pKJ9mEJfKv9zLTDO3vPaxlcgEqkjUx3mdIA9+HU=; b=c5ufH1abRohx8NO54FRzNyjXnXmM0yTJeZWFFSlNzMIpe2h1PsyCGdBpaxpgObYKlX EULBysXEsOIUpnOq72yxGqQbmLrfZX8elExVqY4ryT3AhxxwaxjBffGP8pbXoNdIAm+f 1wvP2wcrlIv76B2rPxi+wNNpCVP7UWGwlHQsIKgXmImzLn4HuHUVICxFrYV8CPdqnOGi JqiKpax5j9vYEPPqjtcA0gxWkKZBh0jlcm5knZlpYvBbNwPJodV8VHwNJfSHdMfiXk1U JZgDdX1UglRCrYA3t3mnq/ZZo8egv6Sszo3kh4cVOpV5ZR9CzQ4SdIpUmulkvhhcm4AR nbFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mNQWKrHX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q5-20020a05620a038500b0074adeac7013si396785qkm.167.2023.05.17.21.41.57 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 May 2023 21:41:57 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=mNQWKrHX; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzVRz-00069S-Bt; Thu, 18 May 2023 00:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzVRx-00068w-IZ for qemu-devel@nongnu.org; Thu, 18 May 2023 00:41:13 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzVRr-00077s-Cj for qemu-devel@nongnu.org; Thu, 18 May 2023 00:41:13 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-64d1e96c082so76939b3a.1 for ; Wed, 17 May 2023 21:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684384865; x=1686976865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ykx3pKJ9mEJfKv9zLTDO3vPaxlcgEqkjUx3mdIA9+HU=; b=mNQWKrHX9m7gpykX9vjNLQ481GEWYHsHkj5KTC5YtnAPYPjrbaSzxsddvKyn/zB4Ms ZcS37E1pmjcBe6y30MWsRU10H3rpBO5d1kz2Wp9j83XgqN31GgIn1CX3Sk6Ay7Yi32wG AaJjTD47LdyM9ZfN5yhniKOeLCfFGTxhJcUiv4LBhi25dJb65irJQ8UoVdFkJvVTUjKe e3KDk+6665wNxFRy8SGR/19kJwppi+GmagSbY77obCVbqGqE8N1U4bIBlinIHTDrFQH1 jpbLFIiZxW10Ft/lImY8vc5vYtx0uxopk9VcsUJ2m9UV6Qlu4U/CDed274Px/zhHCR/f mSIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684384865; x=1686976865; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ykx3pKJ9mEJfKv9zLTDO3vPaxlcgEqkjUx3mdIA9+HU=; b=dzPhBRN9ljYazMdML+SFzYJKuWSlQJXKyDRRY9itsMWOvRJFlCoqLxDmv441DptGhK FZ2axpNnu9m1yzq6wXwVyRYmKs0nZshVd5o6IxzaNFqhgQmCxQ29K2RFnefrrSHH2wAh AbYZNw4ZU6YJtP2xcNAPh/tvyVmQPqNugqf8BBDra4A2Al00FS1mk0DUTYstCYdLb1/w CToFowjBy+ytnKWhQB9YXHmxCpk4ljyMMyZxTxw+ODV/9k/qOaolVVgOHKMiaSDa3Fvz EE0g7+uvEm00PY3h7TonPJ2wy+4SMQ36+5zMYfsA1ERZ/f7pynMTnrAwbhL4jqtWW/Kz 6EQQ== X-Gm-Message-State: AC+VfDxWO8F23EmXGlsEfA2UZT9H9+t2MFGEGAOnTjHU4CMSY5LGm4cC JyNi89BD/52s/gTEDk8TCtMeBOiZfxQjLDtLWtk= X-Received: by 2002:a17:902:ec83:b0:1a9:581d:3efb with SMTP id x3-20020a170902ec8300b001a9581d3efbmr1480676plg.6.1684384865118; Wed, 17 May 2023 21:41:05 -0700 (PDT) Received: from stoup.. ([2602:ae:1598:4c01:17a4:1aa0:c49d:e8f7]) by smtp.gmail.com with ESMTPSA id t9-20020a170902e84900b001ab1d23bf5dsm225592plg.258.2023.05.17.21.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 21:41:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org Subject: [PATCH 5/9] util/bufferiszero: Use i386 cpuinfo.h Date: Wed, 17 May 2023 21:40:54 -0700 Message-Id: <20230518044058.2777467-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518044058.2777467-1-richard.henderson@linaro.org> References: <20230518044058.2777467-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Use cpuinfo_init() during init_accel(), and the variable cpuinfo during test_buffer_is_zero_next_accel(). Adjust the logic that cycles through the set of accelerators for testing. Signed-off-by: Richard Henderson --- util/bufferiszero.c | 126 ++++++++++++++++---------------------------- 1 file changed, 45 insertions(+), 81 deletions(-) diff --git a/util/bufferiszero.c b/util/bufferiszero.c index 1886bc5ba4..f216d07b76 100644 --- a/util/bufferiszero.c +++ b/util/bufferiszero.c @@ -24,6 +24,7 @@ #include "qemu/osdep.h" #include "qemu/cutils.h" #include "qemu/bswap.h" +#include "cpuinfo.h" static bool buffer_zero_int(const void *buf, size_t len) @@ -184,111 +185,74 @@ buffer_zero_avx512(const void *buf, size_t len) } #endif /* CONFIG_AVX512F_OPT */ - -/* Note that for test_buffer_is_zero_next_accel, the most preferred - * ISA must have the least significant bit. - */ -#define CACHE_AVX512F 1 -#define CACHE_AVX2 2 -#define CACHE_SSE4 4 -#define CACHE_SSE2 8 - -/* Make sure that these variables are appropriately initialized when +/* + * Make sure that these variables are appropriately initialized when * SSE2 is enabled on the compiler command-line, but the compiler is * too old to support CONFIG_AVX2_OPT. */ #if defined(CONFIG_AVX512F_OPT) || defined(CONFIG_AVX2_OPT) -# define INIT_CACHE 0 -# define INIT_ACCEL buffer_zero_int +# define INIT_USED 0 +# define INIT_LENGTH 0 +# define INIT_ACCEL buffer_zero_int #else # ifndef __SSE2__ # error "ISA selection confusion" # endif -# define INIT_CACHE CACHE_SSE2 -# define INIT_ACCEL buffer_zero_sse2 +# define INIT_USED CPUINFO_SSE2 +# define INIT_LENGTH 64 +# define INIT_ACCEL buffer_zero_sse2 #endif -static unsigned cpuid_cache = INIT_CACHE; +static unsigned used_accel = INIT_USED; +static unsigned length_to_accel = INIT_LENGTH; static bool (*buffer_accel)(const void *, size_t) = INIT_ACCEL; -static int length_to_accel = 64; -static void init_accel(unsigned cache) +static unsigned __attribute__((noinline)) +select_accel_cpuinfo(unsigned info) { - bool (*fn)(const void *, size_t) = buffer_zero_int; - if (cache & CACHE_SSE2) { - fn = buffer_zero_sse2; - length_to_accel = 64; - } -#ifdef CONFIG_AVX2_OPT - if (cache & CACHE_SSE4) { - fn = buffer_zero_sse4; - length_to_accel = 64; - } - if (cache & CACHE_AVX2) { - fn = buffer_zero_avx2; - length_to_accel = 128; - } -#endif + static const struct { + unsigned bit; + unsigned len; + bool (*fn)(const void *, size_t); + } all[] = { #ifdef CONFIG_AVX512F_OPT - if (cache & CACHE_AVX512F) { - fn = buffer_zero_avx512; - length_to_accel = 256; - } + { CPUINFO_AVX512F, 256, buffer_zero_avx512 }, #endif - buffer_accel = fn; +#ifdef CONFIG_AVX2_OPT + { CPUINFO_AVX2, 128, buffer_zero_avx2 }, + { CPUINFO_SSE4, 64, buffer_zero_sse4 }, +#endif + { CPUINFO_SSE2, 64, buffer_zero_sse2 }, + { CPUINFO_ALWAYS, 0, buffer_zero_int }, + }; + + for (unsigned i = 0; i < ARRAY_SIZE(all); ++i) { + if (info & all[i].bit) { + length_to_accel = all[i].len; + buffer_accel = all[i].fn; + return all[i].bit; + } + } + return 0; } #if defined(CONFIG_AVX512F_OPT) || defined(CONFIG_AVX2_OPT) -#include "qemu/cpuid.h" - -static void __attribute__((constructor)) init_cpuid_cache(void) +static void __attribute__((constructor)) init_accel(void) { - unsigned max = __get_cpuid_max(0, NULL); - int a, b, c, d; - unsigned cache = 0; - - if (max >= 1) { - __cpuid(1, a, b, c, d); - if (d & bit_SSE2) { - cache |= CACHE_SSE2; - } - if (c & bit_SSE4_1) { - cache |= CACHE_SSE4; - } - - /* We must check that AVX is not just available, but usable. */ - if ((c & bit_OSXSAVE) && (c & bit_AVX) && max >= 7) { - unsigned bv = xgetbv_low(0); - __cpuid_count(7, 0, a, b, c, d); - if ((bv & 0x6) == 0x6 && (b & bit_AVX2)) { - cache |= CACHE_AVX2; - } - /* 0xe6: - * XCR0[7:5] = 111b (OPMASK state, upper 256-bit of ZMM0-ZMM15 - * and ZMM16-ZMM31 state are enabled by OS) - * XCR0[2:1] = 11b (XMM state and YMM state are enabled by OS) - */ - if ((bv & 0xe6) == 0xe6 && (b & bit_AVX512F)) { - cache |= CACHE_AVX512F; - } - } - } - cpuid_cache = cache; - init_accel(cache); + used_accel = select_accel_cpuinfo(cpuinfo_init()); } #endif /* CONFIG_AVX2_OPT */ bool test_buffer_is_zero_next_accel(void) { - /* If no bits set, we just tested buffer_zero_int, and there - are no more acceleration options to test. */ - if (cpuid_cache == 0) { - return false; - } - /* Disable the accelerator we used before and select a new one. */ - cpuid_cache &= cpuid_cache - 1; - init_accel(cpuid_cache); - return true; + /* + * Accumulate the accelerators that we've already tested, and + * remove them from the set to test this round. We'll get back + * a zero from select_accel_cpuinfo when there are no more. + */ + unsigned used = select_accel_cpuinfo(cpuinfo & ~used_accel); + used_accel |= used; + return used; } static bool select_accel_fn(const void *buf, size_t len)