From patchwork Wed May 24 18:32:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 685369 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp397911wrt; Wed, 24 May 2023 11:34:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ70TPYrvusYINVEhYnYq2G4xhqHtY1ZzK0VmrdLQP14tatCtXGw0p+JVuyGqM6Tvewq7YtY X-Received: by 2002:ac8:5843:0:b0:3f4:fa49:a33c with SMTP id h3-20020ac85843000000b003f4fa49a33cmr28072032qth.53.1684953260340; Wed, 24 May 2023 11:34:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684953260; cv=none; d=google.com; s=arc-20160816; b=etQVe8pDWRJXdP16y0W29lac/Clr6Vp82b7sglp4LtaBVVp/tBP6Sf2X3RFHtOZMDM 5yhbyLDxGmbQEdcAEiduFMmVUO8ZUumFVO9vjF0tv4uH3Jl4NaKZnHke2oNQr5uP9xEV PEwto6C8PXO9x3XyqATZDg1SAvdKf9YS3EoaCNRWMP11ENw3MQHmV+IqpsHcmvfzAK9/ ODC1n/1FDThgt4AZr3woKmQ9Nsl6Q8N+DpxlTybC0gep9yCZ3CI5d8Mhw9ed2PM9m7NA 60phNG1h4QKXn2tVrK9Kco3IqOO6LQ3RJFV+e9kJKUPCCGIrRYw4EziHdty0sSrkyZBL PnIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pC5BML/2RuBlAliYWf9iHoOkVB/mG8RCdorrkZ9mhpU=; b=QLS5TiKv+iNWUxFA5u9oTDR9/79hMVkFF/m9wsJ3aO1c3YB411kkgPlybmXO1wxQ6s zB435vawE5sLWhnkRZWvw6NYuSJEsJMcoh2DHxwR3kDV3dzEm+RWf/ZUK5QVFj8ODd9p 7algS0mEyNHz+ACF/UL+6b4t4K5U8xXmppBFciZ8hT8/H5x5PYSOvI3kJBRcG2XoGkmt J88bnJT/e5IiXKp3ih9fCxtSysRx8k1J+r/p7CuPnxz5qD8lgzbfFSSOD1QcQMX/gVvz Ye2JsWstuYxzC2wdaztjSK3tR2NxFXcaQ2DQa8HhzYt+1ldC5cvV5L5iF1ueO9TV2gT9 vVjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CVeo+2KF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q11-20020a05622a04cb00b003e656c6b9e8si7183117qtx.299.2023.05.24.11.34.20 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 May 2023 11:34:20 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CVeo+2KF; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1tIN-0005ye-JL; Wed, 24 May 2023 14:33:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1tII-0005t4-5K for qemu-devel@nongnu.org; Wed, 24 May 2023 14:33:07 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1tIF-0006wu-4m for qemu-devel@nongnu.org; Wed, 24 May 2023 14:33:05 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1ae8ecb4f9aso4544105ad.1 for ; Wed, 24 May 2023 11:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684953181; x=1687545181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pC5BML/2RuBlAliYWf9iHoOkVB/mG8RCdorrkZ9mhpU=; b=CVeo+2KF4Id6Tn8taXF+9wWDJgIn6V+8eVy+zfdgWXjB0G/DeNTTiO1cNhzd9RH94z ay8TVsxOzSkzcgu9JrA9j8nd0tSABHyT2EnoKptBgmcqsxdEh7tOs3hx2Y3fB7bTMJVb mdeZqovVKHrvPZUSklr/xBfaYUhe+mA3w+YgMjkNzuWfW9eoNEkY9aoZbV8qD1pkmHpK eIP9c0LjnI+f50SBb9roO3WMj9TeBkM4uJUZhX5GFCwhz02qr7STk2oCqTj2Cci9cPpu lGvSrfsCyEnTA1Q91AeElhP0jrb7BqV/+t0gh5mht6gYPHbf36ErWxFNHXLrQ3h3TwG2 dQhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684953181; x=1687545181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pC5BML/2RuBlAliYWf9iHoOkVB/mG8RCdorrkZ9mhpU=; b=dJFn+1zFDsdSgyaPMgVg4QeBWSrWmy6tERMpwp6CrGGlMYF3X5Zx/W/YE73LT7zfW6 n8R1KhkzuUOd3Wu2AnR2v/m4qSqaO7y8twjSsQLugPm/dNdm8TjBN+FAmsdI2c+Hv/kR 3N07aYcLwwKoAZTha1YFEw+2ZsECF22Cwx/ffqEbqjNL3eCq8yvT9zoLxQ0D7cuq3ZLs UeorAJNgns1qhRmv0JAEfOFv1GCt4QeSjF72tXC6DXtj25bF14XYDJT0IVFX+9iwyj+8 /bFReXQ0Whaw3H+rLKfuyLyheN0/5TJziuHqw3pdw6GT8fmcgODUPp5aKXMMtwNoWdjB q+ew== X-Gm-Message-State: AC+VfDzCUDziMNgL+dgB28cxelqGCbVrooyLlJvP+9ZVMLiwTfym7e7E fV9RYp/PRP6ZhSzkK9dwIrBAZjBuliDAjXQ/mJ4= X-Received: by 2002:a17:902:bc42:b0:1ae:2b97:f387 with SMTP id t2-20020a170902bc4200b001ae2b97f387mr16494568plz.21.1684953181387; Wed, 24 May 2023 11:33:01 -0700 (PDT) Received: from stoup.. ([2602:ae:1598:4c01:6b03:9af2:33c1:3d6b]) by smtp.gmail.com with ESMTPSA id 2-20020a170902c20200b001ac2be26340sm9042008pll.222.2023.05.24.11.33.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 May 2023 11:33:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, alex.bennee@linaro.org Subject: [PATCH v3 2/2] qemu/atomic128: Add x86_64 atomic128-ldst.h Date: Wed, 24 May 2023 11:32:58 -0700 Message-Id: <20230524183258.1194571-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230524183258.1194571-1-richard.henderson@linaro.org> References: <20230524183258.1194571-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org With CPUINFO_ATOMIC_VMOVDQA, we can perform proper atomic load/store without cmpxchg16b. Signed-off-by: Richard Henderson --- host/include/x86_64/host/atomic128-ldst.h | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 host/include/x86_64/host/atomic128-ldst.h diff --git a/host/include/x86_64/host/atomic128-ldst.h b/host/include/x86_64/host/atomic128-ldst.h new file mode 100644 index 0000000000..adc9332f91 --- /dev/null +++ b/host/include/x86_64/host/atomic128-ldst.h @@ -0,0 +1,68 @@ +/* + * SPDX-License-Identifier: GPL-2.0-or-later + * Load/store for 128-bit atomic operations, x86_64 version. + * + * Copyright (C) 2023 Linaro, Ltd. + * + * See docs/devel/atomics.rst for discussion about the guarantees each + * atomic primitive is meant to provide. + */ + +#ifndef AARCH64_ATOMIC128_LDST_H +#define AARCH64_ATOMIC128_LDST_H + +#ifdef CONFIG_INT128_TYPE +#include "host/cpuinfo.h" +#include "tcg/debug-assert.h" + +/* + * Through clang 16, with -mcx16, __atomic_load_n is incorrectly + * expanded to a read-write operation: lock cmpxchg16b. + */ + +#define HAVE_ATOMIC128_RO likely(cpuinfo & CPUINFO_ATOMIC_VMOVDQA) +#define HAVE_ATOMIC128_RW 1 + +static inline Int128 atomic16_read_ro(const Int128 *ptr) +{ + Int128Alias r; + + tcg_debug_assert(HAVE_ATOMIC128_RO); + asm("vmovdqa %1, %0" : "=x" (r.i) : "m" (*ptr)); + + return r.s; +} + +static inline Int128 atomic16_read_rw(Int128 *ptr) +{ + __int128_t *ptr_align = __builtin_assume_aligned(ptr, 16); + Int128Alias r; + + if (HAVE_ATOMIC128_RO) { + asm("vmovdqa %1, %0" : "=x" (r.i) : "m" (*ptr_align)); + } else { + r.i = __sync_val_compare_and_swap_16(ptr_align, 0, 0); + } + return r.s; +} + +static inline void atomic16_set(Int128 *ptr, Int128 val) +{ + __int128_t *ptr_align = __builtin_assume_aligned(ptr, 16); + Int128Alias new = { .s = val }; + + if (HAVE_ATOMIC128_RO) { + asm("vmovdqa %1, %0" : "=m"(*ptr_align) : "x" (new.i)); + } else { + __int128_t old; + do { + old = *ptr_align; + } while (!__sync_bool_compare_and_swap_16(ptr_align, old, new.i)); + } +} +#else +/* Provide QEMU_ERROR stubs. */ +#include "host/include/generic/host/atomic128-ldst.h" +#endif + +#endif /* AARCH64_ATOMIC128_LDST_H */