From patchwork Tue Jun 20 08:25:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 694442 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp186456wrm; Tue, 20 Jun 2023 01:28:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5MKDBtq4wMr+m40+87xOpciJjW9L7Lq/ohyb9hZis8PIn/fsSJNNTtf2LRgDEtqdhIWGzC X-Received: by 2002:ac8:5841:0:b0:3ff:227f:ae15 with SMTP id h1-20020ac85841000000b003ff227fae15mr6203101qth.20.1687249709354; Tue, 20 Jun 2023 01:28:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687249709; cv=none; d=google.com; s=arc-20160816; b=1D1huFFlvDcW2zbqId6mkU2WBM+wW2pXzNmPrV6OH5ac+R/etUHaxSnMclo7HvePxW bdeRzE3P8uPlLFd2hTCC0hmOuKysxzwr/dqHYyTDuP6BAr+2G/rlXoeyDsv19cHEGp7s 2m8fvZ7/wEAfakcZENiz4iZ9dIh5nxIwZP66QP7z23yTUafai1sSZ2FBsGH1sPdvDDyw BPSpxx0xvnYwi5G7EL4Z2+NQEJqn58CWA5xS5v6MQEhBxjjjGbMhP08RKgb7As+U9VuI hVNUeZMx6dFzv7UnVhlhCdk+z4uMnKM2BklMP37M81iWOk4x8JPrDdJLQpxnsY2wzmXV 1S0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=iu9NYRz6Ra5A62BXzInURdN1K99XZz4HoyPXiDzEZbw=; b=Eur2z+PQL5KEfUHWpIncp/v3M4eiIbvXcXrcwo6DUbMor5d9+glY0Gpi99/ygdtTlu 0JO7u5x+Rf5teaXs/U0EyIDjkziI1VSxGNpBaxgO56abstdkmtMYF+0RaQf34HDF5JR8 YXWQ82y5tWiFEFot3P5SLC9sNgLvOoyJXn6PqfLNbyLnFQG0Y4/wOFnwgEsBYh7eHRKu DHpfOVKa7px07LzehWGJ9xIRtfTYSXEkhzP1q8lfhzpaNqvthI9WbK4v9nu5b5jitSDo Ih0z/PdhK1SgkfmDW1TMXUqdDQzOoKcy+AHta3jujXznZV4jfIJnlgC5WrJZBmn2v7gm m0Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GEEvcbOC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id v11-20020a05622a130b00b003f4efc27169si562276qtk.435.2023.06.20.01.28.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 20 Jun 2023 01:28:29 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=GEEvcbOC; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBWh4-0003pD-3t; Tue, 20 Jun 2023 04:26:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBWgu-0003n0-Jx for qemu-devel@nongnu.org; Tue, 20 Jun 2023 04:26:20 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBWgr-00065A-9Q for qemu-devel@nongnu.org; Tue, 20 Jun 2023 04:26:19 -0400 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-51a4044b7a1so5441187a12.2 for ; Tue, 20 Jun 2023 01:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687249575; x=1689841575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iu9NYRz6Ra5A62BXzInURdN1K99XZz4HoyPXiDzEZbw=; b=GEEvcbOC2aBtwZ2SJpJdLjluYMniVSd736VdZDawiICngQUT/kftQhdILdImEOIayU DE/bJr36thZtrloZtVIsLFdI1IzLeGlG3vQD6HbHq2slmgKGechPUuCyrx0bduzyIQyH Fm25xe9gGLIb5n1qnMKFx6FVuzhtvAbNpSvH4NdUt20IHZLZnEfOJsC+AyARI7amBlOK dd1o8cXxWGSZO2nGptGrAeOisxGQuV8Ai75Od4P2frdI8dnU8vTrm3mPuU1hVLT8VMnn cNwaYPv8ZvLCNAZQREytzi8+4lvjoaoQ4dRQbzdu6I4j3nLOSgA9IvcdTM7olQgyZA+p KMFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687249575; x=1689841575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iu9NYRz6Ra5A62BXzInURdN1K99XZz4HoyPXiDzEZbw=; b=Lg9AD42onY6JdLITbaCy+LJfpMwmkCDfOIsbqtSp0uSmT0MK2Wmp5v/vAjztVeShuv YhrxpO/5OSIrRAPWfYg/GLqPfhH97Y7h4gwbxHWToA6c2VCHy+EOAQHOrac7PHPHajv9 zKwinjMeHGPiq17z1ouaSzhAaVBAt4Wx9NHgauqv+yBp3jjSakM6CTXB44JXlvzbN/3e d2e0FzlQYTfZP96vdm+quK3Apd24fFUh9rHWSb5kKbZI9CqMrvIOjgxg4GkzUoH2NKag v0xtRVgoJlhaLkpHDWt7efgu47ETd7N0MfTpOacxxgxG5b824eZx9WOqSsfcvigu0/E2 DzfA== X-Gm-Message-State: AC+VfDwIUvMxDtW3mUsUzn4AFsyvXJhQmeNZbTCZQKtLgz18hdRdvVnS VnlZfJ9ZM/Tj0PeRZyQBiuInYOD4Rgb6SILK4qfGOdpv X-Received: by 2002:a17:907:7245:b0:982:a454:6d24 with SMTP id ds5-20020a170907724500b00982a4546d24mr10653212ejc.74.1687249575697; Tue, 20 Jun 2023 01:26:15 -0700 (PDT) Received: from stoup.lan ([176.176.183.29]) by smtp.gmail.com with ESMTPSA id z19-20020a170906669300b00977c7566ccbsm935901ejo.164.2023.06.20.01.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Jun 2023 01:26:15 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Peter Maydell Subject: [PULL 02/16] accel/tcg: Handle MO_ATOM_WITHIN16 in do_st16_leN Date: Tue, 20 Jun 2023 10:25:57 +0200 Message-Id: <20230620082611.770620-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230620082611.770620-1-richard.henderson@linaro.org> References: <20230620082611.770620-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=richard.henderson@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Otherwise we hit the default assert not reached. Handle it as MO_ATOM_NONE, because of size and misalignment. We already handle this correctly in do_ld16_beN. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- accel/tcg/cputlb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c index 5e2ca47243..14ce97c33b 100644 --- a/accel/tcg/cputlb.c +++ b/accel/tcg/cputlb.c @@ -2727,6 +2727,7 @@ static uint64_t do_st16_leN(CPUArchState *env, MMULookupPageData *p, * and so neither is atomic. */ case MO_ATOM_IFALIGN: + case MO_ATOM_WITHIN16: case MO_ATOM_NONE: stq_le_p(p->haddr, int128_getlo(val_le)); return store_bytes_leN(p->haddr + 8, p->size - 8,