From patchwork Tue Jun 27 16:09:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 696874 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp3866288wrm; Tue, 27 Jun 2023 09:14:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6/d9vj4oLMG49pJHPjD4yrlqC+RF4JKpulurzt3PmXZ3HE2Inv0giGcOnBIkfOKr1iUtNs X-Received: by 2002:a05:6214:2508:b0:635:db0c:df5f with SMTP id gf8-20020a056214250800b00635db0cdf5fmr8078980qvb.1.1687882464812; Tue, 27 Jun 2023 09:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687882464; cv=none; d=google.com; s=arc-20160816; b=BjMdZGUt5grXf4DqdVFRpwlTHDYTSE3DF/YZPdz5SxuLb+ujtONWYIMZRwN2iuO0jW gTRZuzEdZt09sMQBKYzRTe7hf6oSZv1lBUZWR4/5XT8p62AqkAKTKWVAvX9j2GHtlREP NHZhph0Dzg9SGfRWN9CBsfr3l4BF7kG0qOtEit494HNJUYOFqSjUNJfWsP+f1tGlAwfD He4cI5ACo9jpFnkFqI0yr3hQgNoiyx4kMQs409fCO0iOjO/GN2+x9GulF2POQ+osmNG5 bBwtrhx0VRk+ak9a/e7MRICPfyX5prXZWwvVs6oFx4eo1HKil2AssA1Cl7wFBO5y6Uae aTow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; fh=UWYnW1U3ElmagJZfLzBYN43uMWpFZC1VK6uWwJPE4v0=; b=LAMW3AqQxM7vmFyKUKQVZisH5TQvfI3wlvm2kMXUYS2KYf8ZgeiBVJNnUg9AEpDQpx YfK/quhpoJqYcys52Vb7yA9BCooHrn68o+lGPqrRsjOtaJjagERlD1WZgfU0Ha+3HPxX ysugCTWNzvJsxQYWd3jo1M/g3hfK1GXZoYX89NAkiYwa3KM3ZrkWbIDp9jmptlvU9NvH vOl8ZSsxbPf65ePzxnks0j80lQiKb3QriwffUq8nxrSCkXO9229kMLYr0MueeEGKX6iu /Xm7nc9BP6fUitpB/kWLAgDOojAZwY7YnpaUkdGq8X+olmkgt0yUldyCKwYnIRjgj4A8 zJxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdGrfPA6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 2-20020a0562140d6200b006237b7ba84csi3471531qvs.108.2023.06.27.09.14.24 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Jun 2023 09:14:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=VdGrfPA6; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEBGP-0008MK-2L; Tue, 27 Jun 2023 12:09:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEBGK-0007yR-Ej for qemu-devel@nongnu.org; Tue, 27 Jun 2023 12:09:52 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEBGF-0005mu-Lc for qemu-devel@nongnu.org; Tue, 27 Jun 2023 12:09:51 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3fa96fd79f0so32613885e9.3 for ; Tue, 27 Jun 2023 09:09:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687882186; x=1690474186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=VdGrfPA6puzynaTrxTFdyHjJSEEkIgsO6RsORbiy5JhNRfN9QsMoj6jtRHHMbUUvMV BiHAj0em54V6lf/Rl5gOk5quzoLvPFci4XTZ7SklZP8sf4x+UKZvuYDOsQvS+Js1et4V RezQ9Gg5vxJmmzCw5SgOeRmr2HKLVrR0NhJdTd2AJkFB+3hCKirvOafPER5wM+COCb50 2S/7gH0suykPW60tSscOzGTyAFOZmnu7nrgqpLIcRb0D/qYot2qgrQctFfldeJkFW3+x MdcprhveDXLEjfHSrFz8y3pzpZtLwJD+D8HQgORuMHWol+XTPw3Vry+QU/TpC2ut7bU/ RKAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687882186; x=1690474186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hn+zKX2ZU5kJ7IFfmWrHts4Msqz+nCT2HShGHhdqu5E=; b=YSdwCRCSpp0XwkB/Hp0pWSgK+dOfKTQW8bCaBLSir8xokrZp3SHBO0MQ1jVykAuX5a /V4ASiZsQzwMyM1/LIgOlMXav4LMjS8KvM9URRl136+IQp5NVpn7KpioklfNAJNPzK2t KLwAm3rYUbv+gGxFi76MWpPL9CKTur+sQshf71z4JySlW5zp5AgzlfVqurF7BqS9H6/7 j2wYNfyg/Pzcxk0b87DY+826AmnXXqbeaAtd/24ix1G6BMh+5HCvyVfkJEQAK3SMecu+ 60qI6uyUw3QzF0iVH5apEcnAuN6NvSTEuCEkBQ7z7PF+IR77KwVNchDD/9zd7o5zCg7Q 4FOQ== X-Gm-Message-State: AC+VfDzPOmKJ1x/aU9brUfOoL9Mi5SrEn4apvKUgTMkkNFuTOZH0hqU9 7TQhHTSdfAXbq13Jd4JaPqpRRGEok4EBEk4HNdg= X-Received: by 2002:a05:600c:2284:b0:3fa:8219:9163 with SMTP id 4-20020a05600c228400b003fa82199163mr13570168wmf.21.1687882186358; Tue, 27 Jun 2023 09:09:46 -0700 (PDT) Received: from zen.linaroharston ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id n9-20020a1c7209000000b003fbacc853ccsm80148wmc.18.2023.06.27.09.09.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jun 2023 09:09:44 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5964E1FFC0; Tue, 27 Jun 2023 17:09:44 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Wainer dos Santos Moschetta , Juan Quintela , Thomas Huth , Cleber Rosa , Leonardo Bras , Beraldo Leal , Peter Maydell , Bin Meng , Yanan Wang , Darren Kenny , Alexander Bulekov , Marcel Apfelbaum , Peter Xu , Radoslaw Biernacki , Laurent Vivier , Paolo Bonzini , Eduardo Habkost , qemu-arm@nongnu.org, Stefan Hajnoczi , Richard Henderson , Bandan Das , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?= =?utf-8?q?el_P=2E_Berrang=C3=A9?= , Alexandre Iooss , Marcin Juszkiewicz , Leif Lindholm , Laurent Vivier , Qiuhao Li , Mahmoud Mandour , Riku Voipio , =?utf-8?q?Alex_Benn=C3=A9e?= , Ani Sinha Subject: [PATCH v3 04/36] docs/devel: remind developers to run CI container pipeline when updating images Date: Tue, 27 Jun 2023 17:09:11 +0100 Message-Id: <20230627160943.2956928-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230627160943.2956928-1-alex.bennee@linaro.org> References: <20230627160943.2956928-1-alex.bennee@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Ani Sinha When new dependencies and packages are added to containers, its important to run CI container generation pipelines on gitlab to make sure that there are no obvious conflicts between packages that are being added and those that are already present. Running CI container pipelines will make sure that there are no such breakages before we commit the change updating the containers. Add a line in the documentation reminding developers to run the pipeline before submitting the change. It will also ease the life of the maintainers. Signed-off-by: Ani Sinha Reviewed-by: Daniel P. Berrangé Message-Id: <20230506072012.10350-1-anisinha@redhat.com> Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé --- docs/devel/testing.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst index 203facb417..8f18052ba7 100644 --- a/docs/devel/testing.rst +++ b/docs/devel/testing.rst @@ -485,6 +485,12 @@ first to contribute the mapping to the ``libvirt-ci`` project: `CI `__ documentation page on how to trigger gitlab CI pipelines on your change. + * Please also trigger gitlab container generation pipelines on your change + for as many OS distros as practical to make sure that there are no + obvious breakages when adding the new pre-requisite. Please see + `CI `__ documentation + page on how to trigger gitlab CI pipelines on your change. + For enterprise distros that default to old, end-of-life versions of the Python runtime, QEMU uses a separate set of mappings that work with more recent versions. These can be found in ``tests/lcitool/mappings.yml``.