From patchwork Wed Jun 28 15:52:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 697249 Delivered-To: patch@linaro.org Received: by 2002:adf:e885:0:0:0:0:0 with SMTP id d5csp4423529wrm; Wed, 28 Jun 2023 08:58:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7UO52APv3blUj+m9fOoCnSLk74DKoCe+cIk60EHZ74eJll1sdoOetmfxEWfkZXo4Kza1eZ X-Received: by 2002:a05:6808:1924:b0:39a:a9e6:af3 with SMTP id bf36-20020a056808192400b0039aa9e60af3mr50772884oib.49.1687967893353; Wed, 28 Jun 2023 08:58:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687967893; cv=none; d=google.com; s=arc-20160816; b=gtDkxnS3NYAqtIflhO3q4b1p+sd8O1WwdyVRPavtbnBlINfIyGvJ8cumkJZdNn0Ci9 RCZEY8E7diKb3CJVsDCbOGmcFbgXtr+7fWfZre4SIQvG2Jv2YMgow6UebVjsTqQngxnp ohefuzWxK49sTp4H5nkDV7Y5ErdyzlOhGrTfVs3nyLkMGBCNpsSTLyjMkTBMWMjGiUnZ FlZkjW7Nb671qSfyXxszOJ23UZQdiUWPKT3iqDlC6/7OJyioJWNOtnWfV8IeBl5/qD7p LBfuRaCvjmRveqFrnfUAYVh5EJgDpji0+gfQ17nAgNhDEHQpQ7O7MLstdgbmPYVxW23z 7VpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=M4pELBSXaj94TdEs4Hqr6RUUTU6KwmRqNkUY4T4RPC0=; fh=qtn8prgQtzf5IzCNvLChUZDElvNECP6ej9YfjQeBz3I=; b=UoPoA9J9citUnqPd/vt96TTs328DkZGG7qISsmcWpkeq8ogJ13eOL4WmAGPe9Q6ztJ 9iz5LGTx4Nhx5DrIoIu0auF7EnyzlAi5E8JfCyDiuFEFYAWsdk7zBggMc5sx1QB6ohAm +BhYGc3/p65X/Wi/1lfoRiJfa6ZyWggRRbit5kVJFBLl5/cqIkwhbVv45xZCJ54A3k24 Fiz2mYw8YXoiqIfBUljkRHVe7EHTtOb9EKcOO46pb76T3NyCmLqcOm4UDZKbPH2GBwIh gcSha5095r6LdEQ15pJsUt9N0zY4uRGtKPKpr3zFj37R9xT4PGreR68WA8+X2FXqdTcj qfbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yM6RQlvG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id q11-20020a05622a030b00b003ff21deefe5si4794348qtw.502.2023.06.28.08.58.13 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jun 2023 08:58:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yM6RQlvG; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qEXUL-000624-Ku; Wed, 28 Jun 2023 11:53:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEXUJ-00061Z-OR for qemu-devel@nongnu.org; Wed, 28 Jun 2023 11:53:47 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEXUI-00083X-70 for qemu-devel@nongnu.org; Wed, 28 Jun 2023 11:53:47 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-977e0fbd742so713082866b.2 for ; Wed, 28 Jun 2023 08:53:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687967624; x=1690559624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=M4pELBSXaj94TdEs4Hqr6RUUTU6KwmRqNkUY4T4RPC0=; b=yM6RQlvGIBPD5YHXRzZgP564Q2NFVDp7Xmvp+L3VXSTF2Q0TITRvaW1umeFteQQl99 uJ5fYIbpVcnaQlsmFj9aMTVeUhX3VKmAOn0gDRjft+2Hh+UizVb70o3ulsdixf5fxk3i 970ZyI4Z4ffse9rPn5i01avhk4C3a+w8D8OD1yIOdCTZebUDmU74cwEruU/XtIv001IR nI6BMhH21mS4eZGxsIwl4Wc4U8ODQmqhzMRxt2V+xH6YDR3OxFBtQxe9wuT9RVSiwIAt 8t3/KI4yrp87GYVs2AvA8HrOXzNer4kdkpSu1kJNj7av3tI4ruWKkDVct2DU4isP8Cqg 8R+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687967624; x=1690559624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=M4pELBSXaj94TdEs4Hqr6RUUTU6KwmRqNkUY4T4RPC0=; b=jW/dQo7DsNv/hcCbPd4NVpYxMMDWW4VigOwFm38r4w4BtB7LemThz00qaJ1ye/fZA9 OZ1N60gzSQd7IIvbR1Ergu2oPynRuGT6zselCVEqri3SFBi0edAWXdxRzTq/msWoO/x8 spjU45j0RXFnV0FEY/6+yXH1XnfgXXyBYIxF985fcq7yUGHTrAJg/RklYuBSOjwFSKmK Lb1jJDVqXlABJQr2Y8d5rRfZJGziBlaj45y9jYWm4MY895iH24QvGqnBHq0mvol5tCwn rzql39KhgQQnZpAE2nw92bJ+58QbvZkdUsyYWXIBnGI5Py9xmp7CkKlNw+xvsy8sGbGw 6D6Q== X-Gm-Message-State: AC+VfDw6TAKYxcAQ+RCdErptvRFdeSfrHw5cnfXjovhEt0bBa73nYFa/ oEb2G3fe8biHELgyvmjsEobrdhVmk0xs8cDuXPo= X-Received: by 2002:a17:907:2687:b0:97c:64bd:50a5 with SMTP id bn7-20020a170907268700b0097c64bd50a5mr31263586ejc.53.1687967624737; Wed, 28 Jun 2023 08:53:44 -0700 (PDT) Received: from m1x-phil.lan ([176.187.207.229]) by smtp.gmail.com with ESMTPSA id e8-20020a1709062c0800b0098822e05539sm5784963ejh.191.2023.06.28.08.53.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 28 Jun 2023 08:53:44 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PULL 05/30] accel: Remove unused hThread variable on TCG/WHPX Date: Wed, 28 Jun 2023 17:52:48 +0200 Message-Id: <20230628155313.71594-6-philmd@linaro.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230628155313.71594-1-philmd@linaro.org> References: <20230628155313.71594-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=philmd@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org On Windows hosts, cpu->hThread is assigned but never accessed: remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20230624174121.11508-4-philmd@linaro.org> --- accel/tcg/tcg-accel-ops-mttcg.c | 4 ---- accel/tcg/tcg-accel-ops-rr.c | 3 --- target/i386/whpx/whpx-accel-ops.c | 3 --- 3 files changed, 10 deletions(-) diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttcg.c index b320ff0037..b276262007 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -152,8 +152,4 @@ void mttcg_start_vcpu_thread(CPUState *cpu) qemu_thread_create(cpu->thread, thread_name, mttcg_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); - -#ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); -#endif } diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 23e4d0f452..2d523289a8 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -329,9 +329,6 @@ void rr_start_vcpu_thread(CPUState *cpu) single_tcg_halt_cond = cpu->halt_cond; single_tcg_cpu_thread = cpu->thread; -#ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); -#endif } else { /* we share the thread */ cpu->thread = single_tcg_cpu_thread; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-accel-ops.c index e8dc4b3a47..67cad86720 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -71,9 +71,6 @@ static void whpx_start_vcpu_thread(CPUState *cpu) cpu->cpu_index); qemu_thread_create(cpu->thread, thread_name, whpx_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); -#ifdef _WIN32 - cpu->hThread = qemu_thread_get_handle(cpu->thread); -#endif } static void whpx_kick_vcpu_thread(CPUState *cpu)