| Message ID | 20230915190009.68404-2-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | accel: Restrict tcg_exec_[un]realizefn() to TCG | expand |
Reviewed-by: Claudio Fontana <cfontana@suse.de> On 9/15/23 21:00, Philippe Mathieu-Daudé wrote: > We use the '*fn' suffix for handlers, this is a public method. > Drop the suffix. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > include/qemu/accel.h | 4 ++-- > accel/accel-common.c | 2 +- > cpu.c | 2 +- > target/i386/kvm/kvm-cpu.c | 2 +- > 4 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/include/qemu/accel.h b/include/qemu/accel.h > index e84db2e3e5..cb64a07b84 100644 > --- a/include/qemu/accel.h > +++ b/include/qemu/accel.h > @@ -90,11 +90,11 @@ void accel_setup_post(MachineState *ms); > void accel_cpu_instance_init(CPUState *cpu); > > /** > - * accel_cpu_realizefn: > + * accel_cpu_realize: > * @cpu: The CPU that needs to call accel-specific cpu realization. > * @errp: currently unused. > */ > -bool accel_cpu_realizefn(CPUState *cpu, Error **errp); > +bool accel_cpu_realize(CPUState *cpu, Error **errp); > > /** > * accel_supported_gdbstub_sstep_flags: > diff --git a/accel/accel-common.c b/accel/accel-common.c > index df72cc989a..b953855e8b 100644 > --- a/accel/accel-common.c > +++ b/accel/accel-common.c > @@ -119,7 +119,7 @@ void accel_cpu_instance_init(CPUState *cpu) > } > } > > -bool accel_cpu_realizefn(CPUState *cpu, Error **errp) > +bool accel_cpu_realize(CPUState *cpu, Error **errp) > { > CPUClass *cc = CPU_GET_CLASS(cpu); > > diff --git a/cpu.c b/cpu.c > index 0769b0b153..61c9760e62 100644 > --- a/cpu.c > +++ b/cpu.c > @@ -136,7 +136,7 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp) > /* cache the cpu class for the hotpath */ > cpu->cc = CPU_GET_CLASS(cpu); > > - if (!accel_cpu_realizefn(cpu, errp)) { > + if (!accel_cpu_realize(cpu, errp)) { > return; > } > > diff --git a/target/i386/kvm/kvm-cpu.c b/target/i386/kvm/kvm-cpu.c > index 7237378a7d..4474689f81 100644 > --- a/target/i386/kvm/kvm-cpu.c > +++ b/target/i386/kvm/kvm-cpu.c > @@ -35,7 +35,7 @@ static bool kvm_cpu_realizefn(CPUState *cs, Error **errp) > * x86_cpu_realize(): > * -> x86_cpu_expand_features() > * -> cpu_exec_realizefn(): > - * -> accel_cpu_realizefn() > + * -> accel_cpu_realize() > * kvm_cpu_realizefn() -> host_cpu_realizefn() > * -> check/update ucode_rev, phys_bits, mwait > */
diff --git a/include/qemu/accel.h b/include/qemu/accel.h index e84db2e3e5..cb64a07b84 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -90,11 +90,11 @@ void accel_setup_post(MachineState *ms); void accel_cpu_instance_init(CPUState *cpu); /** - * accel_cpu_realizefn: + * accel_cpu_realize: * @cpu: The CPU that needs to call accel-specific cpu realization. * @errp: currently unused. */ -bool accel_cpu_realizefn(CPUState *cpu, Error **errp); +bool accel_cpu_realize(CPUState *cpu, Error **errp); /** * accel_supported_gdbstub_sstep_flags: diff --git a/accel/accel-common.c b/accel/accel-common.c index df72cc989a..b953855e8b 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -119,7 +119,7 @@ void accel_cpu_instance_init(CPUState *cpu) } } -bool accel_cpu_realizefn(CPUState *cpu, Error **errp) +bool accel_cpu_realize(CPUState *cpu, Error **errp) { CPUClass *cc = CPU_GET_CLASS(cpu); diff --git a/cpu.c b/cpu.c index 0769b0b153..61c9760e62 100644 --- a/cpu.c +++ b/cpu.c @@ -136,7 +136,7 @@ void cpu_exec_realizefn(CPUState *cpu, Error **errp) /* cache the cpu class for the hotpath */ cpu->cc = CPU_GET_CLASS(cpu); - if (!accel_cpu_realizefn(cpu, errp)) { + if (!accel_cpu_realize(cpu, errp)) { return; } diff --git a/target/i386/kvm/kvm-cpu.c b/target/i386/kvm/kvm-cpu.c index 7237378a7d..4474689f81 100644 --- a/target/i386/kvm/kvm-cpu.c +++ b/target/i386/kvm/kvm-cpu.c @@ -35,7 +35,7 @@ static bool kvm_cpu_realizefn(CPUState *cs, Error **errp) * x86_cpu_realize(): * -> x86_cpu_expand_features() * -> cpu_exec_realizefn(): - * -> accel_cpu_realizefn() + * -> accel_cpu_realize() * kvm_cpu_realizefn() -> host_cpu_realizefn() * -> check/update ucode_rev, phys_bits, mwait */
We use the '*fn' suffix for handlers, this is a public method. Drop the suffix. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- include/qemu/accel.h | 4 ++-- accel/accel-common.c | 2 +- cpu.c | 2 +- target/i386/kvm/kvm-cpu.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-)