From patchwork Fri Sep 29 08:50:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 727603 Delivered-To: patch@linaro.org Received: by 2002:a5d:60c8:0:b0:31d:da82:a3b4 with SMTP id x8csp331901wrt; Fri, 29 Sep 2023 01:52:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGANMy9pqAqN0bONWi5l55Ls/Kt8ifkPyErj9cr4NJdxo6f/SqzNEhAsu3WHsK+RJaX83cl X-Received: by 2002:a05:620a:bc1:b0:76f:1268:9e26 with SMTP id s1-20020a05620a0bc100b0076f12689e26mr3812541qki.24.1695977530329; Fri, 29 Sep 2023 01:52:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695977530; cv=none; d=google.com; s=arc-20160816; b=MxcDEBPygs1Xg4s9kdWvGFfiQHqbpYFXpp0S+a+DivUcaxAkkdF2H0LFA7CN6a4O/n TLG0xvY3maKnZ2NBY8YZhwdLP+MnYSBB7EGe0AWbaceWHLoo2bw0Ngunr8sairbH4kfb GGig0pQhrenw20HISjW39/EPts4+zLG+uVWvneUG6UjTZSFvFaXafvozt+/8B8vo8P5L 59AU+9GY1mkrOMkDlOdJotvsVgnkD1c+Du5zJRLr19C/13BnMx7nJq9mEnQsZyfH0iGY g0drotTBWH4LLGrrGR5HZtPxu8HSVBQR56Uz8M8WUubGDOHYDP+OkVHTGcDhl5TKmLDJ 3uSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ll5bXXu1nVFA0cbGY/6KvJ6V2dFJkq3aCHLqLxUxRGI=; fh=Z+dvssxbQM7eXtANqJ47vy+t1tQRtHmIMmw64Hhqipo=; b=nKrogh/CUmU1u+lE3szaaSN+2LFTUkHC30faHC505exuhgDGfZQrdsomjvkdkX40ZG o9AM0V7ubh9W7D2iYdsd1hR7jFIhdw0l68BAkl7OvAGllUbJeN+zjbslayT6hMFNZeOj rRlkvJF0sjz/3DAcjVOIdUoC1qKtm6c9MdE3CojzupZ2ox+WxuvYgWoD/mojC2pEsHPn QLQW+EibkzFpdLsKcns4jm0dZcVopWBO544szFI5SDWYHEaLNisGat8cp2UzVTEQwqtT WSdsaVl2S3/Dtz3L+3CzNiFvOq+b5pGibcYrguhdyWdKGlqlFKqJ4WVlxO0Mf1BX6muo Nx/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fYGIgKtn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i11-20020a05620a248b00b00775907603f0si216628qkn.470.2023.09.29.01.52.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 Sep 2023 01:52:10 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fYGIgKtn; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qm9DZ-000596-M7; Fri, 29 Sep 2023 04:51:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9DV-000520-Ai for qemu-devel@nongnu.org; Fri, 29 Sep 2023 04:51:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qm9DB-0005cs-Tj for qemu-devel@nongnu.org; Fri, 29 Sep 2023 04:51:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695977461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ll5bXXu1nVFA0cbGY/6KvJ6V2dFJkq3aCHLqLxUxRGI=; b=fYGIgKtnYHEblAqXOdvKkuccq9FBVMXAiFnYUi0rm2uFoWlaiXmGxbEWTMX/WOJ5Niz7Nq ebMObLIeFlY63YM17ajkC9XU8SfowstDYMqng5SwgA8cduRq5z7kGrTgl1sL0cSveGUVr6 r5TogwRLJvvqpkuIHEJ6FQuZXToWZ+E= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-xP6j9z8_NI2t_HgIbxbisA-1; Fri, 29 Sep 2023 04:50:56 -0400 X-MC-Unique: xP6j9z8_NI2t_HgIbxbisA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A091B101A53B; Fri, 29 Sep 2023 08:50:55 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D7D714171CA; Fri, 29 Sep 2023 08:50:55 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 7230B21E6915; Fri, 29 Sep 2023 10:50:53 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Cc: stefanha@redhat.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PULL 12/56] target/m68k: Clean up local variable shadowing Date: Fri, 29 Sep 2023 10:50:09 +0200 Message-ID: <20230929085053.2789105-13-armbru@redhat.com> In-Reply-To: <20230929085053.2789105-1-armbru@redhat.com> References: <20230929085053.2789105-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass client-ip=170.10.133.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé Fix: target/m68k/translate.c:828:18: error: declaration shadows a local variable [-Werror,-Wshadow] TCGv tmp = tcg_temp_new(); ^ target/m68k/translate.c:801:15: note: previous declaration is here TCGv reg, tmp, result; ^ Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-ID: <20230904161235.84651-6-philmd@linaro.org> Signed-off-by: Markus Armbruster --- target/m68k/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 9e224fe796..15c9ddf427 100644 --- a/target/m68k/translate.c +++ b/target/m68k/translate.c @@ -824,7 +824,7 @@ static TCGv gen_ea_mode(CPUM68KState *env, DisasContext *s, int mode, int reg0, reg = get_areg(s, reg0); result = gen_ldst(s, opsize, reg, val, what, index); if (what == EA_STORE || !addrp) { - TCGv tmp = tcg_temp_new(); + tmp = tcg_temp_new(); if (reg0 == 7 && opsize == OS_BYTE && m68k_feature(s->env, M68K_FEATURE_M68K)) { tcg_gen_addi_i32(tmp, reg, 2);