From patchwork Sun Oct 22 06:00:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 736946 Delivered-To: patch@linaro.org Received: by 2002:adf:dd81:0:b0:32d:baff:b0ca with SMTP id x1csp1004450wrl; Sat, 21 Oct 2023 23:06:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIUI5mfmOE15tVdU+DsbYdnx7KKGl+xAU/1H+Wm3/mkCD6ne5O1jPN6xiPoAReGH1P3AyM X-Received: by 2002:ac8:5f52:0:b0:41c:cd2a:f05a with SMTP id y18-20020ac85f52000000b0041ccd2af05amr7461418qta.25.1697954816806; Sat, 21 Oct 2023 23:06:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697954816; cv=none; d=google.com; s=arc-20160816; b=nZCsU0WrkNL1OuM4a2VeGGijsjyczsqsMyeNh4OREg7motwuiKp6owQriN7fYBREvb xfm03Ys9VfGc+sKpBk2Po+4Es81XEtn3qBo3rW7jVIrMIqYDRJT4rrDth3W+52gTZLEt BgINguB721q1TF2/I2hN4x07ydOEzxdc5L7Y0SbeKRj6Qb3hWDKGEsC5VhztFZki3YUr JHshW1K/7V74WyO1t4Dfqt+RpUwViOq9EYxz6Fp4HCmAulZswaj/oXUgOrEhAraDG6QM aoId5Rn599fCxPnVGra3b2fLeQD/YEd/0GWZHr0rP0goVWPXw3OIVkaJaZE2G6qsAO8t g52g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RJtaWlcxrarLCoB15zwusHSxvRo75ARkuqoEtKfRk/k=; fh=TYrED6TOMxGX0VC4GtjviASLbYyJe19+7/tKWjN44KQ=; b=hbCFjZmLHHS3OIgjfBVdhhUJHgbN1xVPFOLiyhu57n+YnXhSFJiryxiZLVFj+WVzwb +yjTBsRuAvQBhtpfAkMU4s1L6KMzKPQsRYi3jbccJ5S7qRKQ3JrNi4QAuNQOsMEYvFPo EiEX/fDsrth6DR3YhQSLSpYNkOMWX9c2oiovZMpvZyjfyj48EvI1MbT5WJUXzXnnouLr i25FJPQJhfBvLEHkQ/viNy/EnpWGnuGnQf3FZFaMqzbHCGmyc+NcuT33jafxbj9YtDyu KcDNCDQkzzsyJST3xvZuJsRYy7hpKYlsGNLUJJo8rwHb5hesW8GP0lzLeXHUwnTqDw3d nXYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nu+GbKga; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g4-20020ac85d44000000b00419ccbf0021si3764404qtx.9.2023.10.21.23.06.56 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2023 23:06:56 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=nu+GbKga; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quRbP-0004pU-CQ; Sun, 22 Oct 2023 02:06:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quRaV-000375-0i for qemu-devel@nongnu.org; Sun, 22 Oct 2023 02:05:23 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quRaE-0002LF-VN for qemu-devel@nongnu.org; Sun, 22 Oct 2023 02:05:21 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6b89ab5ddb7so2209381b3a.0 for ; Sat, 21 Oct 2023 23:05:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697954705; x=1698559505; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RJtaWlcxrarLCoB15zwusHSxvRo75ARkuqoEtKfRk/k=; b=nu+GbKga92BzynyFHSL+oeonWve4i+RSowHt3d+1xXQnJa03r19oUQphqncTI6zzqy XGJ4Hk19NbNYHcvh26toN1en7jfKM3B5SJ5qai+vbjtmaxVDtdbjKTVT+ISedCBsvFhi G0bjTkCzEbRFuCZuzNbuKl1xjFJTgpw29JoGow8oyPB0OtB8fH6nPU5Be4Xjq3DXZpVZ EO6EgAWh36RW4kV+sOPXna3eHaqHYod1VpRZkny7ZYZwjR7sIYvmLPV4NxxANeLtmZFX v84FfCXgFN/BXfnWzB6zuqK+QRasOzD8HN1gllckoppKsQowzS9M3n1ARe4pKW7YtT6e O/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697954705; x=1698559505; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RJtaWlcxrarLCoB15zwusHSxvRo75ARkuqoEtKfRk/k=; b=ECgx5xswDhu5IgeB8DFfjZeHmuAm4QLFclsaA9i9vvQFxwPvClYrP5syTmDYJ4BPcT zQVJ6g1JM1r+lqqfPeshstd/ZRFaVGBusyLKj4rYreTR6lEts3NK6pcCpY13E0KNsWZ0 tCo4DwsBWbcVUKx6VhACR+MIGKCVGfqIMuCuvl/gv+xTWB7tcBF2YxUAtviNuwHTc3oN XAsIDz+n/+gakfwQhtKaeKZpBox7FeNE22zIQGhcy0mJ587nsKDr5ik8eawXjh+AIgsJ CP0yK8PN+Eq0F70mNZ6HNS0nah8jgVLYGFytI1aWzVJZR6aJ+FkJUw95cSrbM5Np/pKP goYA== X-Gm-Message-State: AOJu0Yx+D8laDwUPzLYtY8pYtPih/dQOoOhWi5UOlJE9Q+taQRSmpJuN ov+DrJwfiuYQaNENLZiQpL+2O9x65txM86QAZMI= X-Received: by 2002:a05:6a00:2e97:b0:692:a727:1fdd with SMTP id fd23-20020a056a002e9700b00692a7271fddmr7680283pfb.4.1697954705086; Sat, 21 Oct 2023 23:05:05 -0700 (PDT) Received: from stoup.. ([71.212.149.95]) by smtp.gmail.com with ESMTPSA id fb13-20020a056a002d8d00b0068a46cd4120sm4007373pfb.199.2023.10.21.23.05.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 23:05:04 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: mark.cave-ayland@ilande.co.uk Subject: [PATCH v4 75/90] target/sparc: Move gen_fop_QQQ insns to decodetree Date: Sat, 21 Oct 2023 23:00:16 -0700 Message-Id: <20231022060031.490251-76-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231022060031.490251-1-richard.henderson@linaro.org> References: <20231022060031.490251-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org Move FADDq, FSUBq, FMULq, FDIVq. Signed-off-by: Richard Henderson --- target/sparc/insns.decode | 4 +++ target/sparc/translate.c | 52 +++++++++++++++++++-------------------- 2 files changed, 30 insertions(+), 26 deletions(-) diff --git a/target/sparc/insns.decode b/target/sparc/insns.decode index a429c04980..f18fd99476 100644 --- a/target/sparc/insns.decode +++ b/target/sparc/insns.decode @@ -250,12 +250,16 @@ FSQRTd 10 ..... 110100 00000 0 0010 1010 ..... @r_r2 FSQRTq 10 ..... 110100 00000 0 0010 1011 ..... @r_r2 FADDs 10 ..... 110100 ..... 0 0100 0001 ..... @r_r_r FADDd 10 ..... 110100 ..... 0 0100 0010 ..... @r_r_r +FADDq 10 ..... 110100 ..... 0 0100 0011 ..... @r_r_r FSUBs 10 ..... 110100 ..... 0 0100 0101 ..... @r_r_r FSUBd 10 ..... 110100 ..... 0 0100 0110 ..... @r_r_r +FSUBq 10 ..... 110100 ..... 0 0100 0111 ..... @r_r_r FMULs 10 ..... 110100 ..... 0 0100 1001 ..... @r_r_r FMULd 10 ..... 110100 ..... 0 0100 1010 ..... @r_r_r +FMULq 10 ..... 110100 ..... 0 0100 1011 ..... @r_r_r FDIVs 10 ..... 110100 ..... 0 0100 1101 ..... @r_r_r FDIVd 10 ..... 110100 ..... 0 0100 1110 ..... @r_r_r +FDIVq 10 ..... 110100 ..... 0 0100 1111 ..... @r_r_r FdTOx 10 ..... 110100 00000 0 1000 0010 ..... @r_r2 FxTOd 10 ..... 110100 00000 0 1000 1000 ..... @r_r2 FiTOs 10 ..... 110100 00000 0 1100 0100 ..... @r_r2 diff --git a/target/sparc/translate.c b/target/sparc/translate.c index 7e0990a021..47f4d0b51c 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -1666,19 +1666,6 @@ static void gen_ne_fop_QQ(DisasContext *dc, int rd, int rs, } #endif -static void gen_fop_QQQ(DisasContext *dc, int rd, int rs1, int rs2, - void (*gen)(TCGv_ptr)) -{ - gen_op_load_fpr_QT0(QFPREG(rs1)); - gen_op_load_fpr_QT1(QFPREG(rs2)); - - gen(tcg_env); - gen_helper_check_ieee_exceptions(cpu_fsr, tcg_env); - - gen_op_store_QT0_fpr(QFPREG(rd)); - gen_update_fprs_dirty(dc, QFPREG(rd)); -} - static void gen_fop_DFF(DisasContext *dc, int rd, int rs1, int rs2, void (*gen)(TCGv_i64, TCGv_ptr, TCGv_i32, TCGv_i32)) { @@ -5125,6 +5112,31 @@ static bool do_dddd(DisasContext *dc, arg_r_r_r *a, TRANS(PDIST, VIS1, do_dddd, a, gen_helper_pdist) +static bool do_env_qqq(DisasContext *dc, arg_r_r_r *a, + void (*func)(TCGv_env)) +{ + if (gen_trap_ifnofpu(dc)) { + return true; + } + if (gen_trap_float128(dc)) { + return true; + } + + gen_op_clear_ieee_excp_and_FTT(); + gen_op_load_fpr_QT0(QFPREG(a->rs1)); + gen_op_load_fpr_QT1(QFPREG(a->rs2)); + func(tcg_env); + gen_helper_check_ieee_exceptions(cpu_fsr, tcg_env); + gen_op_store_QT0_fpr(QFPREG(a->rd)); + gen_update_fprs_dirty(dc, QFPREG(a->rd)); + return advance_pc(dc); +} + +TRANS(FADDq, ALL, do_env_qqq, a, gen_helper_faddq) +TRANS(FSUBq, ALL, do_env_qqq, a, gen_helper_fsubq) +TRANS(FMULq, ALL, do_env_qqq, a, gen_helper_fmulq) +TRANS(FDIVq, ALL, do_env_qqq, a, gen_helper_fdivq) + #define CHECK_IU_FEATURE(dc, FEATURE) \ if (!((dc)->def->features & CPU_FEATURE_ ## FEATURE)) \ goto illegal_insn; @@ -5186,23 +5198,11 @@ static void disas_sparc_legacy(DisasContext *dc, unsigned int insn) case 0x46: /* fsubd */ case 0x4a: /* fmuld */ case 0x4e: /* fdivd */ - g_assert_not_reached(); /* in decodetree */ case 0x43: /* faddq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_faddq); - break; case 0x47: /* fsubq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_fsubq); - break; case 0x4b: /* fmulq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_fmulq); - break; case 0x4f: /* fdivq */ - CHECK_FPU_FEATURE(dc, FLOAT128); - gen_fop_QQQ(dc, rd, rs1, rs2, gen_helper_fdivq); - break; + g_assert_not_reached(); /* in decodetree */ case 0x69: /* fsmuld */ CHECK_FPU_FEATURE(dc, FSMULD); gen_fop_DFF(dc, rd, rs1, rs2, gen_helper_fsmuld);