From patchwork Thu Jan 4 14:11:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 759854 Delivered-To: patch@linaro.org Received: by 2002:a5d:67c6:0:b0:336:6142:bf13 with SMTP id n6csp6991980wrw; Thu, 4 Jan 2024 06:12:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IEpg7lK8NOTekmeqJ0+MbSjDOZHvMa2CldOvZ3ecSxu7evokr/jUyAzWQVL7lTeMa7NP1rb X-Received: by 2002:a05:6358:260b:b0:175:5f:7976 with SMTP id l11-20020a056358260b00b00175005f7976mr698638rwc.24.1704377571132; Thu, 04 Jan 2024 06:12:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1704377571; cv=none; d=google.com; s=arc-20160816; b=pWZYsgbvRyEZuGvLnwxcj9FYd6JM3D5KPnRIaWhoC6d9rHbyWNg+E6bzxMoZ9eqhX6 JlDC39obbpOug6SaIKdNO+YRe5SZ2MgGfmHiio6Gl8frEhikAeOPTt/RSd5XQdROf1Is 8Y8eD+jBvNyibU2oS2UYOPoFwG09McDqp4Mq0pHIH7TTvLhbEByZeqDSmi+NSVKvFPh3 cTqjpl9d5Q6PjFs7png4Q24yZWWBRiz01maoBew3/vLHofuxt1vyAodB+H0mbXsZ90Pm f3CUy9P3pmN/dPaPOzcHzHuIbaD9EhfYdr4kd0cw2rwSbPaJo+PgOZS2fKazcPpSyY+k RPkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=HH/FOzMkAK9P4wWyuKIB0SOChexA4vOozUZ0T8lYoS8=; fh=B6SVMKRdYi+b41ThkwYr4zn1YgSXd92ztSh8thEtKw4=; b=d5+GMQaFNcOhFHSAuy8ITV+ZO6v0CqDwDk0+nxe3WwvPG325fUyu7OwbTL5tnZ1UH+ N3UTWLnZ2yAwqD85NPwX/NNyfNZr3Yhp8oeeNJGdNGkoVptz02qeo155XtCHnM4nJngt vKohzZaOqNjaB0fWpqN6ee33xIG9IjhAeeTHcHkhx/uHd4Vhx9AADqn0wVNmRpgoRpOW +ASMsMo6AxRqNdyHZH/1BQRHhMzd54U5QAaDmfX5nY4fdGfm43kc4uBBKV/qNLU4/GnM Mr5CFSDCLNghSngv1llRnwROAizdKT2FVZDQM3OpSkC/RBK5nO2t5olGzc+uiAE3ESK1 NYPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gF4yh7tA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c5-20020ac85a85000000b004181bc4d5cfsi30350163qtc.642.2024.01.04.06.12.50 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jan 2024 06:12:51 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=gF4yh7tA; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rLOS9-0006Fe-BZ; Thu, 04 Jan 2024 09:12:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rLOS8-0006FI-Aw for qemu-devel@nongnu.org; Thu, 04 Jan 2024 09:12:08 -0500 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rLOS5-0000Jx-C5 for qemu-devel@nongnu.org; Thu, 04 Jan 2024 09:12:07 -0500 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-50ea9daac4cso593216e87.3 for ; Thu, 04 Jan 2024 06:12:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704377523; x=1704982323; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HH/FOzMkAK9P4wWyuKIB0SOChexA4vOozUZ0T8lYoS8=; b=gF4yh7tAutpOO9ZHanxhABaotb8IUvk9jiX2GKoRO021J3yqJNVqgNo4pXdM7ioS8r zukNhi/Tpp4/vLmPfnoVp5Mpcn+k2N1YWTGbDIJJcPEv+sYKEK28f3PYCKRfrnJP9kYh DL2vXnDK8GBm0e7KIQVqosXZ0MmqaF6io+2WGzpyRNHVJiRczzfSm+puaOSJoPF0KaUR eTgzBYWh9ozFbTgozO8rY4q5dxebHyyrz+g4Uvv1elKbXdLIxT2MR1aETQlgDIucfqIR G9Ou1IgTxYm+LPtL4CKdOkAPG/yDTRHlOWxFxX4UWm5YlgCIlAx31nYGJrZaOFKts/Mw LUww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704377523; x=1704982323; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HH/FOzMkAK9P4wWyuKIB0SOChexA4vOozUZ0T8lYoS8=; b=BvQGnlTujlLhf5VqjFcamaIO04HTLsBgygDydtrIVDImIXIMz3nKAWKjW88tRE/Y1x fanJ+/CglZ04khYbxbLiNohYq6JM1GKHAmcEv+pLw69Iiy/OOAHCAbSqgjfO2L8IMV01 jhS2A7xq90Ljaq4Wnoggt2i9VikFHTEw+vTSwdd81Djd099l+ML6jVXj2cd+huUi2Zyo USwIwqO5maAD37P1ZB2GlKvOuRrfxGrBksvzyZW4B4CGrKbRqWUNZsYBUo2fn5nHSQvC W4zUWySzxrEvV4UsreSLDkhX7olozEVI7oYqxN+OD8kGNVXwrtiKJ5UrJSset31ieuuD m2cQ== X-Gm-Message-State: AOJu0YygWoBFAVADC+YJX3Fr1n2z8ZgcRGcb3GObVYcJf7jcWqlH4nyU kONvj4YDDCrACLj1F0ioWCvlMf2QHF9vTSGUsV7QH9VRZHXJ9g== X-Received: by 2002:a05:6512:31c6:b0:50e:712b:393f with SMTP id j6-20020a05651231c600b0050e712b393fmr411303lfe.80.1704377523160; Thu, 04 Jan 2024 06:12:03 -0800 (PST) Received: from m1x-phil.lan ([176.187.194.232]) by smtp.gmail.com with ESMTPSA id p13-20020a05640210cd00b0055298b38768sm18985841edu.80.2024.01.04.06.12.01 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 04 Jan 2024 06:12:02 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Subbaraya Sundeep , qemu-arm@nongnu.org, Felipe Balbi , Alexandre Iooss , Markus Armbruster , =?utf-8?q?In=C3=A8s_Varhol?= , Peter Maydell , Arnaud Minier , Alistair Francis , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= Subject: [PATCH] hw/arm: Add missing QOM parent for v7-M SoCs Date: Thu, 4 Jan 2024 15:11:59 +0100 Message-ID: <20240104141159.53883-1-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::12c; envelope-from=philmd@linaro.org; helo=mail-lf1-x12c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/msf2-som.c | 1 + hw/arm/netduino2.c | 1 + hw/arm/netduinoplus2.c | 1 + hw/arm/olimex-stm32-h405.c | 1 + hw/arm/stm32vldiscovery.c | 1 + 5 files changed, 5 insertions(+) diff --git a/hw/arm/msf2-som.c b/hw/arm/msf2-som.c index 7b3106c790..e93c83c410 100644 --- a/hw/arm/msf2-som.c +++ b/hw/arm/msf2-som.c @@ -66,6 +66,7 @@ static void emcraft_sf2_s2s010_init(MachineState *machine) memory_region_add_subregion(sysmem, DDR_BASE_ADDRESS, ddr); dev = qdev_new(TYPE_MSF2_SOC); + object_property_add_child(OBJECT(machine), "soc", OBJECT(dev)); qdev_prop_set_string(dev, "part-name", "M2S010"); qdev_prop_set_string(dev, "cpu-type", mc->default_cpu_type); diff --git a/hw/arm/netduino2.c b/hw/arm/netduino2.c index 501f63a77f..8b1a9a2437 100644 --- a/hw/arm/netduino2.c +++ b/hw/arm/netduino2.c @@ -44,6 +44,7 @@ static void netduino2_init(MachineState *machine) clock_set_hz(sysclk, SYSCLK_FRQ); dev = qdev_new(TYPE_STM32F205_SOC); + object_property_add_child(OBJECT(machine), "soc", OBJECT(dev)); qdev_connect_clock_in(dev, "sysclk", sysclk); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); diff --git a/hw/arm/netduinoplus2.c b/hw/arm/netduinoplus2.c index 2e58984947..bccd100354 100644 --- a/hw/arm/netduinoplus2.c +++ b/hw/arm/netduinoplus2.c @@ -44,6 +44,7 @@ static void netduinoplus2_init(MachineState *machine) clock_set_hz(sysclk, SYSCLK_FRQ); dev = qdev_new(TYPE_STM32F405_SOC); + object_property_add_child(OBJECT(machine), "soc", OBJECT(dev)); qdev_connect_clock_in(dev, "sysclk", sysclk); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); diff --git a/hw/arm/olimex-stm32-h405.c b/hw/arm/olimex-stm32-h405.c index d793de7c97..4ad7b043be 100644 --- a/hw/arm/olimex-stm32-h405.c +++ b/hw/arm/olimex-stm32-h405.c @@ -47,6 +47,7 @@ static void olimex_stm32_h405_init(MachineState *machine) clock_set_hz(sysclk, SYSCLK_FRQ); dev = qdev_new(TYPE_STM32F405_SOC); + object_property_add_child(OBJECT(machine), "soc", OBJECT(dev)); qdev_connect_clock_in(dev, "sysclk", sysclk); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); diff --git a/hw/arm/stm32vldiscovery.c b/hw/arm/stm32vldiscovery.c index 190db6118b..cc41935160 100644 --- a/hw/arm/stm32vldiscovery.c +++ b/hw/arm/stm32vldiscovery.c @@ -47,6 +47,7 @@ static void stm32vldiscovery_init(MachineState *machine) clock_set_hz(sysclk, SYSCLK_FRQ); dev = qdev_new(TYPE_STM32F100_SOC); + object_property_add_child(OBJECT(machine), "soc", OBJECT(dev)); qdev_connect_clock_in(dev, "sysclk", sysclk); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);