From patchwork Tue Jan 23 10:24:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 765193 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:10c4:b0:337:62d3:c6d5 with SMTP id b4csp1528765wrx; Tue, 23 Jan 2024 02:25:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHfmXLYD8BMz+gI6jFTnUtXdswgaooguXzsXzBrKBsYpvM6nTjkx4HGYzUSrliRVMQYXdCe X-Received: by 2002:a05:6214:c45:b0:685:3dcd:239b with SMTP id r5-20020a0562140c4500b006853dcd239bmr758461qvj.106.1706005548906; Tue, 23 Jan 2024 02:25:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1706005548; cv=none; d=google.com; s=arc-20160816; b=LihwT/JkzU7PON2oXoFpK06QIyU4RMUcNJEkPY+qwafRER3R52a0nRd8fWmEqEPSw2 hq5d//ynKghaa/g2aZJ68HMmSC4KsOh4pXAtF4RYCfYGJFOAm4MvQKByV/PE4aom5zQE i0kskv52bPf8pkDrtnb15UMe9do6o4MJWqlCiCmFkUa1vx2aSqT7O/MbOsC5x30EdH3F Mmbyy1RUb2snQ2fJwVCo79FWixp7eCmAHJ0/mDL2qrWjhvMEzNBKuWNpEdKd7LbKweoW Eu6YH7C6jUbv7y7vosg/+d0QsHQoD9czugDT9ptoSSfIVlWnj4e17FRJKRegEGUejlNi MIBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E554SzyD9ekZLsqgb3tmLUdyIwMdiLrTVwZboQHPuUo=; fh=pIQ/pnZIlSJRqn3IY6OfXgsfIYxl32er/DT+ShnNqYA=; b=UJg3snUoQOAzkGhkyTto+qrPZfjVvEqH5Xx7ndcVRFkxgZB2CzCIUL3u1F9JyGttKR hjc8GG/DWDa2xaUaD8OjVYRTTfLg3JU7tFGYYs0dLoDmqtBKRNTV3QPVcR5bOETtvCOD DajFNUqOEMpeyPfWhmbATRkYepfyDYD9nDMS94sLhK/WW10bxJAX/tjLjV6PkmA38HKA VKFjW89vVagy4kyHaPGVmoMZ8/lrj21GYU2n8DgSuhcFeUoDee5iYY3LYMFjugg9psKI LjHMNqfoCE6/HBs22kIAZmiURq5YkYItjU3oyQBA42LtJxEW6v+CG958dfk0U3JoPFkk L+xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hh8uOy4Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w18-20020a0cdf92000000b0068196578606si7760209qvl.499.2024.01.23.02.25.48 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Jan 2024 02:25:48 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hh8uOy4Q; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rSDxS-0000Qg-Fx; Tue, 23 Jan 2024 05:24:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rSDxP-0000Q0-SZ for qemu-devel@nongnu.org; Tue, 23 Jan 2024 05:24:39 -0500 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rSDxO-0004dl-9y for qemu-devel@nongnu.org; Tue, 23 Jan 2024 05:24:39 -0500 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6dd6c9cb6a8so301902b3a.1 for ; Tue, 23 Jan 2024 02:24:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706005477; x=1706610277; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E554SzyD9ekZLsqgb3tmLUdyIwMdiLrTVwZboQHPuUo=; b=Hh8uOy4QemhqM5K1zNY/TD39SOFkI/8kHXaUtvk2Qmz8vDe0sl1JCSxd2SXxNOX7kC iXJDz60jf5jzhSpGbeAHl+rPOZulhGZ6EUwVjs8jafpu0qNbsY+lSwVN+A1Yy7NRlc0r 2F3CiIFwZLBG4hzecQNPf7nVPY2QGaEL86+fswGQ/SjVMc93KGI2WX731ixC3EjL54Wd qcT+jZh74ciwbgXoC3kHghx/8vhbo89jj5PbYu74t91E1q4iI6xL8p9T15QqB8g4CpbV JKKILUwUKD9xiq8uPpHzPQjLUFSyt/1u8ZyqHo3z3WMGpZCDC3/uvDYzJ36NbGsRDhLa 4suw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706005477; x=1706610277; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E554SzyD9ekZLsqgb3tmLUdyIwMdiLrTVwZboQHPuUo=; b=nMwdMHmsLxznHJeEfaEAHghwUhRenfoPTcA/QXXK5jXItHCWlqcqp0QNAxhTdnKJBt 7SYeGiSrbbrOOa2SyBi6yd19beEwnEXRYoLztdbvCtzJOIyd6L7IYmE1b1EGCFw1HuHK MSxMBFgv7EGrGHQ+S+LqNVPUMr3x9VvIwbCYUEto+vjvi3TRXOJlQSFrftKy+kdFSaX9 StbY2W4Ui3AhaujeoQoKTerDSlaoygizcVki2A8NUPX720XWK49gaU3cv8dDXCr3MFpX sQuR3JYYn0CLMjFvnoABGHBuXXIQhNggbbbO9eU0kM+kWBI4XYDi/7Psj6xzt0H8RMj0 vlrQ== X-Gm-Message-State: AOJu0Ywim1YINCfD5JAryhOTSJ52KbobF1wYigrt3PabTpU234SS3qCE mXbrRi+mRJxCel1nNEkUVz96S81yz3h0BKM6GHRzzbBUfZhYmjdwP1E1dmpojD+yFBr9Zr3DvKx ilms= X-Received: by 2002:aa7:9301:0:b0:6d9:8ccb:be1b with SMTP id cz1-20020aa79301000000b006d98ccbbe1bmr3684018pfb.29.1706005475273; Tue, 23 Jan 2024 02:24:35 -0800 (PST) Received: from stoup.lan (2001-44b8-2176-c800-b8a0-0408-58be-7d2e.static.ipv6.internode.on.net. [2001:44b8:2176:c800:b8a0:408:58be:7d2e]) by smtp.gmail.com with ESMTPSA id d8-20020a62f808000000b006d9ce7d3258sm11072408pfh.204.2024.01.23.02.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 02:24:34 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , =?utf-8?q?Philippe_?= =?utf-8?q?Mathieu-Daud=C3=A9?= Subject: [PULL v2 6/8] linux-user/elfload: test return value of getrlimit Date: Tue, 23 Jan 2024 20:24:10 +1000 Message-Id: <20240123102412.4569-7-richard.henderson@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240123102412.4569-1-richard.henderson@linaro.org> References: <20240123102412.4569-1-richard.henderson@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Thomas Weißschuh Should getrlimit() fail the value of dumpsize.rlimit_cur may not be initialized. Avoid reading garbage data by checking the return value of getrlimit. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Thomas Weißschuh Message-Id: <20240120-qemu-user-dumpable-v3-1-6aa410c933f1@t-8ch.de> Signed-off-by: Richard Henderson --- linux-user/elfload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index cf9e74468b..c596871938 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -4667,9 +4667,9 @@ static int elf_core_dump(int signr, const CPUArchState *env) init_note_info(&info); errno = 0; - getrlimit(RLIMIT_CORE, &dumpsize); - if (dumpsize.rlim_cur == 0) + if (getrlimit(RLIMIT_CORE, &dumpsize) == 0 && dumpsize.rlim_cur == 0) { return 0; + } corefile = core_dump_filename(ts);