From patchwork Fri Feb 23 19:09:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 775167 Delivered-To: patch@linaro.org Received: by 2002:adf:a356:0:b0:33b:4db1:f5b3 with SMTP id d22csp523434wrb; Fri, 23 Feb 2024 11:59:31 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXIS4IDIE3BZRibKmHkLgRiMLHeTsgNFi5AxnwZWpE/8WSwy/N3h+Hg1eH9eZhGrkPsuEB6FJPFQpVzPV/pRUoF X-Google-Smtp-Source: AGHT+IEZyCLfCUKCPnMR70aw0NuaRrku6+egXQFELUHT5D6CvNkOU3LDZ02KBqTlJoC/o5saZeki X-Received: by 2002:a05:622a:18a7:b0:42e:6de8:ac79 with SMTP id v39-20020a05622a18a700b0042e6de8ac79mr196468qtc.10.1708718371613; Fri, 23 Feb 2024 11:59:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1708718371; cv=none; d=google.com; s=arc-20160816; b=Eq/Qi/wJZmHVbRo8ZGluRUwmyHrNqswifxwE40oMRiX6AOjOvoMfPswidncG5Nh10G 394ZwSZySO2UMMWTMjJg1UKgeT1RMev9Es5goEHDJ0d6TkAu1bELz+qqH5hCFycLyoDC lAFouUdnHoTtX/a2JUoZmGD/gyabKZVMiKl8Fvl+TD7H4C7jqsOSSRv5Mh7khihBjcVi IewN/DGhKkImL6JrNUnBJpNukrPx12vLaOE4eQaLlXPN76yizkyOUP+kziIuD1w9bNJN wLbBRMMKPGGc5IxJ2e/QWeGYAaMMjkFybsvJO4GgP/U9fwH3W8I4Kfkaypir4f6WbisD 6E7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=G8VyCfIgJLlXJBKJ0ikRitCPzdkPenpH9LMlDgEm6ms=; fh=alZCUczDNtN4yFLy44SM1yTUliPrh8AgZa0GP8izqo4=; b=H1UCysM15BhQhU72smp4XB/EuAe5t06dAX5nABJ0HFkvWt1jkK0RmudiO4uFre8O98 7vAnaTVJg5TGARh1AFt2qWBgv0rMJYyXMoiF2sVKHOBg/Kq9HIWcWvbzepPbrVwR1j4k 49d4z6umVDL19MeVzC+5Xk2Ilyt+R/oqc300qlzdopgSPlkADwOvTo4O93xEr7wcOT6E Qqdc+mKaH4K4t1M8PKen/Sgs8mYiiQqvyMcL4hz8df58yt4pcICce7DbqsyML+ijgTXP 1qXXu9k+2pr5q6i1xm69Pd7ptMCNqcTWYz2tez041i+1b5BP0RH2ZwjuLX0pZWetPpf5 XaQA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="cJ0/kKMn"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c6-20020a05622a024600b0042e69f78980si1177848qtx.772.2024.02.23.11.59.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Feb 2024 11:59:31 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="cJ0/kKMn"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdbgm-0000bo-KI; Fri, 23 Feb 2024 14:58:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdawD-0005mO-Fv for qemu-devel@nongnu.org; Fri, 23 Feb 2024 14:10:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdaw8-0005D0-Vv for qemu-devel@nongnu.org; Fri, 23 Feb 2024 14:10:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708715418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8VyCfIgJLlXJBKJ0ikRitCPzdkPenpH9LMlDgEm6ms=; b=cJ0/kKMnU1QFp0sM8c1Ggsqz16Xx3yH3URlNVxVK6zFT6lGEKsYAVBL8S+SVrrnbVxSlMO 1YFIfwwHtCBY+wLXP9xMDGkoPWekjaPhSLg1MWPQPZ+Q5AJPDowJ7POy9+dpuwZjRitIOk wIItg0+FiQosxeWG97WyluOUMv2r84M= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-212-pnSl-HSIPdKkfWo3etTC8w-1; Fri, 23 Feb 2024 14:10:15 -0500 X-MC-Unique: pnSl-HSIPdKkfWo3etTC8w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DFBF538562C9; Fri, 23 Feb 2024 19:10:14 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.192.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id D18708CED; Fri, 23 Feb 2024 19:10:13 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , =?utf-8?q?Philippe_Mathieu-Dau?= =?utf-8?q?d=C3=A9?= Subject: [PULL 07/11] meson: Enable -Wvla Date: Fri, 23 Feb 2024 20:09:59 +0100 Message-ID: <20240223191003.6268-8-thuth@redhat.com> In-Reply-To: <20240223191003.6268-1-thuth@redhat.com> References: <20240223191003.6268-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.066, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Peter Maydell QEMU has historically used variable length arrays only very rarely. Variable length arrays are a potential security issue where an on-stack dynamic allocation isn't correctly size-checked, especially when the size comes from the guest. (An example problem of this kind from the past is CVE-2021-3527). Forbidding them entirely is a defensive measure against further bugs of this kind. Enable -Wvla to prevent any new uses from sneaking into the codebase. Signed-off-by: Peter Maydell Message-ID: <20240125173211.1786196-3-peter.maydell@linaro.org> [thuth: rebased to current master branch] Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-ID: <20240221162636.173136-4-thuth@redhat.com> Signed-off-by: Thomas Huth --- meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/meson.build b/meson.build index c1dc83e4c0..0ef1654e86 100644 --- a/meson.build +++ b/meson.build @@ -592,6 +592,7 @@ warn_flags = [ '-Wstrict-prototypes', '-Wtype-limits', '-Wundef', + '-Wvla', '-Wwrite-strings', # Then disable some undesirable warnings