From patchwork Mon Mar 25 13:32:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 782335 Delivered-To: patch@linaro.org Received: by 2002:a5d:4e01:0:b0:33e:7753:30bd with SMTP id p1csp1176286wrt; Mon, 25 Mar 2024 06:34:30 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCUECs+NJkYKGahlo7KDjq/Fg1LGWVs3RzfAQPuMMvfOfnn2U6R6hAtCbDFfoXjAwJAy6dyVRqtDl7Pguby9XMsm X-Google-Smtp-Source: AGHT+IFC1KMvSvpxRASgPumEUqpm2zwCxZMqEGFnb9DAuY4UZPO/V179M1Ya+8Mp5IcW9kElesha X-Received: by 2002:a9d:6318:0:b0:6e6:99d9:adc3 with SMTP id q24-20020a9d6318000000b006e699d9adc3mr9042427otk.24.1711373670672; Mon, 25 Mar 2024 06:34:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1711373670; cv=none; d=google.com; s=arc-20160816; b=xo+WpNtElYMMCr2ZCh9hKogeUp9Q9pzAVxMKy9lD9uXxnPhj8IPToR6+HDzPecPLyk l2hbHPomllo9oq1LlaMoc+r0hGnYWL7x7Fv/XjzKNWVp7hFFs7Ke6SuhhctceMdVJJXE at75FV/fqzo4Ufv06pdobxzWWOSCqQFkgEaus0f8E+WcEVRO/AJ3l//jArbGBXdql6Wo 1ePre6unPNjetERgetUhkZYUaxfOxhKdamlJvQbeVdbnSYNBfngvL8X1QjoenKQEuvw4 N63ZbTUOO2gwt++ce2NqPo+50FBDLX/ISZTvwiOIGCLJzs3GutaiWHnax8YfMo94GoIq p5+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dmBZnvObELGs1VJCtsjfXQQHR8FYa+eCE52ifx9aDFo=; fh=Z6ebApcLFJbaZHsWuXWH2AHWI2xWYXqDDJv2NwjBOYY=; b=wR02ErgNil55vH8phok0D1o8hRNSu67v+B6DuC2Pv4smK7qmsT2vSLM7imJ05JHjpy eLpU31WJDEV0pJ7z4ZtYKbKHPgZk2/n9UWec9PIZjnFCQpF6OnBnraarXMKaharn4ioc yJ1HCkRI5RSrOgvD76Zf4VlsUFCJZlIo+fQhOGtSep+gp+6yqi1ujfjKk96WilL8nlBh Mum27CXw1HYV7hf9XAOWk6fCjx0xH4W9Vsa+sJQSSjUgnUXhP5rp7gH1Bmg+QQm/srdC pRruRW4OwWpV4MbHzwA8L5CNAM6QMZPt7qcBFOxZ1Orzjs94EgMWbDgllYC4ou6tndzo 5PbA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TkcmmaY3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id n8-20020a05620a222800b0078a0e622dbdsi5290004qkh.599.2024.03.25.06.34.30 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 25 Mar 2024 06:34:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TkcmmaY3; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rokSU-0003Vc-EU; Mon, 25 Mar 2024 09:33:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rokST-0003S8-01 for qemu-devel@nongnu.org; Mon, 25 Mar 2024 09:33:49 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rokSR-0007SW-Ax for qemu-devel@nongnu.org; Mon, 25 Mar 2024 09:33:48 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-4148c5de23fso609415e9.1 for ; Mon, 25 Mar 2024 06:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711373625; x=1711978425; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dmBZnvObELGs1VJCtsjfXQQHR8FYa+eCE52ifx9aDFo=; b=TkcmmaY3P9KBxuj/1kMLyKMhfW3tUhND1f2WJ6LAotpmiQgbtWLd2ciexxuvhqhULl FqPneXiDxHaTwSwpvq9M26qypu7UeX8SWaOcSQy6VwvAlHD+cqin2OplF/tFgh9tiCsW 6raBV+s2rXeV/dP6BwR5C+aFrqg3Xfi5e/IFgKlMBIjvdX+lCgHkOUxrNG+24dcTDXFc d28to8WWhBfKcmKEBXnVxBz+kqTMNws6kms7t2dCBp2XTKc7iKCe2d91PPri8dJ2XCC7 NCcSvwmnu9+W6SuLw3PlC8stErZxf92Bd6OaT0ALippppRYDM3GHj46DbSrklmVzrzyw jmjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711373625; x=1711978425; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dmBZnvObELGs1VJCtsjfXQQHR8FYa+eCE52ifx9aDFo=; b=Er39HNtlC8eDc3af5B/e2FBGU3I9pxc/pWZqWxFdhcpDXPCcgl6KMRH7GsRE73SuVP QcyZiIL7Jst0CzAtQucczFQrLRcUP5oXNgonLzUjsLN11YTiRd8js1VegWGxP3T57HwB yYe/RwgbuCWZ31439sxi3fKOmoOHHMKfCS1dndGZd+/qlnqdsdYMrNOEvBULdoy9MqZS cEbxPd2Mtrq/dvVHDCZ+w+7vKILgPAZDUBz4at96F9OfKth2L+zNJAwWg0OOaP/h/PpV IVdGakK1jgPpfyoTy86x4loKgOO4VAjzHMldNzbEy6VPZ0liT7qpA0llsGwA9GbZR7P9 h2+g== X-Gm-Message-State: AOJu0Yy5wQSJZkD960vxcsY5m80cRW9VrMHhzXnII+2YvWi1ivfjlmKU qevu55lFjn3o0e5fVYuqNDR5mrDnzj8m4guVGCoX6LA7Cxe3RZcOKKOjTpS3nCXcjIPqMauMCrO KJ3M= X-Received: by 2002:a05:600c:5121:b0:414:7bd1:4060 with SMTP id o33-20020a05600c512100b004147bd14060mr5425135wms.2.1711373625053; Mon, 25 Mar 2024 06:33:45 -0700 (PDT) Received: from m1x-phil.lan ([176.187.208.214]) by smtp.gmail.com with ESMTPSA id ay41-20020a05600c1e2900b004148c10db66sm809802wmb.26.2024.03.25.06.33.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 25 Mar 2024 06:33:44 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?utf-8?q?In=C3=A8s_Varhol?= , Arnaud Minier , Damien Hedde , qemu-arm@nongnu.org, Peter Maydell , Alistair Francis , Luc Michel , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= Subject: [PATCH-for-9.0? v2 7/8] hw/misc/stm32l4x5_rcc: Propagate period when enabling a clock Date: Mon, 25 Mar 2024 14:32:57 +0100 Message-ID: <20240325133259.57235-8-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240325133259.57235-1-philmd@linaro.org> References: <20240325133259.57235-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Arnaud Minier The "clock_set_mul_div" function doesn't propagate the clock period to the children if it is changed (e.g. by enabling/disabling a clock multiplexer). This was overlooked during the implementation due to late changes. This commit propagates the change if the multiplier or divider changes. Fixes: ec7d83acbd ("hw/misc/stm32l4x5_rcc: Add an internal clock multiplexer object") Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Message-ID: <20240317103918.44375-2-arnaud.minier@telecom-paris.fr> [PMD: Pass argument to clock_set_mul_div()] Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/stm32l4x5_rcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/stm32l4x5_rcc.c b/hw/misc/stm32l4x5_rcc.c index 8852b434db..166c727e52 100644 --- a/hw/misc/stm32l4x5_rcc.c +++ b/hw/misc/stm32l4x5_rcc.c @@ -61,7 +61,7 @@ static void clock_mux_update(RccClockMuxState *mux, bool bypass_source) freq_multiplier = mux->divider; } - clock_set_mul_div(mux->out, freq_multiplier, mux->multiplier, NULL); + clock_set_mul_div(mux->out, freq_multiplier, mux->multiplier, &clk_changed); clock_set(mux->out, clock_get(current_source), &clk_changed); if (clk_changed) { clock_propagate(mux->out);