From patchwork Wed Apr 24 08:03:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Markus Armbruster X-Patchwork-Id: 791506 Delivered-To: patch@linaro.org Received: by 2002:a5d:4884:0:b0:346:15ad:a2a with SMTP id g4csp700448wrq; Wed, 24 Apr 2024 01:05:32 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXkX/l6/w+EMjFsJU9aOqD18SXVWMleGRtJpryN8ZIs6aBDdfOHfrrmBAn/eV/DzMrryEcOuHtvkrrahM+sTF7g X-Google-Smtp-Source: AGHT+IGaFZJPNrdey+4kz8UxCFZYJdC3oIcyNm9LyznZbYDBPkdcoDBbjzJOpmQmjusDoQ42bxCL X-Received: by 2002:a05:620a:5a75:b0:78e:bd5d:547d with SMTP id wx53-20020a05620a5a7500b0078ebd5d547dmr1794486qkn.43.1713945932471; Wed, 24 Apr 2024 01:05:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1713945932; cv=none; d=google.com; s=arc-20160816; b=AtNtZkfasWI8sHoKW0oeA1BAc8EQ3vH2qITx3uVTG9uounMn9xqHbgXrmPT45Bz951 4LXrUFPK6O6/dCD9qw4iKIzZxBNvv28uATYZDwV+z/qUEAlW7MDFsnlrCzYp93ri2U2f vEYL8st+njgQAqHA9ZPeWomSkP1SLdunkCW7e+NlD3ZRMdxq9/kMD2zF4bwSyIFI2jj5 dl/VCqmw13iCBZO32QASBuy1/jpfJfUEiSzhAal+MoVX1jeZXeZcwqdAGX+bN3BNT1f/ obiX5MfPQclcNhXWhCmbLt+8q/Z9Z1dKSbkP6n9AkkE+SETYnrlnBUG1g8HAnv+lVmWr ORdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=kXLAsN/MjWVrTQesWQIb8lj4bZIyULexZMx0u8KANK0=; fh=axzdzWpyk9nBHGlMTHXAA8pRXwojiLsYurKeeecLVqM=; b=XC0pYIlhsUg7sAXcRiHjoT3hwmOAF7+DKlLScqn6FriKf/5BPlY11/AfK+ohrhQ/ru sBKY9CkjUQxz2NEjrFczgZYgiBhWT1H9bQjLlXbYQ9S4LNh0ni82fPIyGbLP6v77/BkB 5xqfpjQ2HnDgGONteaWccxnRczCdf8cBNG2nLxdCpcsJryeFYQr6N0e5HjI4plHqypE7 1Gzj0I44UD2LyqD5bTrfinik4gu1ECPAWV8dPzSVdM8+HHh4E+SfJ0D07wYpd97KuQ/t gEgKhNe2CRmIhory0o0qcuhH20ooy7guel4CSQzIHMkCSePg6tBEZWS1yocR0xblDG06 VZ+Q==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UCYKdlLg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id xz7-20020a05620a5e0700b0078e8cf3fc80si10871546qkn.175.2024.04.24.01.05.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2024 01:05:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UCYKdlLg; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzXc1-0006w9-3N; Wed, 24 Apr 2024 04:04:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzXbX-0005su-3n for qemu-devel@nongnu.org; Wed, 24 Apr 2024 04:03:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzXbS-0003nj-78 for qemu-devel@nongnu.org; Wed, 24 Apr 2024 04:03:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713945821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kXLAsN/MjWVrTQesWQIb8lj4bZIyULexZMx0u8KANK0=; b=UCYKdlLgOz/Km603AA55deTGb5DNJf27q3UqRfH6lreiC1F7QUJw4IeFIFSREu7u9y6rSK EKeKOHBLZrRk3p8wLASQOrDvyClCOTT/op3kYeQuFkUs70StVJ6aL2Hs9SM9JJtnQeZDUV mdkQOlx0J4QTJlkQazUDewEOdwbdKxY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-185-0g-fZ5TLMgib_g2FIqKLoA-1; Wed, 24 Apr 2024 04:03:39 -0400 X-MC-Unique: 0g-fZ5TLMgib_g2FIqKLoA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 48033834FB1; Wed, 24 Apr 2024 08:03:39 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.247]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 25B49400EAF; Wed, 24 Apr 2024 08:03:39 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 4E07B21E65DE; Wed, 24 Apr 2024 10:03:37 +0200 (CEST) From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Juan Quintela , Zhao Liu Subject: [PULL 08/10] qapi: Correct error message for 'vcpu_dirty_limit' parameter Date: Wed, 24 Apr 2024 10:03:35 +0200 Message-ID: <20240424080337.2782594-9-armbru@redhat.com> In-Reply-To: <20240424080337.2782594-1-armbru@redhat.com> References: <20240424080337.2782594-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.67, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Philippe Mathieu-Daudé QERR_INVALID_PARAMETER_VALUE is defined as: #define QERR_INVALID_PARAMETER_VALUE \ "Parameter '%s' expects %s" The current error is formatted as: "Parameter 'vcpu_dirty_limit' expects is invalid, it must greater then 1 MB/s" Replace by: "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: Markus Armbruster Message-ID: <20240312141343.3168265-9-armbru@redhat.com> Reviewed-by: Zhao Liu [New error message corrected, commit message updated accordingly] --- migration/options.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/migration/options.c b/migration/options.c index bfd7753b69..d7a773aea8 100644 --- a/migration/options.c +++ b/migration/options.c @@ -1286,9 +1286,8 @@ bool migrate_params_check(MigrationParameters *params, Error **errp) if (params->has_vcpu_dirty_limit && (params->vcpu_dirty_limit < 1)) { - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, - "vcpu_dirty_limit", - "is invalid, it must greater then 1 MB/s"); + error_setg(errp, + "Parameter 'vcpu_dirty_limit' must be greater than 1 MB/s"); return false; }