From patchwork Tue May 28 14:07:49 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 799474 Delivered-To: patch@linaro.org Received: by 2002:adf:e110:0:b0:35b:5a80:51b4 with SMTP id t16csp256865wrz; Tue, 28 May 2024 07:12:09 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVGcftEqSXW9AQxuxc9f5LYxQ/jVMWsBDm3m8IXRzKLGMR8+fyh4rIPEVY1CoxwrhzpwyiynIHitcjJS2G1jEvc X-Google-Smtp-Source: AGHT+IHMI2wJrEOZKIBzhIGxpzULhIqqAsPVrLHbUUEEpv6a5anZgTfJMKyDjgn5Jj7cCuvmTrPj X-Received: by 2002:a05:6808:3d0:b0:3c9:a968:d0b2 with SMTP id 5614622812f47-3d1a61138a5mr11304651b6e.32.1716905529486; Tue, 28 May 2024 07:12:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1716905529; cv=none; d=google.com; s=arc-20160816; b=IN/JQbmTfUQrXjJcVdXRt+B2LYj+VaTj0CbjMIOhVI5JUTEhlx32KtMXZQoxPHt0xh iVaJkslAe3rJUGVnAJ7etGyC/c4IG/cEn+FJtSoqJ30yej0R6bNcVBzWdH4f0KvwY1Yz rvurC80LQ0gq6JZzfp+LtJBI9AI2OVHFFXjAQgowAyrjbcGdDLMgKgfIYC/qKq1mvuxa gxNyAUfvPUTQdzAoC3eknKYS6eO2yltGDrgjSbSvG/bMvki/mUMdJwL0RRhCUSMuPY9Z hJEMLmD4XUxHewPoLhtafjkcWyEEdcz001YXnKrbz4z9l6gsTgDpQhWensW0o+Z3rfTe e2cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=8FAqlHwdIGYJ/Fo9nu8qvPKK59RKx8O/bWyYtfutAkU=; fh=PnYt+qEB9tAfMKoqBm2xjKOFpYyFFGPudh5cVIoieJM=; b=Nw+phG/7DfjWhGpG77DIhXdXov/dqrIWSlYwyRz7NQ7LRm7a+lS1mOIkxGlvaKals9 Bt/G9awtC1sVjn6Z724BTCLZOczjVN/t/DbHLfuYfJh7eBOZ+ntSYDzXWM7MhAp2S61M vHIpTjg0cIRdBoVilGphHOxu7NfQWpN0afmlLwrq9lbFKPSOb8KzIv1No9V6W8ab3sKK MjyGMMvP83bs1DCBN2VqNpC8k4znocr/bdiIINy7O+vv+lwF/qgN2dZckM4rzqSoRmdH 7bok/95xKLS2Ew/vx10VGybC2/yZSGBwi5b4Pq6IE77NmgA6LvCDviK7TopANAbhfF8+ e8UA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Va5hDNDD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-48b8ca321a6si617418137.221.2024.05.28.07.12.09 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 May 2024 07:12:09 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Va5hDNDD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBxVO-0001xw-Ag; Tue, 28 May 2024 10:08:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBxV1-0001iI-Ou for qemu-devel@nongnu.org; Tue, 28 May 2024 10:08:23 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBxUx-00077c-Ve for qemu-devel@nongnu.org; Tue, 28 May 2024 10:08:21 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-35bf77ba8fbso244504f8f.2 for ; Tue, 28 May 2024 07:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716905298; x=1717510098; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=8FAqlHwdIGYJ/Fo9nu8qvPKK59RKx8O/bWyYtfutAkU=; b=Va5hDNDDzlHR5eo3oq6WaQYjZuuaAB8NHylagGN3JVZy0xmV4pr+JP/nw2DkE/NTC8 wcqthsJqotGtf+PDaKrLy8nvEB75ftTKqZqhgAvNdxJ1h1z7BfZp8NDbvFmpKkR0lKn6 rBLnzxxJIs2LoJoPaEN0EcTD9Jo31JlUWm6KiDKW6W5/uxer+8X0Q27n+n9aJancimF2 WeJV+tutMaSSHr5uwC0sU/JzwOlOraQVl5k/rw24k3/r5caQbUhkjx1525uS7WoQU4R+ FXMVyhFKoeR+OiAucvMV4jlWb+lp7ITB7arccKVbq9TWegvHZlND8F6vwUhf1BJvdvJf Ty/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716905298; x=1717510098; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8FAqlHwdIGYJ/Fo9nu8qvPKK59RKx8O/bWyYtfutAkU=; b=qiY4jHHVOuxAY9pk2xryPVyRkAwZPrpImF2pEJ4/09VKSPMM2Bu+zbMp2ROYwITQD4 r9ClstEUFa2ulP2IoSWldYvKbppq/3s9egIw+/Fn6fZfEhYQFJJXoN1tdCu2DCU+3arB me0vph+zJlVwTL2UxyB6TA2AJiIdIYYhZgV1+Ew8tj7p2SUkuwuMj9uaICXWbBZslPrV QQy54zYYVkXd9vzCHlmVcBrAMjHHF4IdpKNkibGGhE61RBklQatnPCcYbA47VhwoKXLg 7AmVACbFPKlyAf7PuizkIX1Ca7iMWoccw+m1sUCpT69+H5Z8mKrdj98l7X23WVI8crmc X6kg== X-Gm-Message-State: AOJu0YzeBIqSETynqGVw1KrJ5hgJ9bbku3BzXDo4pKbNneQw25yLQdvC utR4kEvjsHbjJN0L9/5B4DdlRgRC00SWqC4VT+5plkKhc8RUX4bKCEchLtwLQQVWHZv5fMtzosZ a X-Received: by 2002:a05:6000:8f:b0:354:f359:735a with SMTP id ffacd0b85a97d-3552705681fmr10441059f8f.5.1716905298668; Tue, 28 May 2024 07:08:18 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3564afc3577sm11361473f8f.102.2024.05.28.07.08.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 07:08:18 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 38/42] target/arm: Use gvec for neon padd Date: Tue, 28 May 2024 15:07:49 +0100 Message-Id: <20240528140753.3620597-39-peter.maydell@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240528140753.3620597-1-peter.maydell@linaro.org> References: <20240528140753.3620597-1-peter.maydell@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20240524232121.284515-33-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/helper.h | 2 -- target/arm/tcg/neon_helper.c | 5 ----- target/arm/tcg/translate-neon.c | 3 +-- 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/target/arm/helper.h b/target/arm/helper.h index d3579a101f4..51ed49aa50c 100644 --- a/target/arm/helper.h +++ b/target/arm/helper.h @@ -354,8 +354,6 @@ DEF_HELPER_3(neon_qrshl_s64, i64, env, i64, i64) DEF_HELPER_2(neon_add_u8, i32, i32, i32) DEF_HELPER_2(neon_add_u16, i32, i32, i32) -DEF_HELPER_2(neon_padd_u8, i32, i32, i32) -DEF_HELPER_2(neon_padd_u16, i32, i32, i32) DEF_HELPER_2(neon_sub_u8, i32, i32, i32) DEF_HELPER_2(neon_sub_u16, i32, i32, i32) DEF_HELPER_2(neon_mul_u8, i32, i32, i32) diff --git a/target/arm/tcg/neon_helper.c b/target/arm/tcg/neon_helper.c index bc6c4a54e9d..a0b51c88096 100644 --- a/target/arm/tcg/neon_helper.c +++ b/target/arm/tcg/neon_helper.c @@ -745,11 +745,6 @@ uint32_t HELPER(neon_add_u16)(uint32_t a, uint32_t b) return (a + b) ^ mask; } -#define NEON_FN(dest, src1, src2) dest = src1 + src2 -NEON_POP(padd_u8, neon_u8, 4) -NEON_POP(padd_u16, neon_u16, 2) -#undef NEON_FN - #define NEON_FN(dest, src1, src2) dest = src1 - src2 NEON_VOP(sub_u8, neon_u8, 4) NEON_VOP(sub_u16, neon_u16, 2) diff --git a/target/arm/tcg/translate-neon.c b/target/arm/tcg/translate-neon.c index 2326a05a0aa..6c5a7a98e1b 100644 --- a/target/arm/tcg/translate-neon.c +++ b/target/arm/tcg/translate-neon.c @@ -830,6 +830,7 @@ DO_3SAME_NO_SZ_3(VABD_S, gen_gvec_sabd) DO_3SAME_NO_SZ_3(VABA_S, gen_gvec_saba) DO_3SAME_NO_SZ_3(VABD_U, gen_gvec_uabd) DO_3SAME_NO_SZ_3(VABA_U, gen_gvec_uaba) +DO_3SAME_NO_SZ_3(VPADD, gen_gvec_addp) #define DO_3SAME_CMP(INSN, COND) \ static void gen_##INSN##_3s(unsigned vece, uint32_t rd_ofs, \ @@ -1070,13 +1071,11 @@ static bool do_3same_pair(DisasContext *s, arg_3same *a, NeonGenTwoOpFn *fn) #define gen_helper_neon_pmax_u32 tcg_gen_umax_i32 #define gen_helper_neon_pmin_s32 tcg_gen_smin_i32 #define gen_helper_neon_pmin_u32 tcg_gen_umin_i32 -#define gen_helper_neon_padd_u32 tcg_gen_add_i32 DO_3SAME_PAIR(VPMAX_S, pmax_s) DO_3SAME_PAIR(VPMIN_S, pmin_s) DO_3SAME_PAIR(VPMAX_U, pmax_u) DO_3SAME_PAIR(VPMIN_U, pmin_u) -DO_3SAME_PAIR(VPADD, padd_u) #define DO_3SAME_VQDMULH(INSN, FUNC) \ WRAP_ENV_FN(gen_##INSN##_tramp16, gen_helper_neon_##FUNC##_s16); \