From patchwork Mon Jun 17 07:10:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 804845 Delivered-To: patch@linaro.org Received: by 2002:adf:fb90:0:b0:360:93e7:1765 with SMTP id a16csp434216wrr; Mon, 17 Jun 2024 00:12:53 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXmCuv0cM9KB7PB6PrTx4O7rWG6Scyt9TD78U85TC8whB9SgFCb9AkqAXnQDt+oiBUGNqaNTT6BdE5MVuscDidZ X-Google-Smtp-Source: AGHT+IH2qMHuUGAnObm1hZav2bRWuqiUwEJqsAuzkU++4AkAgf+kOyMMYpJv5fpmNpj2HaBOFz8v X-Received: by 2002:a81:5b56:0:b0:627:7630:800a with SMTP id 00721157ae682-6322441d56bmr78960367b3.49.1718608372906; Mon, 17 Jun 2024 00:12:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718608372; cv=none; d=google.com; s=arc-20160816; b=HszmCVDDzpD/8guSoLkPjeWrrRNID/VdeNY8rdtwJNVzEHtGEI1jxRmJ9gbXtTOr8p 8V9xcmM88wMHNYd2EzwIXyi1sEvrpuJpbAl4Og5HXdt8ckE58SZGijejy7ndb80c107U Dccrr3LnQf/RJRXvc6JqiexHMg2Oj2gRDk7yJXRjZz44CJKamh3UsBh4fL5yi9HlW7Zm SZAp554HEBxrI4HfBQOd1/a+6jlDEvvCvEvYrK8MPi7xkdTY/PP17Yug2Cc06ItPqubB qALyW9b+905Nql3wP0oUffsZazh3m3h99VkP4W9qpoiz/XYJYKPaYZeuhTTrCo+V/orl K1bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GkUlGRbmAJqlvNHXX7Tr9hS4i1gAChf6oNxF2co2Y1s=; fh=LxU1EPCBVYorV++vrCt2dyzDsbIeuRBouOVrSj5U16k=; b=NEuz51ams6hmK1XZC8qLLD7lVLCjSbbtk9vV4KPP3FeyDKR/bhWnqzrbwRmiyIAjvi UbxOEI4/uyZEusgqGywNnQ20xKlff1yA4XBezwHBLXlMWpseDukNFPvQyRPS6WOhU0u5 na9llSaLgooSkBU9EdP/V0wHUWr9xQBSpnllD9+ZHtgP8Io4J/R5P3WmP/TvhG5nl7vt 2J+1gb/nmmWrTlERD++VI7gNFeJvm7h3sdGiOloWdYeZRhngsXw5CSN69s/bYc+b4cAe OBoNiRH9MN3lc1g5L6J7WfBf5q+bZ20H3HxZpP4uBLQMOXbMbNrB8C6sXGMSRwvwPR3a LGcw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hZlASQxD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6b2a5a1541asi92130396d6.96.2024.06.17.00.12.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jun 2024 00:12:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=hZlASQxD; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJ6Wg-0003pd-FJ; Mon, 17 Jun 2024 03:11:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJ6We-0003pN-9c for qemu-devel@nongnu.org; Mon, 17 Jun 2024 03:11:36 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJ6Wc-00027C-FZ for qemu-devel@nongnu.org; Mon, 17 Jun 2024 03:11:36 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-a6266ffdba8so396776766b.1 for ; Mon, 17 Jun 2024 00:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718608292; x=1719213092; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GkUlGRbmAJqlvNHXX7Tr9hS4i1gAChf6oNxF2co2Y1s=; b=hZlASQxDYGGYwRemsqhkhqbJfwo/9DrOcWIrUxnr0GdrO3K7WbFj896gRSGovRE5ur GYIp/6xKZf1gZvDXATreNYjvy+TAcCLPtAx0K1lLakuMtAm6IE+n2R1XquAmzbhCoND2 OsDnKHvYnQbB5HRaHHO8srQLOoHY31Ny0zZ1gyOUN7ZR7TXvWwoj4LaaD4JlhHJcSQTK cfb2qEfNNPaMEULNsEEek84iYxGRZ+B59UdySVrB4NxABx37gwYyp09FxyQyJDkW92r+ KcgPpjf/m5K75ZB9htKt0iMMgeP1WoengG4uE3QtD2dv03m/1EdVBhxIv0egwRBFaHdJ Z7ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718608292; x=1719213092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GkUlGRbmAJqlvNHXX7Tr9hS4i1gAChf6oNxF2co2Y1s=; b=egN4HCMbhJsNX04DSRXbp5fcK+31B8NmpEABrjpI7DmUQLklt5Tg8tzO9EohdQ7za5 QQKJEI6PU8lJqXXIUteEgclYBA5MKFYLhAI9Nk1tv6KKeVxyGky6pcSF064hKCfMhAKj mWe6XMlHu5sTosUTrIP4JguJhwPE+shQz2rKGSLSizNKKj183xctW0dSfAI8kLDU/0IN nuP2eTE8WdQqP6LJ999v3B214L6cPV39GoeIrt4o0eAL1MhurJFax+4CMC/mKIzqeu7r Te3iNvZH5YETRaeUWIZf2W2wG34Nh9PC5/ag8f9OXQAcv+u0aOvZSsbmFg6WVIxNKuGH jiBA== X-Gm-Message-State: AOJu0Ywu+FWmWw3PUsZfX98tYfZOLhUf6IC+YPFWsmr+5UhSf2yh59Sk 8jervewOjWnXQIfrjv2sMaVzbFyGgaLZ4URYdS4BMvqjCyxl0cPpieWurXhxsBgaQsB/FJ0DYGc gAX4= X-Received: by 2002:a17:906:b7da:b0:a6f:4b5b:4ba7 with SMTP id a640c23a62f3a-a6f60de2641mr591537366b.67.1718608292381; Mon, 17 Jun 2024 00:11:32 -0700 (PDT) Received: from m1x-phil.lan ([176.176.169.90]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f599a7035sm467833866b.27.2024.06.17.00.11.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 17 Jun 2024 00:11:31 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Igor Mammedov , "Michael S. Tsirkin" , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Thomas Huth , Zhao Liu Subject: [PATCH v6 02/23] hw/i386/pc: Remove deprecated pc-i440fx-2.0 machine Date: Mon, 17 Jun 2024 09:10:57 +0200 Message-ID: <20240617071118.60464-3-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240617071118.60464-1-philmd@linaro.org> References: <20240617071118.60464-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=philmd@linaro.org; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org The pc-i440fx-2.0 machine was deprecated for the 8.2 release (see commit c7437f0ddb "docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated"), time to remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Zhao Liu Reviewed-by: Igor Mammedov --- docs/about/deprecated.rst | 2 +- docs/about/removed-features.rst | 2 +- include/hw/i386/pc.h | 3 --- hw/i386/pc.c | 15 ------------- hw/i386/pc_piix.c | 37 --------------------------------- 5 files changed, 2 insertions(+), 57 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 66a5f43626..e12eab1f72 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -212,7 +212,7 @@ deprecated; use the new name ``dtb-randomness`` instead. The new name better reflects the way this property affects all random data within the device tree blob, not just the ``kaslr-seed`` node. -``pc-i440fx-2.0`` up to ``pc-i440fx-2.3`` (since 8.2) and ``pc-i440fx-2.4`` up to ``pc-i440fx-2.12`` (since 9.1) +``pc-i440fx-2.1`` up to ``pc-i440fx-2.3`` (since 8.2) and ``pc-i440fx-2.4`` up to ``pc-i440fx-2.12`` (since 9.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' These old machine types are quite neglected nowadays and thus might have diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index eaae82b8a5..f84bfaf2b6 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -948,7 +948,7 @@ mips ``fulong2e`` machine alias (removed in 6.0) This machine has been renamed ``fuloong2e``. -``pc-0.10`` up to ``pc-i440fx-1.7`` (removed in 4.0 up to 8.2) +``pc-0.10`` up to ``pc-i440fx-2.0`` (removed in 4.0 up to 9.0) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' These machine types were very old and likely could not be used for live diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index ca7904ac2c..3e606949fb 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -318,9 +318,6 @@ extern const size_t pc_compat_2_2_len; extern GlobalProperty pc_compat_2_1[]; extern const size_t pc_compat_2_1_len; -extern GlobalProperty pc_compat_2_0[]; -extern const size_t pc_compat_2_0_len; - #define DEFINE_PC_MACHINE(suffix, namestr, initfn, optsfn) \ static void pc_machine_##suffix##_class_init(ObjectClass *oc, void *data) \ { \ diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 0469af00a7..d0f2628d46 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -320,21 +320,6 @@ GlobalProperty pc_compat_2_1[] = { }; const size_t pc_compat_2_1_len = G_N_ELEMENTS(pc_compat_2_1); -GlobalProperty pc_compat_2_0[] = { - PC_CPU_MODEL_IDS("2.0.0") - { "virtio-scsi-pci", "any_layout", "off" }, - { "PIIX4_PM", "memory-hotplug-support", "off" }, - { "apic", "version", "0x11" }, - { "nec-usb-xhci", "superspeed-ports-first", "off" }, - { "nec-usb-xhci", "force-pcie-endcap", "on" }, - { "pci-serial", "prog_if", "0" }, - { "pci-serial-2x", "prog_if", "0" }, - { "pci-serial-4x", "prog_if", "0" }, - { "virtio-net-pci", "guest_announce", "off" }, - { "ICH9-LPC", "memory-hotplug-support", "off" }, -}; -const size_t pc_compat_2_0_len = G_N_ELEMENTS(pc_compat_2_0); - GSIState *pc_gsi_create(qemu_irq **irqs, bool pci_enabled) { GSIState *s; diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 02878060d0..a750a0e6ab 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -441,11 +441,6 @@ static void pc_compat_2_1_fn(MachineState *machine) x86_cpu_change_kvm_default("svm", NULL); } -static void pc_compat_2_0_fn(MachineState *machine) -{ - pc_compat_2_1_fn(machine); -} - #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { @@ -887,38 +882,6 @@ static void pc_i440fx_2_1_machine_options(MachineClass *m) DEFINE_I440FX_MACHINE(v2_1, "pc-i440fx-2.1", pc_compat_2_1_fn, pc_i440fx_2_1_machine_options); -static void pc_i440fx_2_0_machine_options(MachineClass *m) -{ - PCMachineClass *pcmc = PC_MACHINE_CLASS(m); - - pc_i440fx_2_1_machine_options(m); - m->hw_version = "2.0.0"; - compat_props_add(m->compat_props, pc_compat_2_0, pc_compat_2_0_len); - pcmc->smbios_legacy_mode = true; - pcmc->has_reserved_memory = false; - /* This value depends on the actual DSDT and SSDT compiled into - * the source QEMU; unfortunately it depends on the binary and - * not on the machine type, so we cannot make pc-i440fx-1.7 work on - * both QEMU 1.7 and QEMU 2.0. - * - * Large variations cause migration to fail for more than one - * consecutive value of the "-smp" maxcpus option. - * - * For small variations of the kind caused by different iasl versions, - * the 4k rounding usually leaves slack. However, there could be still - * one or two values that break. For QEMU 1.7 and QEMU 2.0 the - * slack is only ~10 bytes before one "-smp maxcpus" value breaks! - * - * 6652 is valid for QEMU 2.0, the right value for pc-i440fx-1.7 on - * QEMU 1.7 it is 6414. For RHEL/CentOS 7.0 it is 6418. - */ - pcmc->legacy_acpi_table_size = 6652; - pcmc->acpi_data_size = 0x10000; -} - -DEFINE_I440FX_MACHINE(v2_0, "pc-i440fx-2.0", pc_compat_2_0_fn, - pc_i440fx_2_0_machine_options); - #ifdef CONFIG_ISAPC static void isapc_machine_options(MachineClass *m) {