From patchwork Fri Sep 6 06:54:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Tokarev X-Patchwork-Id: 825922 Delivered-To: patch@linaro.org Received: by 2002:adf:a345:0:b0:367:895a:4699 with SMTP id d5csp663286wrb; Fri, 6 Sep 2024 00:00:55 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXRR/MXTgY5tyyh5eE8FPkC6q8kH2/Z9LXlNPgmdXzYl0cDp+VZnfo4vyMU6VQknvBsq1MdRQ==@linaro.org X-Google-Smtp-Source: AGHT+IFNtldccp0XJUyIrNuE91kS0yop12nlrSnAbAKek3HRJOpzLjhFSg9PHwMFcDi/IR1hwPaP X-Received: by 2002:ac8:57c2:0:b0:451:d6b3:3930 with SMTP id d75a77b69052e-4580c76b76dmr17828171cf.47.1725606055061; Fri, 06 Sep 2024 00:00:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1725606055; cv=none; d=google.com; s=arc-20240605; b=XXz9izjwbV3zjreE8lwm15BG3FRQP//yz1IQuJ2DP5f049X5RCwZOvkyP7b820CtXI D8BMT6Hzd0qYE5gAzgalBq85C6cAcdgDNnSQhIoN1Xrz1As+DmcCEOrW5L1yhuAJDmwR UXQCAI5VdufiLMe3Tcl+/mG7UX9A4RRrBxuovwp5d9mZNGNa2BJH83kKA5hW/fnNTuqi RNSWlj4yq3D+3dQd36tsCENzwSkOGoyODw8JQFnF2GEJIfEu3VTY28hnAoqGPfCfHPeF XF10Y+kK4IrESMH4wJMStjfreU3Ujywg1saG7+pDtOFw2jyDcbk+f8lVXXAx9a6GRxQ/ VyOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from; bh=3gr0ExRu6TCjRam4F1dFQGavUThGaTNVHvmvDPNq9rM=; fh=73++FxpCBH5KDXgG1Nqvg9f5zGI68qj4hqVYWy1KEho=; b=g4sNfcw8TfNlePELJRD0Z4R6Yo2nIHnfy15UmQOcdzpcaMN3zU8kjdyrosRaWQhyqH 9DKu9PXLQ4C28ldayeIiBZkun45e2vcAhQI2qs1OyjLCGHuHKoftbd8lnJj5+3R3iPu/ 39uTpDikdg8A178EKbCeoVWB/6iyCDT12nTUogWeYt9RPK2YINyOD2onEiM9kVEkaZtC UMY1Vr1PfOPSYsS42guPBagF4o4l603Gia31y29utKJh42hzDf/lpKp+Vwu7xfOo3bl+ V9L789wlbknDoF0m3RS3e2IxNVwHg70nnfQN4FQPhJnYWCEyUzV4zY8eQgNklZ7pbxK8 Z+jw==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45814680028si1242691cf.232.2024.09.06.00.00.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Sep 2024 00:00:55 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org" Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smSwH-0006PZ-1u; Fri, 06 Sep 2024 02:59:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smSvN-0008CL-HX; Fri, 06 Sep 2024 02:58:30 -0400 Received: from isrv.corpit.ru ([86.62.121.231]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smSvL-0003iJ-Sr; Fri, 06 Sep 2024 02:58:29 -0400 Received: from tsrv.corpit.ru (tsrv.tls.msk.ru [192.168.177.2]) by isrv.corpit.ru (Postfix) with ESMTP id 8A8848C261; Fri, 6 Sep 2024 09:53:14 +0300 (MSK) Received: from tls.msk.ru (mjt.wg.tls.msk.ru [192.168.177.130]) by tsrv.corpit.ru (Postfix) with SMTP id 53C55133419; Fri, 6 Sep 2024 09:54:32 +0300 (MSK) Received: (nullmailer pid 43670 invoked by uid 1000); Fri, 06 Sep 2024 06:54:31 -0000 From: Michael Tokarev To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org, Richard Henderson , Paolo Bonzini , Michael Tokarev Subject: [Stable-8.2.7 44/53] target/i386: Do not apply REX to MMX operands Date: Fri, 6 Sep 2024 09:54:14 +0300 Message-Id: <20240906065429.42415-44-mjt@tls.msk.ru> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Received-SPF: pass client-ip=86.62.121.231; envelope-from=mjt@tls.msk.ru; helo=isrv.corpit.ru X-Spam_score_int: -68 X-Spam_score: -6.9 X-Spam_bar: ------ X-Spam_report: (-6.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Richard Henderson Cc: qemu-stable@nongnu.org Fixes: b3e22b2318a ("target/i386: add core of new i386 decoder") Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2495 Signed-off-by: Richard Henderson Link: https://lore.kernel.org/r/20240812025844.58956-2-richard.henderson@linaro.org Signed-off-by: Paolo Bonzini (cherry picked from commit 416f2b16c02c618c0f233372ebfe343f9ee667d4) Signed-off-by: Michael Tokarev diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc index ffd3a42688..852579eef5 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -1237,7 +1237,10 @@ static bool decode_op(DisasContext *s, CPUX86State *env, X86DecodedInsn *decode, op->unit = X86_OP_SSE; } get_reg: - op->n = ((get_modrm(s, env) >> 3) & 7) | REX_R(s); + op->n = ((get_modrm(s, env) >> 3) & 7); + if (op->unit != X86_OP_MMX) { + op->n |= REX_R(s); + } break; case X86_TYPE_E: /* ALU modrm operand */