Message ID | 20240910221606.1817478-23-pierrick.bouvier@linaro.org |
---|---|
State | Superseded |
Headers | show
Delivered-To: patch@linaro.org Received: by 2002:adf:ab1c:0:b0:367:895a:4699 with SMTP id q28csp529107wrc; Tue, 10 Sep 2024 15:18:24 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVDIQuVAsNMXoyE+fTnzCyCRTz1Nb+2o5LS7ZoW5AJQgmakBgXPlBuXZIv7wPUCKabeDicPEg==@linaro.org X-Google-Smtp-Source: AGHT+IGA585yBsF8WK6y19RGnQzXKpEyWECq24yBViuQ5nGLEG8+H9W5Zd7mTN1wCjhIspQedIcz X-Received: by 2002:a05:620a:c51:b0:7a3:78ac:827c with SMTP id af79cd13be357-7a99731ddc6mr2354504885a.10.1726006704072; Tue, 10 Sep 2024 15:18:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1726006704; cv=none; d=google.com; s=arc-20240605; b=ExC8ouUoBin8CtFLBq4s6cggbte9eEXizfJxaXywqL/aFPf2njkE5sSsCiSCgigEy6 XERC1Q3MOwVPG8dyxm9GFzVQ/ujpjhhuztZvXKhhPmoOZxRUlXWFQndFHrfMVhhZaChn JQH1P2Fl85SExFuhfHO7gLY2g8BjXivtyhw7/gASFjwghxGvH06AXiMNh/f3bUtu8VTp ZMSWpfrskJNFectCrpBrV/pXK7BA/bm61VaOb8rECXGtsuXwdykCuviatGp6Xi7mYfPW ak/CnVoYMtzRPoXDTNhLhyOw04LFr8AiSHWw+S5W+NFZoNyXvKGPODqD044eTyy6Yp/i 7ZZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7oh25CxvFbaGetIeF8ZGKIaTcgg654mKr0Hk3ECIvo8=; fh=ynTlK/oH/ur5RqvPhczOwhj4YatH1hTHyPq9uMdf314=; b=llkun27QZhYJg3B4HOXMFy79t77mGT4sMeS72KN2G6VhK63zBfDtCQqe7/IrcZkyPe NUPPF5WDcplFRN3nyoCh47uQ5wzml6cg8Awbs7QPisDiC1oXLmq7YEv9RjQyX0+d2K3A cd+8x7AuFpFwY94arv6ieJCFlMohWvHkhPDVzJjMrzQ8hrDruRAZIoJsNcc89nNuy5sK zrlvp5bm8wboenioS32Z/LbXBAiENsZndb8ciw5UCY/YqvJ7pa0i+1XsLMLXFMRaNtEn pP6jdwKFG64iDQn7oRVthfaZ7h+5vg4LK3RpsDORAqWY1mGftVsf7bVMHg4gDexJB6iQ ErzA==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kpeaXr/C"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: <qemu-devel-bounces+patch=linaro.org@nongnu.org> Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id af79cd13be357-7a9a79c579dsi907996085a.94.2024.09.10.15.18.23 for <patch@linaro.org> (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Sep 2024 15:18:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="kpeaXr/C"; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <qemu-devel-bounces@nongnu.org>) id 1so9BB-0006qT-Me; Tue, 10 Sep 2024 18:17:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>) id 1so9AY-0001oB-6Y for qemu-devel@nongnu.org; Tue, 10 Sep 2024 18:17:06 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <pierrick.bouvier@linaro.org>) id 1so9AW-0006oz-0T for qemu-devel@nongnu.org; Tue, 10 Sep 2024 18:17:05 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-718e6299191so2047159b3a.2 for <qemu-devel@nongnu.org>; Tue, 10 Sep 2024 15:17:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1726006623; x=1726611423; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7oh25CxvFbaGetIeF8ZGKIaTcgg654mKr0Hk3ECIvo8=; b=kpeaXr/CgzZd3itBdi47Eya813spYfi6yO1mGD6mg0gVJ6kBxUFJW2k3Ip1Dk3dKNj JQZmUkdWkBb9K9eGWphQzMCiRPb33y+SdeiSXbdoNUPVbcs+AQG8kPNHxxoS6Y9j26B4 DZGPiJiQRK8oPcPqr2Wz2zDMHXnL5RCrJeY/jQWglz87E/iwXnnhOg8N++iYSF6xEFzb KvP9/3iIjpkbM2up1liSC8vU4pqopYp9r/jYlCA8EFSj64Ez6ZV9/qWqFntn6srqSAkG okvEWiKkiGnCO+SBhg+Hk0D84JUDGBorX5qhbOZjERQyEPqNSkBBWD4b5zUCL9qDulBx eUKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726006623; x=1726611423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7oh25CxvFbaGetIeF8ZGKIaTcgg654mKr0Hk3ECIvo8=; b=BmAaxyO0SwX1dvfKpG3VreYBqvJKjrFVzASsg+toef+sWZv4iKi3PG9d6WxY4qbACK hUgBQisWc1XdP5ak15Os9JYswzR7L+XlPY7vTTZKbM6YFY4udE45j/IOSrhECKDJucPJ hmH5QRNiAhzvAR+BWgHnoX2SWeaBmE/OWoabEWEHFFi3K30cIpk0TzeS6TUbjVGxwgVR CEQsAefILNsN5QqtHbPsknQUMILO2v1rzZS/hZrCVt/yDxlASgsGun+mnpJ4dN42EAZb SOg0J21PFyGuDl2Z/5xSkzRvjGrd0Oo4jweI1pPbT/OiNwIPWgi42O3dP2kBN9z8CSNt bsrA== X-Gm-Message-State: AOJu0YwTcqdvUvDX5Av2knMfZlBXpC+RzXl42t8wEvGVMEZrN8KeejDn lnIVrruag1+9PES+rJX8kggIexJZM3cbM52NJjXhAUnsR4iu3Bp7vAqvvbwfAzX6APiWHgziOs7 D1CXZl/lF X-Received: by 2002:a05:6a00:66e1:b0:714:3acb:9d4b with SMTP id d2e1a72fcca58-718d5ee03c7mr14772194b3a.18.1726006622546; Tue, 10 Sep 2024 15:17:02 -0700 (PDT) Received: from linaro.vn.shawcable.net ([2604:3d08:9384:1d00::9633]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71909003d0esm1884055b3a.93.2024.09.10.15.17.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2024 15:17:02 -0700 (PDT) From: Pierrick Bouvier <pierrick.bouvier@linaro.org> To: qemu-devel@nongnu.org Cc: Zhao Liu <zhao1.liu@intel.com>, "Richard W.M. Jones" <rjones@redhat.com>, Joel Stanley <joel@jms.id.au>, Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-arm@nongnu.org, Corey Minyard <minyard@acm.org>, Eric Farman <farman@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Keith Busch <kbusch@kernel.org>, WANG Xuerui <git@xen0n.name>, Hyman Huang <yong.huang@smartx.com>, Stefan Berger <stefanb@linux.vnet.ibm.com>, Michael Rolnik <mrolnik@gmail.com>, Alistair Francis <alistair.francis@wdc.com>, =?utf-8?q?Marc-Andr=C3=A9_Lure?= =?utf-8?q?au?= <marcandre.lureau@redhat.com>, Markus Armbruster <armbru@redhat.com>, Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>, Palmer Dabbelt <palmer@dabbelt.com>, qemu-riscv@nongnu.org, Ani Sinha <anisinha@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Jesper Devantier <foss@defmacro.it>, Laurent Vivier <laurent@vivier.eu>, Peter Maydell <peter.maydell@linaro.org>, Igor Mammedov <imammedo@redhat.com>, kvm@vger.kernel.org, =?utf-8?q?Alex_Be?= =?utf-8?q?nn=C3=A9e?= <alex.bennee@linaro.org>, Richard Henderson <richard.henderson@linaro.org>, Fam Zheng <fam@euphon.net>, qemu-s390x@nongnu.org, Hanna Reitz <hreitz@redhat.com>, Nicholas Piggin <npiggin@gmail.com>, Eduardo Habkost <eduardo@habkost.net>, Laurent Vivier <lvivier@redhat.com>, Rob Herring <robh@kernel.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, qemu-block@nongnu.org, "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>, qemu-ppc@nongnu.org, Daniel Henrique Barboza <danielhb413@gmail.com>, Christian Borntraeger <borntraeger@linux.ibm.com>, Harsh Prateek Bora <harshpb@linux.ibm.com>, =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= <philmd@linaro.org>, Nina Schoetterl-Glausch <nsg@linux.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Fabiano Rosas <farosas@suse.de>, Helge Deller <deller@gmx.de>, Dmitry Fleytman <dmitry.fleytman@gmail.com>, Daniel Henrique Barboza <dbarboza@ventanamicro.com>, Akihiko Odaki <akihiko.odaki@daynix.com>, Marcelo Tosatti <mtosatti@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Aurelien Jarno <aurelien@aurel32.net>, Liu Zhiwei <zhiwei_liu@linux.alibaba.com>, Yanan Wang <wangyanan55@huawei.com>, Peter Xu <peterx@redhat.com>, Bin Meng <bmeng.cn@gmail.com>, Weiwei Li <liwei1518@gmail.com>, Klaus Jensen <its@irrelevant.dk>, Jean-Christophe Dubois <jcd@tribudubois.net>, Jason Wang <jasowang@redhat.com>, Pierrick Bouvier <pierrick.bouvier@linaro.org> Subject: [PATCH 22/39] target/i386/kvm: replace assert(false) with g_assert_not_reached() Date: Tue, 10 Sep 2024 15:15:49 -0700 Message-Id: <20240910221606.1817478-23-pierrick.bouvier@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> References: <20240910221606.1817478-1-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=pierrick.bouvier@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org |
Series |
Use g_assert_not_reached instead of (g_)assert(0, false)
|
expand
|
On 9/10/24 15:15, Pierrick Bouvier wrote: > Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> > --- > target/i386/kvm/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c > index 2fa88ef1e37..308b0e1cb37 100644 > --- a/target/i386/kvm/kvm.c > +++ b/target/i386/kvm/kvm.c > @@ -5770,7 +5770,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) > } > } > > - assert(false); > + g_assert_not_reached(); > } > > static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) > @@ -5789,7 +5789,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) > } > } > > - assert(false); > + g_assert_not_reached(); > } > > static bool has_sgx_provisioning; Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/i386/kvm/kvm.c b/target/i386/kvm/kvm.c index 2fa88ef1e37..308b0e1cb37 100644 --- a/target/i386/kvm/kvm.c +++ b/target/i386/kvm/kvm.c @@ -5770,7 +5770,7 @@ static int kvm_handle_rdmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) @@ -5789,7 +5789,7 @@ static int kvm_handle_wrmsr(X86CPU *cpu, struct kvm_run *run) } } - assert(false); + g_assert_not_reached(); } static bool has_sgx_provisioning;
Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org> --- target/i386/kvm/kvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)