From patchwork Wed Sep 25 11:09:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830448 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp685047wrz; Wed, 25 Sep 2024 04:14:04 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCW2x7roAboyEGzZsRbIYAnC8HbHP03s7Q/hoJ2eWwqBg2hFkVq29IuWTIwGqWfJdSYrIyjklg==@linaro.org X-Google-Smtp-Source: AGHT+IEGiWzszCbvi0F0n/jwpsiRCva8NwbEHuSXcX7cW3442IwpLfdO/m0fVoBA9nPu8uT3WwXO X-Received: by 2002:a05:622a:4e95:b0:458:3215:960c with SMTP id d75a77b69052e-45b5def17efmr39452411cf.29.1727262843807; Wed, 25 Sep 2024 04:14:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262843; cv=none; d=google.com; s=arc-20240605; b=aQUq5YQowcIZgAL5/gyHxhPi2SPIlNOIUVP1a+xVAG3WZta+dRuBPqdpvwYMy5bQ6j MWgicGMdPFI3aAANpD1Y2MsEoSRbW9fTI8LK9Jqx0Yy/64QhLHMJjZZ6ktXIK60Ayhnw wk/e3IA6P0COSmqKr7Me2j0EDB1dVQOLt4EIgUc8mrMwtc/ur/YuAIGPD54BpZ6VMfVR gVchmH046ZR49OPgail6itolDd/IwEdGYyvcxirrlDFUQB7QQF5Z1UvJautOxEgveXvM MIfvb4103z1CF3l6mDIioSho2voBZoTjFbTRqppOYxQ1/PEqIUb/6fZmONE7G8k7Lpqw zGtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wq1B9h69gckEeGkVnGQTX9HCgcmht5vBk2iFpBgg+Fg=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=fez4EtV6bJ9gBnSAzwmUM2pMDgdRcFCiUJuhzX5KkRmba53JNI7rM7V2P5I4EhBT5a qfAl2bCEHktjP4c0/Kji+xmNv76JFVfP2Q2aJQ5gN7HnERrT7OY059SlDTZ1vkRehlcD PwPKyQuU4mjxGQEKX1a/RvF+AxPvxxHRwzP5Wfas4CUVNj1k4jrfOhoKSL6FDIFj/43Q n/J6E5F27jON+IqrVG94imM3x8UzQTzgI5dXiIljvajtImRdmK2r7q7VV/88hX+XRmEa NiLUzxcOtZMczQ9sAQ4iNY9+DJ/CHXfPbFgN8UQ2vOCfzzB1BMbvYWpLxysZji5atBsb 00vg==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gm+LhP+B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-45b526ec3fdsi35466211cf.468.2024.09.25.04.14.03 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:14:03 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Gm+LhP+B; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPvi-0001JK-KM; Wed, 25 Sep 2024 07:11:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPve-0000tB-U9 for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPvd-0003a5-FA for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wq1B9h69gckEeGkVnGQTX9HCgcmht5vBk2iFpBgg+Fg=; b=Gm+LhP+BrzMXZGJic9b0TdJUvSGGaRRQVroUsVLXmoN9oSw0+8rIM5C9YFcsrVYTEEQQOo 3KOG4W7WPRh9fXu2LUB2Kduxk+CXUemoAr1I0YkbsFO7Ww89sA4x5Lk/+G5OuI98ZES8FC Vnxme3llHKZSwg67EYJE0BIekrKouq4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-681-jkNVEQgxOe6omEpeXrrEqQ-1; Wed, 25 Sep 2024 07:11:25 -0400 X-MC-Unique: jkNVEQgxOe6omEpeXrrEqQ-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8981C196E0A4; Wed, 25 Sep 2024 11:11:24 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0347F1956094; Wed, 25 Sep 2024 11:11:22 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 18/44] hw/nvme: replace assert(false) with g_assert_not_reached() Date: Wed, 25 Sep 2024 13:09:59 +0200 Message-ID: <20240925111029.24082-19-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Klaus Jensen Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-11-pierrick.bouvier@linaro.org> Signed-off-by: Thomas Huth --- hw/nvme/ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index 9e94a24054..2589e1968e 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -1816,7 +1816,7 @@ static uint16_t nvme_check_zone_state_for_write(NvmeZone *zone) trace_pci_nvme_err_zone_is_read_only(zslba); return NVME_ZONE_READ_ONLY; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -1870,7 +1870,7 @@ static uint16_t nvme_check_zone_state_for_read(NvmeZone *zone) trace_pci_nvme_err_zone_is_offline(zone->d.zslba); return NVME_ZONE_OFFLINE; default: - assert(false); + g_assert_not_reached(); } return NVME_INTERNAL_DEV_ERROR; @@ -4654,7 +4654,7 @@ static uint16_t nvme_io_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_CMD_IO_MGMT_SEND: return nvme_io_mgmt_send(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR; @@ -7205,7 +7205,7 @@ static uint16_t nvme_admin_cmd(NvmeCtrl *n, NvmeRequest *req) case NVME_ADM_CMD_DIRECTIVE_RECV: return nvme_directive_receive(n, req); default: - assert(false); + g_assert_not_reached(); } return NVME_INVALID_OPCODE | NVME_DNR;