From patchwork Wed Sep 25 11:10:23 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Huth X-Patchwork-Id: 830466 Delivered-To: patch@linaro.org Received: by 2002:a05:6000:1374:b0:367:895a:4699 with SMTP id q20csp686082wrz; Wed, 25 Sep 2024 04:16:23 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCXffhMgwjlrBSEL0cuQwRvteIS9g26KKoF7R6CFmSF9P55BX8Hp8jkFHIUt/CBYi5qEijhyzQ==@linaro.org X-Google-Smtp-Source: AGHT+IHubY3+aYXG2SppZhQfXDyCvA67K6WbJ3OhH7GCSF3yUb8Fr0AMrBzTiJeg7NPqXWXWS59q X-Received: by 2002:ad4:576a:0:b0:6c3:62e5:b416 with SMTP id 6a1803df08f44-6ca8d2ee2f2mr95912266d6.10.1727262982816; Wed, 25 Sep 2024 04:16:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1727262982; cv=none; d=google.com; s=arc-20240605; b=aRdxxpaNCgjZBhJKhipldIYCh0XBxlu9lttxBh1jljGckJXbBt9CzsXRNl2Yw/2ZK3 M4Jt7RTvEeto0qrzahO2dz8OYD1t2FQ/ULaadJbSbDUuvnnW+NBziL5/EpZIYN+89Y03 0DgAn5KQweBuNj0kCweJOHZ/PmQG31gLasCQFtKj35HJR/z7d88LAN9xTYWS3F4cfJoQ Er+T0H0OLC6wDydmFkyKos60vbYeQdI8cDE+nLM3TEoG7MOblu1Rm3CObwBFPHYQ1Vqj A+3u4gY2nT/oLfUjQjIKmpDrbLSDdPlV8qxgDxSItn/1lsJ5HsvNhmmXiN6EqoqI65Ix 1QVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=htGtxccsCyLJzJw3INxtPFKpLYjofSjahFL8NefGrrs=; fh=W6xzREthpkPEW8tziq0xxHpztmQWB2zzpMc8Zy+HmrY=; b=e6Z/twDfaeUaP38v8fwoWa+sZonxnvC0ejyxajmd8X+UveEYprdbK+ARrNG5Afz99Q wM3SAhq/4vjiifn8DyoA1Plv9gAZqjgwcB3Pjc9fJqakiT2RcdoENFmS9Afh8bSmPTV0 qvxLRqhfFsKse0By+rCkdeuAQoTIpzo7JQvIhwtpcMQgP6cIL3gl6GQ52V589kXZWDOK BvXzNyS5D15sG8LEm8hZQaehG8RPOsInCOtnjKANYK6LrLF12QbGXi5YnQWlnXhH9l9T 1y+igsCH/oYT0uZqU1O/l1rrWgjDUWFzQNwlit4vuuTgsQa6L5XNz6cflBJHZFlK9T20 Qqow==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G9Z+Ssig; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id 6a1803df08f44-6cb0f4e99b1si37324586d6.166.2024.09.25.04.16.22 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 25 Sep 2024 04:16:22 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G9Z+Ssig; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stPy0-0005EP-Oz; Wed, 25 Sep 2024 07:13:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwe-0006ah-6J for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stPwb-000402-Hb for qemu-devel@nongnu.org; Wed, 25 Sep 2024 07:12:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727262748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=htGtxccsCyLJzJw3INxtPFKpLYjofSjahFL8NefGrrs=; b=G9Z+SsigBXA1/MPivInHic2l/XM4qqj83PG/I7Tts66myKZUuuf//lS+vFNSIsz62r0oiz dkBlRZJsmawyeeE6kxXjTY0iW1A2qrjzhQnpLvOKxuzDd7JvGMosa0ZfuRORPRr6/ntU4d vQLJ9VMa443SVsXMNeMLoQb+P9MolI4= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-441-joDpd0owP4eGgj2l8crWzg-1; Wed, 25 Sep 2024 07:12:25 -0400 X-MC-Unique: joDpd0owP4eGgj2l8crWzg-1 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (unknown [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 816AD1955E75; Wed, 25 Sep 2024 11:12:24 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.39.193.206]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 9D2041956094; Wed, 25 Sep 2024 11:12:22 +0000 (UTC) From: Thomas Huth To: qemu-devel@nongnu.org Cc: Peter Maydell , Pierrick Bouvier Subject: [PULL 42/44] scripts/checkpatch.pl: emit error when using assert(false) Date: Wed, 25 Sep 2024 13:10:23 +0200 Message-ID: <20240925111029.24082-43-thuth@redhat.com> In-Reply-To: <20240925111029.24082-1-thuth@redhat.com> References: <20240925111029.24082-1-thuth@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.108, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org From: Pierrick Bouvier This patch is part of a series that moves towards a consistent use of g_assert_not_reached() rather than an ad hoc mix of different assertion mechanisms. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-ID: <20240919044641.386068-35-pierrick.bouvier@linaro.org> [thuth: Split long line to avoid checkpatch error] Signed-off-by: Thomas Huth --- scripts/checkpatch.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 65b6f46f90..1b21249c91 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3102,6 +3102,10 @@ sub process { if ($line =~ /\b(g_)?assert\(0\)/) { ERROR("use g_assert_not_reached() instead of assert(0)\n" . $herecurr); } + if ($line =~ /\b(g_)?assert\(false\)/) { + ERROR("use g_assert_not_reached() instead of assert(false)\n" . + $herecurr); + } if ($line =~ /\bstrerrorname_np\(/) { ERROR("use strerror() instead of strerrorname_np()\n" . $herecurr); }