From patchwork Thu Oct 10 21:49:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 834170 Delivered-To: patch@linaro.org Received: by 2002:adf:b352:0:b0:37d:45d0:187 with SMTP id k18csp519319wrd; Thu, 10 Oct 2024 14:51:15 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWA7OS0+QWYuWJ2erpOKwN60GLyhtll2k3KTS8YSq985OMjTWjfcsE08oJTVOhZxDxZ1Q0sFw==@linaro.org X-Google-Smtp-Source: AGHT+IExnhRtJ7peGDUTBJFj/fGE+ayhVarihT9an7pzUeblA69OGNrNG7QxOBfQha+QDb6wbTdN X-Received: by 2002:a05:622a:1a26:b0:458:25ec:68cf with SMTP id d75a77b69052e-4603f5b8c01mr74346221cf.13.1728597074746; Thu, 10 Oct 2024 14:51:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1728597074; cv=none; d=google.com; s=arc-20240605; b=IqFbk+HZj7rtRzQsvgL8uX5vsvCC6L4aPd4A7pk8UabfEYmfEr42E/Zm84yHRL9Ty7 WJiBTHYu0wHKtJCPdzjXmImfTWK8KfNdLVpoR18b1vFq255sTW36KVeB869VpIq5vC71 mku2hCc2yD2AujSr8q/OxQzUw13TIpw+RA4aza5JKU87lj/5GibR06vfF0o18w0xXMs8 ZszP4rvGLWYhFRDKCxdunoIhjzXDpd8sTmNxTrojjo/pSJtS5V22BSjUt6N/svUYfKfU 6zSJQnWEPKT5BWxRxGK+JzuIQwSkrpDJrtap6s1kG6fZI3S+DNnq2ulGvkKexvLBhtuL kWHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=eKyDYgcDRvOCa3U0P656gHylFIpPG3mMrqsMWsAm0J8=; fh=iNOTYz49uoInsUbytoQk3tKGszPqK5WeiwnCnA2pNSc=; b=XYBmxyVgEnfDE0mUgI63dx75LMEyrj4K6106MTyhtBIeQN5f66bIG92nBIhxq+OLHT 0kYyt4yJohU0vtVqrjhx/ADBwFKr/eNy3HW2SC5nlXrzIfG01QU/MkZA6H1hu6wMQC6q d7PEfzCEYF0Gw1xD439nQ1aXRR8b7I9pe88BWkcK2yeN2mTez0m0ZsJsR/YHm2eZQFQN 5nNVN/ON4Vr8/Bjb4x8PlY0vWuVB/kZ1BYn/zTB+dPoDq6XZ5Uf18cocuAcMOh/1OMAU RpJGUoBsgd8beDyIbD8VU52UqLJ/w8D2R9dA5VDSHX1cvJWYfI1iV2jpEwaYLRhbhzP8 g/AQ==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ACjVhsF0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id d75a77b69052e-460428816e0si21127291cf.239.2024.10.10.14.51.14 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 10 Oct 2024 14:51:14 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ACjVhsF0; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org; dara=neutral header.i=@linaro.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sz13L-0007Hn-Sz; Thu, 10 Oct 2024 17:50:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sz13H-0007Fz-3s for qemu-devel@nongnu.org; Thu, 10 Oct 2024 17:50:33 -0400 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sz13F-0004dF-32 for qemu-devel@nongnu.org; Thu, 10 Oct 2024 17:50:30 -0400 Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2e2e050b1c3so649239a91.0 for ; Thu, 10 Oct 2024 14:50:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728597027; x=1729201827; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eKyDYgcDRvOCa3U0P656gHylFIpPG3mMrqsMWsAm0J8=; b=ACjVhsF0sy7wWSdgEWipskpRikcs1M0fDpTyeGzNFlrhQEff1NesOyX4K0BSQnCg1/ Er2Ix97Qy9hYkOZILp9IQxIXn0xuovyyMyo/Vvm4HNchBM/INQyrfO8rvLWf1qkDVrYG Wvqgj3OjQne39fe7WZYMe6GjlpnScfkq94u9TfeWoYCt4UyBj8S2yDUKyhjS/JYtEHwm YzHcnRyAI5+8/II9tM7H+pIjf5+dFEk41OMm1W6TC8upH68KCiiBAV7Resa3WuI2zCXH XPDZi6ddsWsYI1KX6i5NoAAXQW54Kn4Vis3F3DhH0uQ7Ohub1VEW88HWYK1KqPyN0n17 +dLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728597027; x=1729201827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eKyDYgcDRvOCa3U0P656gHylFIpPG3mMrqsMWsAm0J8=; b=u5zuBgWfyQ5Oh4cDj9FhxlZ5VKYAU7JoItlju6ExInwY83te/+RLswSlXISCfx5Ryt TVRx1s3qPxa8LzVCTYDqHMUEqzbFZfHl+99rQe2LvPdaJ7xUYCOyDp8wcqCe6yjtyVYp Ckts6R3uatyXCPwe6k9mk4lr8Xep2kpLNnyhkqAM9Itz9IKDI4htMAwXu/CRQh730emr ejGmFrMxC6ZAj7iiwrlAmY6V5BlS2iYyx7VvR2mxjYG7NAl1Zbod1YLnOWF8zPVhadUK 7Xhf/D1mvDKyyQoip6P1QK9NIDXaRtMfnkQEdddhNgwsxfOKOy9kb/JlCsdDIkTOOuo5 8lCQ== X-Gm-Message-State: AOJu0Yxztq+KKxbyG35ipsa9cLxI2F8zzDy7ahx2CJPZ4F6jgpJrHUdR v0W2Yn90g5ZPNCTpMiQWKEAxH707gQzK8icLePPqcpqNC3xIe4ZjEnSb3Sk7c7q1KaJBPfW3JFc q X-Received: by 2002:a17:90a:c2c6:b0:2e2:a5fd:7e4c with SMTP id 98e67ed59e1d1-2e2f0aa8b36mr936591a91.8.1728597027291; Thu, 10 Oct 2024 14:50:27 -0700 (PDT) Received: from localhost.localdomain ([45.176.89.169]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e2a571a2ecsm4137373a91.33.2024.10.10.14.50.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 10 Oct 2024 14:50:26 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Huacai Chen , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?q?=C3=A9?= , Jiaxun Yang , =?utf-8?q?Herv=C3=A9_Poussineau?= , Aleksandar Rikalo , Aurelien Jarno Subject: [PATCH v2 01/16] target/mips: Declare mips_env_is_bigendian() in 'internal.h' Date: Thu, 10 Oct 2024 18:49:59 -0300 Message-ID: <20241010215015.44326-2-philmd@linaro.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241010215015.44326-1-philmd@linaro.org> References: <20241010215015.44326-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2607:f8b0:4864:20::1031; envelope-from=philmd@linaro.org; helo=mail-pj1-x1031.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org In order to re-use cpu_is_bigendian(), declare it on "internal.h" after renaming it as mips_env_is_bigendian(). Reviewed-by: Jiaxun Yang Tested-by: Jiaxun Yang Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20241004162118.84570-6-philmd@linaro.org> Reviewed-by: Richard Henderson --- target/mips/internal.h | 5 +++++ target/mips/tcg/ldst_helper.c | 15 +++++---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/target/mips/internal.h b/target/mips/internal.h index a9a22ea00ec..84c8e5e1ae7 100644 --- a/target/mips/internal.h +++ b/target/mips/internal.h @@ -225,6 +225,11 @@ static inline void mips_env_set_pc(CPUMIPSState *env, target_ulong value) } } +static inline bool mips_env_is_bigendian(CPUMIPSState *env) +{ + return extract32(env->CP0_Config0, CP0C0_BE, 1); +} + static inline void restore_pamask(CPUMIPSState *env) { if (env->hflags & MIPS_HFLAG_ELPA) { diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c index 97056d00a27..f92a923d7ad 100644 --- a/target/mips/tcg/ldst_helper.c +++ b/target/mips/tcg/ldst_helper.c @@ -53,11 +53,6 @@ HELPER_LD_ATOMIC(lld, ldq, 0x7, (target_ulong)) #endif /* !CONFIG_USER_ONLY */ -static inline bool cpu_is_bigendian(CPUMIPSState *env) -{ - return extract32(env->CP0_Config0, CP0C0_BE, 1); -} - static inline target_ulong get_lmask(CPUMIPSState *env, target_ulong value, unsigned bits) { @@ -65,7 +60,7 @@ static inline target_ulong get_lmask(CPUMIPSState *env, value &= mask; - if (!cpu_is_bigendian(env)) { + if (!mips_env_is_bigendian(env)) { value ^= mask; } @@ -76,7 +71,7 @@ void helper_swl(CPUMIPSState *env, target_ulong arg1, target_ulong arg2, int mem_idx) { target_ulong lmask = get_lmask(env, arg2, 32); - int dir = cpu_is_bigendian(env) ? 1 : -1; + int dir = mips_env_is_bigendian(env) ? 1 : -1; cpu_stb_mmuidx_ra(env, arg2, (uint8_t)(arg1 >> 24), mem_idx, GETPC()); @@ -100,7 +95,7 @@ void helper_swr(CPUMIPSState *env, target_ulong arg1, target_ulong arg2, int mem_idx) { target_ulong lmask = get_lmask(env, arg2, 32); - int dir = cpu_is_bigendian(env) ? 1 : -1; + int dir = mips_env_is_bigendian(env) ? 1 : -1; cpu_stb_mmuidx_ra(env, arg2, (uint8_t)arg1, mem_idx, GETPC()); @@ -130,7 +125,7 @@ void helper_sdl(CPUMIPSState *env, target_ulong arg1, target_ulong arg2, int mem_idx) { target_ulong lmask = get_lmask(env, arg2, 64); - int dir = cpu_is_bigendian(env) ? 1 : -1; + int dir = mips_env_is_bigendian(env) ? 1 : -1; cpu_stb_mmuidx_ra(env, arg2, (uint8_t)(arg1 >> 56), mem_idx, GETPC()); @@ -174,7 +169,7 @@ void helper_sdr(CPUMIPSState *env, target_ulong arg1, target_ulong arg2, int mem_idx) { target_ulong lmask = get_lmask(env, arg2, 64); - int dir = cpu_is_bigendian(env) ? 1 : -1; + int dir = mips_env_is_bigendian(env) ? 1 : -1; cpu_stb_mmuidx_ra(env, arg2, (uint8_t)arg1, mem_idx, GETPC());