From patchwork Mon Mar 10 12:22:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 25959 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f197.google.com (mail-pd0-f197.google.com [209.85.192.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9FCB4206A6 for ; Mon, 10 Mar 2014 12:24:16 +0000 (UTC) Received: by mail-pd0-f197.google.com with SMTP id fp1sf17058744pdb.8 for ; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=U30dAj3+6CfJ2Wt7D28/BcWjl6zTGPJ1QRixRQiEkpc=; b=gPZbq0fP5/1lvU8vJ/NHmJIDtkLh7qigsm5zo2aIEO/2qymw+e4E8TFBB4C0PA0fCY iVJ6maMXzhtD6IC5ksvNIQ9G5+T6hNzyjQEfUpRf5G7FTPS9vhZLRSOdWW1jODfNCat7 eiOi+eZCrqcUL3APjQxSHv3QyyXt7R19ksgP8vWoqcP1bg7HksTWx3U1qH3ibi0NdH/+ vp+sV3F/Q7BFq5BfY5044BZBxLA9gShMRrm1TAQJ5Y1weQy6yO6EIf14YY9/QcYxthlE O2L8ezGQ1nqgUjcHoQW7370z98GB3f3KejURfMgoakSiwNh9uj/CW92VzDjIUdvVouIG mWtg== X-Gm-Message-State: ALoCoQk5cdCmqJxPBts+Q75DJcxZe8TONqcYRrh5px0vUivOp58GDBb/1680B9UbGI9n+HEnr/BF X-Received: by 10.66.102.36 with SMTP id fl4mr13937465pab.20.1394454255661; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.93.33 with SMTP id c30ls2179038qge.9.gmail; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) X-Received: by 10.52.65.132 with SMTP id x4mr280663vds.36.1394454255490; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) Received: from mail-ve0-f169.google.com (mail-ve0-f169.google.com [209.85.128.169]) by mx.google.com with ESMTPS id cp10si4655188ved.96.2014.03.10.05.24.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Mar 2014 05:24:15 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.169; Received: by mail-ve0-f169.google.com with SMTP id pa12so7200200veb.28 for ; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) X-Received: by 10.221.37.1 with SMTP id tc1mr75683vcb.32.1394454255291; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp114651vck; Mon, 10 Mar 2014 05:24:15 -0700 (PDT) X-Received: by 10.224.71.209 with SMTP id i17mr39979530qaj.29.1394454253730; Mon, 10 Mar 2014 05:24:13 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s1si3549293qci.4.2014.03.10.05.24.13 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 10 Mar 2014 05:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:48395 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMzFd-00040e-9U for patch@linaro.org; Mon, 10 Mar 2014 08:24:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMzEc-0002os-R0 for qemu-devel@nongnu.org; Mon, 10 Mar 2014 08:23:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMzEV-00084L-01 for qemu-devel@nongnu.org; Mon, 10 Mar 2014 08:23:10 -0400 Received: from afflict.kos.to ([92.243.29.197]:50035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMzEU-00083g-PO for qemu-devel@nongnu.org; Mon, 10 Mar 2014 08:23:02 -0400 Received: from localhost.localdomain (afflict [92.243.29.197]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by afflict.kos.to (Postfix) with ESMTPSA id 9BC8B26561; Mon, 10 Mar 2014 13:23:01 +0100 (CET) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Mon, 10 Mar 2014 14:22:53 +0200 Message-Id: <4cf2348026002d64556f89d0971c663311be2525.1394453724.git.riku.voipio@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 92.243.29.197 Cc: peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH 1/8] linux-user/signal.c: Fix AArch64 big-endian FP register restore X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: riku.voipio@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.169 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Maydell Fix the loop restoring the FP registers from the signal frame to match the one used when setting up the signal frame, so that it handles TARGET_WORDS_BIGENDIAN being set. Signed-off-by: Peter Maydell Signed-off-by: Riku Voipio Reviewed-by: Richard Henderson --- linux-user/signal.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 04638e2..29734b2 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -1233,8 +1233,14 @@ static int target_restore_sigframe(CPUARMState *env, return 1; } - for (i = 0; i < 32 * 2; i++) { - __get_user(env->vfp.regs[i], &aux->fpsimd.vregs[i]); + for (i = 0; i < 32; i++) { +#ifdef TARGET_WORDS_BIGENDIAN + __get_user(env->vfp.regs[i * 2], &aux->fpsimd.vregs[i * 2 + 1]); + __get_user(env->vfp.regs[i * 2 + 1], &aux->fpsimd.vregs[i * 2]); +#else + __get_user(env->vfp.regs[i * 2], &aux->fpsimd.vregs[i * 2]); + __get_user(env->vfp.regs[i * 2 + 1], &aux->fpsimd.vregs[i * 2 + 1]); +#endif } __get_user(fpsr, &aux->fpsimd.fpsr); vfp_set_fpsr(env, fpsr);