diff mbox series

[06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG

Message ID cc6109fcc03d47a68d01ceac5ade71fe8467a3f7.1601203436.git.qemu_oss@crudebyte.com
State New
Headers show
Series 9pfs: add tests using local fs driver | expand

Commit Message

Christian Schoenebeck Sept. 27, 2020, 10:40 a.m. UTC
For now this new environment variable QTEST_DEBUG will cause the
assembled qemu command line to be printed before running each test.

Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
 tests/qtest/qos-test.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Paolo Bonzini Sept. 28, 2020, 8:31 a.m. UTC | #1
On 27/09/20 12:40, Christian Schoenebeck wrote:
> For now this new environment variable QTEST_DEBUG will cause the

> assembled qemu command line to be printed before running each test.

> 

> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

> ---

>  tests/qtest/qos-test.c | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c

> index 4b1a1922fc..571d1e140a 100644

> --- a/tests/qtest/qos-test.c

> +++ b/tests/qtest/qos-test.c

> @@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)

>  

>  static void restart_qemu_or_continue(char *path)

>  {

> +    if (getenv("QTEST_DEBUG") != NULL) {

> +        printf("run QEMU with: '%s'\n", path);

> +    }

>      /* compares the current command line with the

>       * one previously executed: if they are the same,

>       * don't restart QEMU, if they differ, stop previous

> 


You can just use g_test_message for this and do it unconditionally.

Paolo
Christian Schoenebeck Sept. 28, 2020, 12:11 p.m. UTC | #2
On Montag, 28. September 2020 10:31:21 CEST Paolo Bonzini wrote:
> On 27/09/20 12:40, Christian Schoenebeck wrote:

> > For now this new environment variable QTEST_DEBUG will cause the

> > assembled qemu command line to be printed before running each test.

> > 

> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

> > ---

> > 

> >  tests/qtest/qos-test.c | 3 +++

> >  1 file changed, 3 insertions(+)

> > 

> > diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c

> > index 4b1a1922fc..571d1e140a 100644

> > --- a/tests/qtest/qos-test.c

> > +++ b/tests/qtest/qos-test.c

> > @@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)

> > 

> >  static void restart_qemu_or_continue(char *path)

> >  {

> > 

> > +    if (getenv("QTEST_DEBUG") != NULL) {

> > +        printf("run QEMU with: '%s'\n", path);

> > +    }

> > 

> >      /* compares the current command line with the

> >      

> >       * one previously executed: if they are the same,

> >       * don't restart QEMU, if they differ, stop previous

> 

> You can just use g_test_message for this and do it unconditionally.


I actually had to read the glib sources to understand how g_test_message()'s 
output is turned on:  by appending '--verbose' to the CL.

Okay then.

Best regards,
Christian Schoenebeck
diff mbox series

Patch

diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
index 4b1a1922fc..571d1e140a 100644
--- a/tests/qtest/qos-test.c
+++ b/tests/qtest/qos-test.c
@@ -89,6 +89,9 @@  static void qos_set_machines_devices_available(void)
 
 static void restart_qemu_or_continue(char *path)
 {
+    if (getenv("QTEST_DEBUG") != NULL) {
+        printf("run QEMU with: '%s'\n", path);
+    }
     /* compares the current command line with the
      * one previously executed: if they are the same,
      * don't restart QEMU, if they differ, stop previous