From patchwork Thu Aug 23 06:50:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 144881 Delivered-To: patch@linaro.org Received: by 2002:a2e:164a:0:0:0:0:0 with SMTP id 10-v6csp756838ljw; Wed, 22 Aug 2018 23:50:48 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYEQFgeYKTY8bfsTevEtjwj/932q/72ajgvNKldE9SSTvTT1wGpTfCbi/gRXS3pE/xOTPE8 X-Received: by 2002:a62:768d:: with SMTP id r135-v6mr8945141pfc.224.1535007048167; Wed, 22 Aug 2018 23:50:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535007048; cv=none; d=google.com; s=arc-20160816; b=MKiRTjt7dnYTeCW8rWSWNA7SEnZuN3QjLkUhIykejCW7JrFLlMdzbq1zmvDIT8ZwfZ Honz2rHOKLAvF6WG62ncatg05xwo6kyJm8gK9MYaMygy92NHG0smE+A+RdXFcfISwTEG 0fM0T20winyZWsytpyIfXIcJM4w68T8oJWg+0FOiUvEkE0WML4nRiZjmtCFmUfgxJ8pG yUVGob9QqT2FCXu5BD4cPWHiYU6zYFMR76AmzRtzmS6Mb4rCjDc/mHkkKKNRy9PbjsJO gSIux11CJgFqXAA8fZcrXrlMWUnzBMVCrVMklyzcszQNn4I3n5Tmv99Dzu86kAhGOymT LTmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=0U20uNq0JjoONAI0eMORypsMDsKd5bIGTY/00N14L38=; b=vBrdfOqybs4anvWoFIUpJGRnBtuFQxnd8cIXjwSZDgRLDK8qlY4atFms+bMFZoDKLk ZAQHuHTf3WbLLmMdVLKyhUNv7sN/ctOLURMkDRB72+Qw6R41vZxl9qGKVvCJZb55RZtl dtaDkdk4U2amjB0hhnyepjKr3fr3YJIazXjBt9xXBAELYWXj2gssS/Z4IRg60gg2TcOp rXvunZOLbPTF9Z0QYN4dOwtA0qj0CFqQ8+QIbYqvsWCOE+i65ASVYw/mGNWqpy5MNCiG BQPpAoYeq7p6JeK+eWgNTg81If/ITebDOwnpnLGbupPrmQ4I4O37sRnUEWyV2N27nGMt LAvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TEsUOZwO; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cf13-v6si3685258plb.334.2018.08.22.23.50.47; Wed, 22 Aug 2018 23:50:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=TEsUOZwO; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbeHWKSz (ORCPT + 13 others); Thu, 23 Aug 2018 06:18:55 -0400 Received: from mail-pl0-f66.google.com ([209.85.160.66]:42047 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbeHWKSz (ORCPT ); Thu, 23 Aug 2018 06:18:55 -0400 Received: by mail-pl0-f66.google.com with SMTP id g23-v6so1965486plq.9 for ; Wed, 22 Aug 2018 23:50:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=0U20uNq0JjoONAI0eMORypsMDsKd5bIGTY/00N14L38=; b=TEsUOZwOYih/2RPYKii1xWeVNuuyUo/QC+ZmKfdpn5F0VAkvGPR2TI45EsEOc2/GYC RF19TKue07fT8a/7tgpTnohjhIxR7Icq2+Y6r32o8TUi7IZveYV4g9D/XE7A22kJ68xR OdF7xaOmFLzSHAm7FCO7Fdz+STuwe+sDRCzH4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0U20uNq0JjoONAI0eMORypsMDsKd5bIGTY/00N14L38=; b=O1ELVnOLYRwG+UFeawYv/DqiNFqCv8I3uSBR27dc7+8/WLqK564u/W40eipLOg9hHd sOTqpuE7vn6cg6ep2zdmUSyla4Hsh5Q3Z6n8RJsw2DtloaOjWU/BY3a91if22fyG4Q7j K2KuLd4zBYj++lQ4Lu53lYt4lnnSgGFAaQrUidk1YEnmImxo4EbWl2t3t9b4QehnOVQ3 AhjMuTNavurulXFEIrxQQ0nKWgooFw/nAFxITOHRKVIJncyHff4cMKyG8m8UG19iymtI ewnhUrWj1o2RltWr1u3nbWof1j7MJQMoSyrbUJDGFCIse0pJFzB4+Z3t4WYPI9espoFu TKfw== X-Gm-Message-State: AOUpUlFBH25JbVJMqLULG2D0+Zf39phUlcQv4PKeZ/Qfuv+PGMNLJLuo tpFicFq/NzH0DYPZf6WdusaMCw== X-Received: by 2002:a17:902:6183:: with SMTP id u3-v6mr21361297plj.19.1535007046347; Wed, 22 Aug 2018 23:50:46 -0700 (PDT) Received: from localhost.localdomain ([49.207.48.21]) by smtp.gmail.com with ESMTPSA id l85-v6sm6274501pfk.34.2018.08.22.23.50.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Aug 2018 23:50:45 -0700 (PDT) From: Amit Pundir To: Greg KH , Nikolay Aleksandrov Cc: "David S . Miller" , Stable Subject: [PATCH v2 for-4.9.y 0/5] net/sched: init failure fixes Date: Thu, 23 Aug 2018 12:20:36 +0530 Message-Id: <1535007041-31605-1-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Greg, Kindly consider/review following net/sched fixes for stable 4.9.y. This patchset is a follow-up of upstream fix 87b60cfacf9f ("net_sched: fix error recovery at qdisc creation") cherry-picked on stable 4.9.y. It fix null pointer dereferences due to uninitialized timer (qdisc watchdog) or double frees due to ->destroy cleaning up a second time. Here is the original submission https://www.mail-archive.com/netdev@vger.kernel.org/msg186003.html Cherry-picked and build tested on Linux 4.9.123 for ARCH=x86_64. These fixes are applicable for stable 4.4.y kernel as well, but one of the patches needed a minor rebasing, so I'm resending this series for 4.4.y in a separate thread to avoid any confusion. Regards, Amit Pundir Change since v1: Rebased "sch_multiq: fix double free on init failure" patch and fixed "unused variable" build warning. Nikolay Aleksandrov (5): sch_htb: fix crash on init failure sch_multiq: fix double free on init failure sch_hhf: fix null pointer dereference on init failure sch_netem: avoid null pointer deref on init failure sch_tbf: fix two null pointer dereferences on init failure net/sched/sch_hhf.c | 3 +++ net/sched/sch_htb.c | 5 +++-- net/sched/sch_multiq.c | 9 ++------- net/sched/sch_netem.c | 4 ++-- net/sched/sch_tbf.c | 5 +++-- 5 files changed, 13 insertions(+), 13 deletions(-) -- 2.7.4