From patchwork Thu Aug 23 06:51:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 144887 Delivered-To: patch@linaro.org Received: by 2002:a2e:164a:0:0:0:0:0 with SMTP id 10-v6csp757571ljw; Wed, 22 Aug 2018 23:52:02 -0700 (PDT) X-Google-Smtp-Source: ANB0VdYnpu57ctUpA61uMTNcnRet/xbX68XYB8by5AoqfsCeoENggDWRWW8FYNfjfj21dH0hNE2l X-Received: by 2002:a62:9541:: with SMTP id p62-v6mr380568pfd.194.1535007122270; Wed, 22 Aug 2018 23:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1535007122; cv=none; d=google.com; s=arc-20160816; b=CbG4bROcLdjTHTsddosSmni+judRI4vxfnF4m0VlR3g4yUEPlkHZCGDnWK7otOrDqr QUsuvOnc0c6JSwf/SMzS2xnCL1dkvAObFX993tcU41V7c71GKfbiljZmZZJSnj0ONu6n vqFK0Vp4pDt7Gefc2GGhSvM/pNdpu2fgN0DCVuTZCRAsE9Cgc0vUMUmipP6Zak+1K1RH uHszi1CiBCOXM1+W/N8sSdc4XKchjIYQtdkHQp8PQua1L+rRc1bvMKe0ZAlY90P0rT8a FpcNhiS4kKhKiCFKW0e+rkc5fhuyb84nJ/9NA8lK367Yl/gw/GT4NzipNmcdfVpQeoxX plJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=7LzslJkYDYYfrUxkPFx10meTUK33m9hsr8/pox/hKm8=; b=pifg0svGo3KqBl3SluAQK4ouMd/yXbLDdQIQOJyZAGLQmUrSFDFxAoYrvhWR0WzGhu G4AGmYtKESOFFpE9wOAyJsi8nk49KagYZUqEeNqVwJxDdRy0fyL8pVYRRJ5Ze0wvXPoG fpfKYOdh+heByvaAfm7Em5i3tNiI5Eh57sI4V3fK9bx/VHVk8G/ifFTZx8mGy4/3Fud9 mzvDxqrC5rLj5vVrQH+miPShIwHLv+OhH6UQfGqP9xxaA+bWcQs+DvjBWjmlDrSjxYOH Zb8aIsBD3RAP/zpaC5l29+XyzI5ymq9VHQt8LMegOdOFNLPp8klo2m6c1xbaT0nYlARH OyCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cbeeiso3; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cf13-v6si3685258plb.334.2018.08.22.23.52.01; Wed, 22 Aug 2018 23:52:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cbeeiso3; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726141AbeHWKUK (ORCPT + 13 others); Thu, 23 Aug 2018 06:20:10 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:46673 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726068AbeHWKUK (ORCPT ); Thu, 23 Aug 2018 06:20:10 -0400 Received: by mail-pl0-f65.google.com with SMTP id a4-v6so1954641plm.13 for ; Wed, 22 Aug 2018 23:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=7LzslJkYDYYfrUxkPFx10meTUK33m9hsr8/pox/hKm8=; b=cbeeiso39eXO2+sgK/UIobL3yHgzGe8axPnXN6qkCOR+A4QIK88caPhsjbRDNP62QZ /5SkaZGLsx4I9iboYL7yXTGrqhiLgrovwHLQBj8wDnPm2Wbr/kemNu26ft1PvhYld8j5 dbT7Y54fmdN8d6V2Cm6RqF3s1Pa82dpKAIpNA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7LzslJkYDYYfrUxkPFx10meTUK33m9hsr8/pox/hKm8=; b=OTpV6l+tkm5cZh4BQo94zgRRADhfb/eTqOkOV/eGYRsVzJrkjLMBg4XJtIrcHyr9OH 4H3NKfEHrK6e74BIOTZXaHuQJrlj4pxssYt+1jciYhatCqF7CkoCnG2GDy/AzSDQ1LRO jdUB+ae/PdIKnKt52Hi6JjEwy94V1ZwSPE1INSyj052iy32ops4CJbBydRx2/aW4aO+f tKfzvluLlFPm9Z3oNxZhIVae/AXemE9peGsnmJAND98Fg+15h5l1t1RPo+eyuV5a1oBw YqqUqiSC1qEZomLVrjeljlbd71MbhLQPPqlH1DLpRLEFoZ/zcuvaPPMQzc0aCTSpN6Fj MOcQ== X-Gm-Message-State: AOUpUlFCzSxcd+syGqRsh2wYavgFzsG4i9GZ8oUMiIugjqjRPLa0Pb8C B1jLNIMp1BF6OrfSjKlkwoNMZckZZto= X-Received: by 2002:a17:902:8604:: with SMTP id f4-v6mr57201979plo.225.1535007120796; Wed, 22 Aug 2018 23:52:00 -0700 (PDT) Received: from localhost.localdomain ([49.207.48.21]) by smtp.gmail.com with ESMTPSA id d132-v6sm7559932pgc.93.2018.08.22.23.51.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Aug 2018 23:51:59 -0700 (PDT) From: Amit Pundir To: Greg KH , Nikolay Aleksandrov Cc: "David S . Miller" , Stable Subject: [PATCH v2 for-4.4.y 0/5] net/sched: init failure fixes Date: Thu, 23 Aug 2018 12:21:51 +0530 Message-Id: <1535007116-31801-1-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Greg, Kindly consider/review following net/sched fixes for stable 4.4.y. This patchset is a follow-up of upstream fix 87b60cfacf9f ("net_sched: fix error recovery at qdisc creation") cherry-picked on stable 4.4.y. It fix null pointer dereferences due to uninitialized timer (qdisc watchdog) or double frees due to ->destroy cleaning up a second time. Here is the original submission https://www.mail-archive.com/netdev@vger.kernel.org/msg186003.html Cherry-picked and build tested on Linux 4.4.151 for ARCH=x86_64. Regards, Amit Pundir Change since v1: Rebased "sch_multiq: fix double free on init failure" patch and fixed "unused variable" build warning. Nikolay Aleksandrov (5): sch_htb: fix crash on init failure sch_multiq: fix double free on init failure sch_hhf: fix null pointer dereference on init failure sch_netem: avoid null pointer deref on init failure sch_tbf: fix two null pointer dereferences on init failure net/sched/sch_hhf.c | 3 +++ net/sched/sch_htb.c | 5 +++-- net/sched/sch_multiq.c | 9 ++------- net/sched/sch_netem.c | 4 ++-- net/sched/sch_tbf.c | 5 +++-- 5 files changed, 13 insertions(+), 13 deletions(-) -- 2.7.4