From patchwork Tue Apr 4 06:18:06 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 96689 Delivered-To: patch@linaro.org Received: by 10.140.89.233 with SMTP id v96csp48313qgd; Mon, 3 Apr 2017 23:18:30 -0700 (PDT) X-Received: by 10.99.96.72 with SMTP id u69mr21817908pgb.194.1491286710037; Mon, 03 Apr 2017 23:18:30 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si746909pgf.57.2017.04.03.23.18.29; Mon, 03 Apr 2017 23:18:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbdDDGS3 (ORCPT + 6 others); Tue, 4 Apr 2017 02:18:29 -0400 Received: from mail-pg0-f50.google.com ([74.125.83.50]:35289 "EHLO mail-pg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751074AbdDDGS2 (ORCPT ); Tue, 4 Apr 2017 02:18:28 -0400 Received: by mail-pg0-f50.google.com with SMTP id 81so142717337pgh.2 for ; Mon, 03 Apr 2017 23:18:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fokY1GsduFBds/k77siHsDGemCGdOJb8EJ0OnKUTxh8=; b=EuIS7KIsD3fucypsXtPrTIzkVF9Ptmz93pqFmEkpt6LSuptHL+A+mvgePimBLZ5xXW wrIu/qGo49gesWidWDYwzFZWcKniqDdwDuHfLkYLv6WQs2O8vPdCISBo1FxSyEKuHqDw UucCAvUplw5EYQSdQNQ7T6iP5PD/FTgVJETvU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fokY1GsduFBds/k77siHsDGemCGdOJb8EJ0OnKUTxh8=; b=iPoLy9ZjNhDq6pRkrCi9V45lM9/RMfn/mLRGnrNotPSfm5u3/FnIyfeEVoxE0QOo4v dIvkclmKcXNxz0JWaI1t5InxGHeu41GnohR9Xm1YZP5zrh+Zu9XmXYQXIsLtEJLyPBPR dmF6t9u0Or6teU5/DkdO/7h0qBOMLftbwM+bf/Ke4Si5LHXSWPYh4BwI8YUdibH5+3q1 c0a7ewf2hEmnKU4X5Yc7cZ9tt0EoiH2ExFN4yWet4QrYneMGvBjvb5ENDbA/BwQQpvNi 0nZ+vfxrRqqa8zTrFm8sCtYrRWJrtm+RbiuU9x767i1BsxfJFZIdRkJwsncJ+B8Ml31S 8tSg== X-Gm-Message-State: AFeK/H3nHGwpw8Th5upOOwDsQQrLDn9dB7RrSMmA+U7wO5JqXcJFazHMooNYzqxOiS/xVYH7 X-Received: by 10.84.222.4 with SMTP id w4mr5700974pls.184.1491286708062; Mon, 03 Apr 2017 23:18:28 -0700 (PDT) Received: from localhost.localdomain ([106.51.240.246]) by smtp.gmail.com with ESMTPSA id m20sm29331500pgd.32.2017.04.03.23.18.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Apr 2017 23:18:27 -0700 (PDT) From: Amit Pundir To: gregkh@linuxfoundation.org Cc: stable@vger.kernel.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo Subject: [PATCH 27/33] brcmfmac: switch to C function (__brcmf_err) for printing errors Date: Tue, 4 Apr 2017 11:48:06 +0530 Message-Id: <1491286688-31314-8-git-send-email-amit.pundir@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491286688-31314-1-git-send-email-amit.pundir@linaro.org> References: <1491286688-31314-1-git-send-email-amit.pundir@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Rafał Miłecki This will allow extending code and using more detailed messages e.g. with the help of dev_err. Signed-off-by: Rafał Miłecki Acked-by: Arend van Spriel Signed-off-by: Kalle Valo (cherry picked from commit 087fa712a00685dac4bcc64b7c3dc8ae6bee8026) Signed-off-by: Amit Pundir --- .../net/wireless/broadcom/brcm80211/brcmfmac/common.c | 16 ++++++++++++++++ drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) -- 2.7.4 diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c index 3e15d64..2dcca71 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c @@ -218,6 +218,22 @@ int brcmf_c_preinit_dcmds(struct brcmf_if *ifp) return err; } +#ifndef CONFIG_BRCM_TRACING +void __brcmf_err(const char *func, const char *fmt, ...) +{ + struct va_format vaf; + va_list args; + + va_start(args, fmt); + + vaf.fmt = fmt; + vaf.va = &args; + pr_err("%s: %pV", func, &vaf); + + va_end(args); +} +#endif + #if defined(CONFIG_BRCM_TRACING) || defined(CONFIG_BRCMDBG) void __brcmf_dbg(u32 level, const char *func, const char *fmt, ...) { diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h index 1fe4aa9..441a666 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h @@ -45,6 +45,8 @@ #undef pr_fmt #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt +__printf(2, 3) +void __brcmf_err(const char *func, const char *fmt, ...); #ifndef CONFIG_BRCM_TRACING /* Macro for error messages. net_ratelimit() is used when driver * debugging is not selected. When debugging the driver error @@ -53,11 +55,9 @@ #define brcmf_err(fmt, ...) \ do { \ if (IS_ENABLED(CONFIG_BRCMDBG) || net_ratelimit()) \ - pr_err("%s: " fmt, __func__, ##__VA_ARGS__); \ + __brcmf_err(__func__, fmt, ##__VA_ARGS__); \ } while (0) #else -__printf(2, 3) -void __brcmf_err(const char *func, const char *fmt, ...); #define brcmf_err(fmt, ...) \ __brcmf_err(__func__, fmt, ##__VA_ARGS__) #endif