From patchwork Mon Apr 10 17:44:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sumit Semwal X-Patchwork-Id: 97208 Delivered-To: patch@linaro.org Received: by 10.182.246.10 with SMTP id xs10csp1456522obc; Mon, 10 Apr 2017 10:45:59 -0700 (PDT) X-Received: by 10.84.224.136 with SMTP id s8mr13940138plj.93.1491846359370; Mon, 10 Apr 2017 10:45:59 -0700 (PDT) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w21si14197944pgh.90.2017.04.10.10.45.59; Mon, 10 Apr 2017 10:45:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753997AbdDJRpw (ORCPT + 5 others); Mon, 10 Apr 2017 13:45:52 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:34100 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753027AbdDJRpv (ORCPT ); Mon, 10 Apr 2017 13:45:51 -0400 Received: by mail-pf0-f180.google.com with SMTP id c198so25508337pfc.1 for ; Mon, 10 Apr 2017 10:45:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qIii9Fm+SvwEEzyBcxIH6F74YRHy/7vYFyXQT+CrHGE=; b=eLn+iWOoRuAbmPL1gN572bm2yrahECjqHD0nkaUI61wdLku8taG9m759i6ldjxwZqc hG4aLKW/yurFxhiHkzgVlqRCmMxhdqrtLYkxb2pHApzIfCvfKDo9R2H2OV7THZVPAiIi +pNYEdFaXJFvGmh4bApHt9N5TabSZa0iUpzC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qIii9Fm+SvwEEzyBcxIH6F74YRHy/7vYFyXQT+CrHGE=; b=b7fGPvYBP49UotZClFgyl+xAwxjXZvOxHyw2VgjdUyU1y8y3D/bOecygpesSvmvTRP 2eNkqhpPg8oKmize5OqFuMEvEMgKEBZHPlBD6vRH9VUa4wssoe2HU0ATSAr92880/35+ 91QkVHqZn6Tfw60wk+BbfUuxBIxjcyW5UEyqBWmGGmAyBkEK3yc4qjWFV9ULt9NlhQrP KDGZkFhcW/IRXseHHOxLvA82o+1STklbiraIUHc1bYwU3C7W18ve1HQ4am740v0Gbc2f iBI3MXLAUNhwv9XV5x/SaQtKRs1QzRztjDnuPKaPG3dtYKUlJvd7GDucAFcZQt69VAmw NIBA== X-Gm-Message-State: AN3rC/4SYf6zVEAFYyaIhdorTX3en8jZgBxTvx1cMjviK9uwvBp6UUrMMTB3DinsFtwC5h7m X-Received: by 10.98.6.70 with SMTP id 67mr17239234pfg.156.1491846334752; Mon, 10 Apr 2017 10:45:34 -0700 (PDT) Received: from phantom.lan ([106.51.225.38]) by smtp.gmail.com with ESMTPSA id y6sm768833pfa.83.2017.04.10.10.45.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 10 Apr 2017 10:45:33 -0700 (PDT) From: Sumit Semwal To: stable@vger.kernel.org Cc: Vitaly Kuznetsov , "K . Y . Srinivasan" , Greg Kroah-Hartman , Sumit Semwal Subject: [PATCH for-4.4 09/16] Drivers: hv: get rid of timeout in vmbus_open() Date: Mon, 10 Apr 2017 23:14:25 +0530 Message-Id: <1491846272-14882-10-git-send-email-sumit.semwal@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1491846272-14882-1-git-send-email-sumit.semwal@linaro.org> References: <1491846272-14882-1-git-send-email-sumit.semwal@linaro.org> Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vitaly Kuznetsov [ Upstream commit 396e287fa2ff46e83ae016cdcb300c3faa3b02f6 ] vmbus_teardown_gpadl() can result in infinite wait when it is called on 5 second timeout in vmbus_open(). The issue is caused by the fact that gpadl teardown operation won't ever succeed for an opened channel and the timeout isn't always enough. As a guest, we can always trust the host to respond to our request (and there is nothing we can do if it doesn't). Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sumit Semwal [sumits: cherry picked for 4.4.y] --- drivers/hv/channel.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.7.4 diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c index ec61ad8..800598c 100644 --- a/drivers/hv/channel.c +++ b/drivers/hv/channel.c @@ -73,7 +73,6 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, void *in, *out; unsigned long flags; int ret, err = 0; - unsigned long t; struct page *page; spin_lock_irqsave(&newchannel->lock, flags); @@ -183,11 +182,7 @@ int vmbus_open(struct vmbus_channel *newchannel, u32 send_ringbuffer_size, goto error1; } - t = wait_for_completion_timeout(&open_info->waitevent, 5*HZ); - if (t == 0) { - err = -ETIMEDOUT; - goto error1; - } + wait_for_completion(&open_info->waitevent); spin_lock_irqsave(&vmbus_connection.channelmsg_lock, flags); list_del(&open_info->msglistentry);