From patchwork Thu Mar 1 15:20:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sasha Levin X-Patchwork-Id: 130234 Delivered-To: patch@linaro.org Received: by 10.80.172.228 with SMTP id x91csp2929635edc; Thu, 1 Mar 2018 07:20:37 -0800 (PST) X-Google-Smtp-Source: AG47ELv4TNic2Cjx/qfG/Xw5YY2WZYR/GHVabrMIPOau8S4WeIUtesqA7rQfxGcrgCEhwaKQvxA2 X-Received: by 10.98.3.131 with SMTP id 125mr2306331pfd.65.1519917637617; Thu, 01 Mar 2018 07:20:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519917637; cv=none; d=google.com; s=arc-20160816; b=gsxUj+Yx6mjlHss84x/bMBLy1w3tF0oOSjQOz0AppzW1fYcBOnHV9P9TDcqUGxF3i0 nC97cmdRPXL/Aurvsxt/yt5iaNb+ZCsCxnBvwrlEXDX5dlfQoAJdjyrqipf19BmhJSoZ kCwGQiJJVmaoPUVSOyBVVCmYWYOSWiiL5fJIPLLCVLL/rrE1Jc5F46QszEj9IcG/erpB 6QBD5fgqh3kDzxSi36kxGKzhYovkRvoP4Hjqrllc59Ix8CGg/Kkf+7yCpNBTlzik+b+b eFiwWrWDyOisyLFjNBdFdG2MAiOCesECsymP3Td+WxcKKvT7UAh5XiKwGS+IckHKkRPV dJJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=IFPqksaYstz1eCFL21FjFk7Z1V2iBZQ4ScoybL0asng=; b=XpRNamQTK77b+UKcgx1xtginbH/jvrb42xr5HfSNGaYXKS5ZsIN4t5ZkzXwFZqp6co U2LMtS/H2rP8etNOpNMNyeCvQXrlh1WcIGe5fLD1/iT5JS2tUzitRzEf3TRFonRdXIQE fAdfEf48ClXSywXwaDUeQMVYDEDLWJoo9PAiyjRPA0inWlBGSiK1Kv2Y+k+23/g6lch/ 9G1p1Dwghf4yDHl7BuMclYH2vxnnzCvP6blHrGCq89XNYvf60CuJ2Sx9jgNuacbHQxWC V6wmvVCUx9JdefH83jVlwgiJK1mq88gTHNnK3QvcTxzNpS5fE5s+0gmQ/4H+AYpGKuk+ AKjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WsZ/PsbQ; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si2229365pgq.750.2018.03.01.07.20.37; Thu, 01 Mar 2018 07:20:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@microsoft.com header.s=selector1 header.b=WsZ/PsbQ; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031829AbeCAPUg (ORCPT + 10 others); Thu, 1 Mar 2018 10:20:36 -0500 Received: from mail-bl2nam02on0102.outbound.protection.outlook.com ([104.47.38.102]:36616 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1031833AbeCAPUW (ORCPT ); Thu, 1 Mar 2018 10:20:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=IFPqksaYstz1eCFL21FjFk7Z1V2iBZQ4ScoybL0asng=; b=WsZ/PsbQzsZ6sfrRrNNrvDmKuBGpin4DsbILWsdGg7XH5afenPquyGHYHb5ZmkzuotxUnLNxyohohS3jeIgAKglu8XMdwTAicERKEOeDk0FyZZLw/5CqFes08ZCW30a/LqbUChJ7SwWwXeENNg48PasMM0IMUr2t2/cCntTv1H0= Received: from DM5PR2101MB1032.namprd21.prod.outlook.com (52.132.128.13) by DM5PR2101MB1061.namprd21.prod.outlook.com (52.132.128.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.567.2; Thu, 1 Mar 2018 15:20:16 +0000 Received: from DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446]) by DM5PR2101MB1032.namprd21.prod.outlook.com ([fe80::8063:c68a:b210:7446%2]) with mapi id 15.20.0567.006; Thu, 1 Mar 2018 15:20:16 +0000 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Arnd Bergmann , Guenter Roeck , Sasha Levin Subject: [added to the stable tree] hwmon: (asus_atk0110) fix uninitialized data access Thread-Topic: [added to the stable tree] hwmon: (asus_atk0110) fix uninitialized data access Thread-Index: AQHTsXDHLugRPv24PEOsiTZwKFs49g== Date: Thu, 1 Mar 2018 15:20:06 +0000 Message-ID: <20180301151857.721-30-alexander.levin@microsoft.com> References: <20180301151857.721-1-alexander.levin@microsoft.com> In-Reply-To: <20180301151857.721-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM5PR2101MB1061; 7:Hzf65G6qoip0QXddqpoFHvAIL/jd1XHHzEffw2wsdpL/wX+WGh8e3fPKm1t/NQTGO++RZQnH7Nwzug3oet4Ko3KltDrbUjpPSJzX6xOCMiQ/lq3gtteR+u0cfRID23nKNJhJzIqzo9bzNmmKfrpgMBO8NEBg1DaR4aWFyRILrh0sKtWUVvb3muhQWnsiQsAL4zLEaZrk+9CWk0DYRQkpDjKenA7AUT7XKrMZ88HgJimqsZmtAYccba0j9qdHdtar x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: ece9c021-78c2-4b6d-75f1-08d57f87f023 x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020); SRVR:DM5PR2101MB1061; x-ms-traffictypediagnostic: DM5PR2101MB1061: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(85827821059158); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(3231220)(944501226)(52105095)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DM5PR2101MB1061; BCL:0; PCL:0; RULEID:; SRVR:DM5PR2101MB1061; x-forefront-prvs: 05986C03E0 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39380400002)(39860400002)(376002)(396003)(346002)(366004)(189003)(199004)(6506007)(66066001)(99286004)(2501003)(5250100002)(14454004)(3660700001)(59450400001)(6436002)(97736004)(106356001)(6116002)(3846002)(36756003)(4326008)(6486002)(6512007)(68736007)(102836004)(186003)(86612001)(72206003)(7736002)(8936002)(81166006)(81156014)(22452003)(2900100001)(305945005)(76176011)(25786009)(6346003)(53936002)(110136005)(105586002)(54906003)(8676002)(2950100002)(316002)(26005)(1076002)(478600001)(107886003)(10290500003)(10090500001)(3280700002)(86362001)(2906002)(6666003)(5660300001)(22906009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR2101MB1061; H:DM5PR2101MB1032.namprd21.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: microsoft.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-message-info: Qg+a/RWHWF9x9W3LQ7m88bmckumF05Fisvhdxgu8dEsXgtZ+GzSXVHFtyq/XqJe5diVIivRqeXMvQWV9X7Xw+kIODJoxuI41YmcQs5GKfNRHzgPYUFZU7er9tJ7fGTeXbQbiVoedSasTRz4eZHOcpWgF+AIgLDahYYDgSedmOGw= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: ece9c021-78c2-4b6d-75f1-08d57f87f023 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Mar 2018 15:20:06.1675 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB1061 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann This patch has been added to the stable tree. If you have any objections, please let us know. -- 2.14.1 =============== [ Upstream commit a2125d02443e9a4e68bcfd9f8004fa23239e8329 ] The latest gcc-7 snapshot adds a warning to point out that when atk_read_value_old or atk_read_value_new fails, we copy uninitialized data into sensor->cached_value: drivers/hwmon/asus_atk0110.c: In function 'atk_input_show': drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized] Adding an error check avoids this. All versions of the driver are affected. Fixes: 2c03d07ad54d ("hwmon: Add Asus ATK0110 support") Signed-off-by: Arnd Bergmann Reviewed-by: Luca Tettamanti Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/asus_atk0110.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c index cccef87963e0..975c43d446f8 100644 --- a/drivers/hwmon/asus_atk0110.c +++ b/drivers/hwmon/asus_atk0110.c @@ -646,6 +646,9 @@ static int atk_read_value(struct atk_sensor_data *sensor, u64 *value) else err = atk_read_value_new(sensor, value); + if (err) + return err; + sensor->is_valid = true; sensor->last_updated = jiffies; sensor->cached_value = *value;