From patchwork Fri Nov 22 10:51:09 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 180026 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp65956ilf; Fri, 22 Nov 2019 03:15:39 -0800 (PST) X-Google-Smtp-Source: APXvYqyFS0jT/WUl70v8vq3LJEnZIWe53Q/pgIVNx38O21hgxnlvTiKWPmlsx9VDOzJIEREjXQ8P X-Received: by 2002:a50:f699:: with SMTP id d25mr357725edn.72.1574421339238; Fri, 22 Nov 2019 03:15:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574421339; cv=none; d=google.com; s=arc-20160816; b=KyKKZGdKgxloJup4IdiwRo87hy7x63/QonaGhkWaB3T7B4d74BdZ1wHiJhXqCIXn2r eD9zX7cnSi8VNbe5qe7FzXQUH2Ih6WxrLQw1gJafIwdWzBPFhkiYKiAy23fyE5w20k9F UOeo1kLYWx/snvUK+rMtx+ZSvqjXNFHYfgj9juLd11g9SrF3u6EP9kurXslKheHTsY1V W393a2sMPIHsXdpdlIgRjEYm4IB2wzmd2F4V7hdWye5YxlIbTX2cSd62dNGSBhf8A7rL 6SycuHqJ+4JAMHWN98mIygGj2CAyn5w1n6/Cp+TePuszYp/2EtXsmQa3LiiZYX+XSsol XElA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=xoswTEced0zgBg3f0q2Jl0pYmerTX2npX5p/p8vJwQY=; b=VMINLKMT4SzBxX0M3tt8YTsYvubrcyOENWWRdkUxhmw96c+ctO790J96/jD17suqC/ rzbwwDln7lIyiU+vKg2fv9rHqBKVF2TI6qTEdQ4jKhPHcEVrR96sxq86rI+a16ExU8Sz d2lKfEPWhG/YnsaO+n306e0FZEbOUnuaH5J07c5udJjmm57uj2NuoDKKycWyyaWc2L4z Iitnh52DZ3H+guqpeU1ciQL5rErvSCXJUwatvANUBgoz23ghguPEkCOb8zwgMCetkmJr nZFwGaiD4E6jDJpZzs5Cxs9gGjdjUGyTQRw/qLo3Ed4YXAZxf0FDZYv4hS+3O5KeM2Sg RYMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d0fRaHbG; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id rk11si347318ejb.359.2019.11.22.03.15.39; Fri, 22 Nov 2019 03:15:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=d0fRaHbG; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727184AbfKVLPi (ORCPT + 15 others); Fri, 22 Nov 2019 06:15:38 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:46089 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730003AbfKVKvm (ORCPT ); Fri, 22 Nov 2019 05:51:42 -0500 Received: by mail-wr1-f68.google.com with SMTP id z7so4625307wrl.13 for ; Fri, 22 Nov 2019 02:51:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=xoswTEced0zgBg3f0q2Jl0pYmerTX2npX5p/p8vJwQY=; b=d0fRaHbGkO9SZLpmTd+orsxx3VQXbNb8pQVDFeYLwJxA6KQ0sZ9ND5lJ496yR59TAD FerJ3hEcnsr58Kx8f/Xe12ph4bqaMpDJk/8URPW4eNbzyqc43zUYqB5Pz3evcAOkbBdu aZglLxVtHNDLFvlNXxcqDkZmilVa4qkUcWj8tF2zFaE8l4k87e096b6/y9xj+bZVQED4 6wv9xtQnUJQXRfDHp/I26rCOVvyEF1BWnf4pLuC7jix4pRb4eweZTN+M8E8UDOzST/eM rqbJZjrNRJ2vUbTkAbU901BTZeG/f4dNSojpWQso6CI1tZ123UQlULz3xPLaYeyGeTD+ Mtxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xoswTEced0zgBg3f0q2Jl0pYmerTX2npX5p/p8vJwQY=; b=L79zT1WO6pyajvjSkYts7lRK6dURV0UxrSJWSK/zZROZBNQvLOCDQyHvs0L14yRAHg yTjV1haUrtXQZfn9uzvNdN7zMkG/OEEkm0iKyms458AZZAFTzsqKTWywmuWmiL3+vViB 41h0GJwAlx+0rzXnuadinnvNcwbw+5dLWpkGqpgGEP3mU5ODcNGlYmiksjXbL9zUrkde WPy09jYCix6lczL/V0Gyfku+DjBTYo/euGFVI7OEHv2dCR4GS6YSqPgjuYn0YPwnZfft guc01+r4UTqeqwY3JULKOr3xJ3q7pAnIaDuGAK4429uxB34IiFiJwnXRwztm5y/2kGFW wfbA== X-Gm-Message-State: APjAAAWaOLLDc+mRMhN/HVMgHxcC/GFRVU44bnLGfDlMU1QKtSjdBrIY ArA8xJ3L24fg4jQupmRNjjy+1Q== X-Received: by 2002:a5d:4b05:: with SMTP id v5mr16697880wrq.210.1574419900607; Fri, 22 Nov 2019 02:51:40 -0800 (PST) Received: from localhost.localdomain ([2.27.35.135]) by smtp.gmail.com with ESMTPSA id w4sm2894338wmk.29.2019.11.22.02.51.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Nov 2019 02:51:40 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, gregkh@google.com, stable@vger.kernel.org Subject: [PATCH 4.4 5/9] bcache: silence static checker warning Date: Fri, 22 Nov 2019 10:51:09 +0000 Message-Id: <20191122105113.11213-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191122105113.11213-1-lee.jones@linaro.org> References: <20191122105113.11213-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit da22f0eea555baf9b0a84b52afe56db2052cfe8d ] In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if statement. Signed-off-by: Dan Carpenter Reviewed-by: Coly Li Signed-off-by: Jens Axboe Signed-off-by: Lee Jones --- drivers/md/bcache/super.c | 3 --- 1 file changed, 3 deletions(-) -- 2.24.0 diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index e42092146083..58e16a3fb3bd 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1395,9 +1395,6 @@ static void cache_set_flush(struct closure *cl) struct btree *b; unsigned i; - if (!c) - closure_return(cl); - bch_cache_accounting_destroy(&c->accounting); kobject_put(&c->internal);