From patchwork Wed Nov 27 07:21:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 180259 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp5735773ilf; Tue, 26 Nov 2019 23:22:21 -0800 (PST) X-Google-Smtp-Source: APXvYqzHisVMuvB5fDxVKjqDUIq5MkrAEIpL1XfPABFOY7TQ6I+iyeZmmukqtwz8Xick9qwHk2fO X-Received: by 2002:a50:f699:: with SMTP id d25mr29555662edn.72.1574839341434; Tue, 26 Nov 2019 23:22:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574839341; cv=none; d=google.com; s=arc-20160816; b=yM/RgPNSnJyKK7c0MnQ2l4aZ69quVmOs2nGhuvpIghGOIpt2goGSnDjF5R4DO57tYF MegktYjiHxSxQWJV1UAI08W7nRnSKcxv4FP806CgD5VuYlSUO8KH+lw8vqUo4cff9q6o rUHzLyFBBs3AHkw7besxt/z/Mg9gzA+WrUHZtvMHM0LfJ+bSITbZUFP8w2bIFVt+NQKA i1S1k49SAP3HKf41Xnzm4boSWcnaQpXyLBDsIMHN6mV/SvxhbE4KAIku1FgAN3vl3Ctp eZ0Bq00V5CI0sHiww/D+8ESzmsWS81BEldp3hTyL0pofpbNtiY8rRP/kDRoZhV7BkeV8 HZrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=Gy06tYfgg/j4igOn88GPHku4s1HMYQmNNOQvmkqJT/M=; b=ab5cLCE/z3d0OmvGXBZhdoOpWwqvMERA/XZ3WReq7O6tTdBxtG0VyLa6eApJFLXmDb NWtmR5A+m34sANX9C9FxU3e8rj5R1lypFbJT9T6AAev2e28oKxQPNduS8sCla2YQ78EP sDC0teoB9Dpe2/RjT+OSNBBWdlsvv5j4JtrXexzAqFIiWryiOckc9zS5ub6Z/d8OP44K wZWXku4wGrk0BlxNsWRrigwwmHawN3tzyqDgOuw8zRiqnxbXI2NgRe5qHEDKwevyapy7 7Lf3jVhIsxx6kYz2VmaWwb2tiirjOtVFjVnCNC7e4To2vV6H7gXwhckkdMQljSmC6llS WjWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bo5QgBMt; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m19si69058ejc.66.2019.11.26.23.22.21; Tue, 26 Nov 2019 23:22:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bo5QgBMt; spf=pass (google.com: best guess record for domain of stable-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbfK0HWU (ORCPT + 15 others); Wed, 27 Nov 2019 02:22:20 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38202 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726227AbfK0HWU (ORCPT ); Wed, 27 Nov 2019 02:22:20 -0500 Received: by mail-wm1-f66.google.com with SMTP id z19so6164407wmk.3 for ; Tue, 26 Nov 2019 23:22:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Gy06tYfgg/j4igOn88GPHku4s1HMYQmNNOQvmkqJT/M=; b=bo5QgBMti8HYRZf5cM9otFSJRwsKxonSGMMsJE0+XQDQdTV21UshShxcpKM+ovTz3o lEZ8/mV3K+1R/qwDUU70AgTGRyJNV4Gbpc4vJVU38zq1kcLVV/bfWRVFZxzPjPTDLpkd NprC5x4uz6dODMmaNmntnez4PI0T62CvUUSTKvHC3Kq8fY/IrJHTzCy4WymYUuZeYQc4 lag/W635AwkQfptTQJ8QlSL08djiGXDcyHiHaZuP9My8q6NwDNVzN/pkDvtPJQUROlsk E6zcDIQfLkzZ9Q82pYABe3ddr//8g1PQ6KqW9ThG7ZAjsmixryNY3Niwha0adYsTtg+R 1/5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Gy06tYfgg/j4igOn88GPHku4s1HMYQmNNOQvmkqJT/M=; b=Vmp2i9eti1EQczMJbKAHP76LLHAu7zdEYxryK9Nosv/yF+iOd4CPPDDwdw+qgJzwb9 +lBWrzMIOjKUdTax9gJEHPsl+s2ecHb7yeZJ8sUPOf5UBdj/Mhe/DXdCriaadZd2tH5A JgeKKmQhJGgZ0AYRNjZtVjd0kioFrvAPbLL0kM0SHIcGDs9S+gXq7GVocIzngtobD0UC bpZ24dFXaJ3x3DlGmknOX+vQ5eoaaZs+9L07oMJQwDBxwBVkHzeEVLtSMlXLl2flSvx+ 3M3ASPZ2nLOqE9laNAmpmhyce04LOgVFPO0h87rcAeV/MjLNj3oYgSdWWyvhA+KEmN8d E04w== X-Gm-Message-State: APjAAAXbsrMw17RqMEQXEUYdCRtMvNIE8g7y54EW6d8uXvZULnCyK+X8 UB+lnjBZl7rzLuy57oxeLdNOW82xnW4= X-Received: by 2002:a05:600c:1088:: with SMTP id e8mr2873864wmd.7.1574839338267; Tue, 26 Nov 2019 23:22:18 -0800 (PST) Received: from localhost.localdomain ([95.149.164.101]) by smtp.gmail.com with ESMTPSA id d20sm19406915wra.4.2019.11.26.23.22.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 23:22:17 -0800 (PST) From: Lee Jones To: stable@vger.kernel.org Subject: [PATCH 4.14 2/5] media: siano: Use kmemdup instead of duplicating its function Date: Wed, 27 Nov 2019 07:21:59 +0000 Message-Id: <20191127072202.30625-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127072202.30625-1-lee.jones@linaro.org> References: <20191127072202.30625-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wen Yang [ Upstream commit 0f4bb10857e22a657e6c8cca5d1d54b641e94628 ] kmemdup has implemented the function that kmalloc() + memcpy(). We prefer to kmemdup rather than code opened implementation. This issue was detected with the help of coccinelle. Signed-off-by: Wen Yang CC: Tomoki Sekiyama CC: linux-kernel@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Lee Jones --- drivers/media/usb/siano/smsusb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.24.0 diff --git a/drivers/media/usb/siano/smsusb.c b/drivers/media/usb/siano/smsusb.c index ec759f43c634..3ab72d653737 100644 --- a/drivers/media/usb/siano/smsusb.c +++ b/drivers/media/usb/siano/smsusb.c @@ -226,10 +226,9 @@ static int smsusb_sendrequest(void *context, void *buffer, size_t size) return -ENOENT; } - phdr = kmalloc(size, GFP_KERNEL); + phdr = kmemdup(buffer, size, GFP_KERNEL); if (!phdr) return -ENOMEM; - memcpy(phdr, buffer, size); pr_debug("sending %s(%d) size: %d\n", smscore_translate_msg(phdr->msg_type), phdr->msg_type,