From patchwork Fri Jan 24 09:29:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 233209 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03C67C2D0DB for ; Fri, 24 Jan 2020 09:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CF79F21734 for ; Fri, 24 Jan 2020 09:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859570; bh=xmJ6Yq12MlaEQQHRa9y9gtOJJsLZW8uh5VcTiWaOeTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NH9+zxkufbpqetAUhbSi205YJZIR5RaRU7kqNGXT3D+EzQSrf39OONemISKP5VXSu CRFySm+X9+ggRvL4oLIkV5HgFSRYVPpm95GVsrxJew2m0lA4KtOaNPz50XBy97Jwr2 MPHu65OOuDPIssA+finsLSGzD2llevBBCBYjTEOc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388179AbgAXJwu (ORCPT ); Fri, 24 Jan 2020 04:52:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:54850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731453AbgAXJwt (ORCPT ); Fri, 24 Jan 2020 04:52:49 -0500 Received: from localhost (unknown [145.15.244.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3F48320709; Fri, 24 Jan 2020 09:52:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579859568; bh=xmJ6Yq12MlaEQQHRa9y9gtOJJsLZW8uh5VcTiWaOeTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oOiKorbggX1KkrTUslWc4+Gj6GAHUEzymD1QIcs+OF3JRFADYwHHvM0lpJvAiVG6+ koHSC5p9GRXqgvS4TFPMcnuZz1E5Atcjnl6Cr3J9FuejUXmtO1yMYztS7130OQCMyS clF5ZbaFh3cKjVTfvvSzCJEPmJPHQGN2g35z0TDk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 4.14 145/343] media: cx18: update *pos correctly in cx18_read_pos() Date: Fri, 24 Jan 2020 10:29:23 +0100 Message-Id: <20200124092939.077255169@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124092919.490687572@linuxfoundation.org> References: <20200124092919.490687572@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter [ Upstream commit 7afb0df554292dca7568446f619965fb8153085d ] We should be updating *pos. The current code is a no-op. Fixes: 1c1e45d17b66 ("V4L/DVB (7786): cx18: new driver for the Conexant CX23418 MPEG encoder chip") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/cx18/cx18-fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx18/cx18-fileops.c b/drivers/media/pci/cx18/cx18-fileops.c index 98467b2089fa8..099d59b992c1b 100644 --- a/drivers/media/pci/cx18/cx18-fileops.c +++ b/drivers/media/pci/cx18/cx18-fileops.c @@ -484,7 +484,7 @@ static ssize_t cx18_read_pos(struct cx18_stream *s, char __user *ubuf, CX18_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc); if (rc > 0) - pos += rc; + *pos += rc; return rc; }