From patchwork Tue Mar 31 08:59:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 228571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74636C2D0EE for ; Tue, 31 Mar 2020 09:21:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B43720772 for ; Tue, 31 Mar 2020 09:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585646473; bh=QQ6ebnUvoHQNHZ6qn9BQCIRm9XiS9wC5bt9itZPaTN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=i4qD2JDBcIksqQl3MFTsyKl6VB3ewXKH1fE7K5/QCcAYGdF16Tt5egbn5AeoAfLec LMZfeJrOZP35aYbzj/cGMPSo7kW84mbT4K9vm0rCjDVQaDgujOTib2eV4S5b6kUVm5 CIR1F1ubc45F+l+fe1M4QcIKs+7qptygxO4EREBs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730946AbgCaJVJ (ORCPT ); Tue, 31 Mar 2020 05:21:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:54036 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731305AbgCaJKS (ORCPT ); Tue, 31 Mar 2020 05:10:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A945F208E0; Tue, 31 Mar 2020 09:10:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585645818; bh=QQ6ebnUvoHQNHZ6qn9BQCIRm9XiS9wC5bt9itZPaTN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sylZdlmx1d94gMLS49N20OkiB+898SsgxiHo1Tzpr2l5P0GqQ1Su6SX71g/wIUGwv aG4e1SDR2PgdBt9oL44ZnBDsrivOc6iJl4ek5whE7Dt6V24hqEfThZWAcJgm7LT2AZ wFIAqY0jmaLSwTNT2LK5W4v4rQGcED8GsBZFQxEg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+6d2e7f6fa90e27be9d62@syzkaller.appspotmail.com, Qiujun Huang Subject: [PATCH 5.5 159/170] staging: wlan-ng: fix ODEBUG bug in prism2sta_disconnect_usb Date: Tue, 31 Mar 2020 10:59:33 +0200 Message-Id: <20200331085439.782195867@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200331085423.990189598@linuxfoundation.org> References: <20200331085423.990189598@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiujun Huang commit a1f165a6b738f0c9d744bad4af7a53909278f5fc upstream. We should cancel hw->usb_work before kfree(hw). Reported-by: syzbot+6d2e7f6fa90e27be9d62@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang Cc: stable Link: https://lore.kernel.org/r/1585120006-30042-1-git-send-email-hqjagain@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlan-ng/prism2usb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/wlan-ng/prism2usb.c +++ b/drivers/staging/wlan-ng/prism2usb.c @@ -180,6 +180,7 @@ static void prism2sta_disconnect_usb(str cancel_work_sync(&hw->link_bh); cancel_work_sync(&hw->commsqual_bh); + cancel_work_sync(&hw->usb_work); /* Now we complete any outstanding commands * and tell everyone who is waiting for their