From patchwork Fri Jun 19 14:31:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191225 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp626738ilo; Fri, 19 Jun 2020 08:23:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6svWb2XOjQbkxlW0q7xEHu9lOmxD+err1NwHv3rPodO0fegqHoHcst9mFxYfG+DD2WRzN X-Received: by 2002:aa7:c90a:: with SMTP id b10mr3917970edt.198.1592580234408; Fri, 19 Jun 2020 08:23:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592580234; cv=none; d=google.com; s=arc-20160816; b=Pq8FBLhEhUkpChty3e09//LKLlOzNSrgpQpt8w8CwTbyxIvlybWFfU7FhrSHxF/WLT wknxEqQhj068TpQ5KsV+jPnrkUFQohcyX+5HPyibyH5nB7jD19tW1AIk0kxn7wrU9tPu isZ7WHEB8b/bNTExkdtPo+EhMx5seb2h0B2Oq4ydPCh2r0qN6RNgBlc5jAMoL6o3XjBs DHuncZr6x8fIl2/FCXET9uHTiQeD3w6z0pT6UnGPqY031XnflC112Z56VCtXdPig0HIp PvV1j0z9wznyg5osLgeT4gV8Y9iOKlR4Hwtq1Y6pxqI/iuurDnI9etVTjgI6Vr+1GoZn Egtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9v3ssGgPaflKMTcghwDY1fVCqkSxsVoweo9blpQJzzE=; b=OjYd1Llb6hL+8NdQKBWHIaHphe2SLRTxmNU13Ko7f5+0sWaGaO8oQoSgFuhltePJ2x 1vjw4X13jatCtP7lTv7jYttJ1QMMRf4HOCkslbOZPxHQV2QIqyKfqNcrf7srj4rgoyyD Am1uDD1Ye5RV6e8FVSdL0dHP1C9eaOC17itds0k9k1MaaB7T9eTBPPZ/CsZ1Z+8A/I4q 28UOct4HbwtEgLDDEX2z7LyoEMDzaGu5N9DK622bLclAZ4bVDv+HiTRUoxAQlWkkbJK1 87OX0dz9JMNeGxsN2fHToGjnuxU52PePlhVLfAWVEHeoQghcfdTaZK7RCVXhdvpbr+7E zJIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rPkBSkJc; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id by8si4014839edb.354.2020.06.19.08.23.54; Fri, 19 Jun 2020 08:23:54 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=rPkBSkJc; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393227AbgFSPXx (ORCPT + 15 others); Fri, 19 Jun 2020 11:23:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:55410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393220AbgFSPXt (ORCPT ); Fri, 19 Jun 2020 11:23:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2CFEC21841; Fri, 19 Jun 2020 15:23:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592580228; bh=65ENYAQRWakhPRgaNzD0irL6QZnR+Xw7OGN49opy4QQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rPkBSkJcK82SO7NmDmqMVfgHv/Er/I0hk04subWMwRNtWqbRnt0ple/ipwDYhagRK D/l4eLDxhQj1ppBotKpqFGQE3AwVllatlO82GCyLSrGArk4zKBh9nGYTso5wBEXAh6 FWI6kmzsan5WD11/EpBsnf7OZv4RUml6ZOErawQE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Christoph Hellwig , Jens Axboe , Sasha Levin Subject: [PATCH 5.7 170/376] nvme-fc: avoid gcc-10 zero-length-bounds warning Date: Fri, 19 Jun 2020 16:31:28 +0200 Message-Id: <20200619141718.369565553@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141710.350494719@linuxfoundation.org> References: <20200619141710.350494719@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 3add1d93d9919b6de94aa47900d4904adffbc976 ] When CONFIG_ARCH_NO_SG_CHAIN is set, op->sgl[0] cannot be dereferenced, as gcc-10 now points out: drivers/nvme/host/fc.c: In function 'nvme_fc_init_request': drivers/nvme/host/fc.c:1774:29: warning: array subscript 0 is outside the bounds of an interior zero-length array 'struct scatterlist[0]' [-Wzero-length-bounds] 1774 | op->op.fcp_req.first_sgl = &op->sgl[0]; | ^~~~~~~~~~~ drivers/nvme/host/fc.c:98:21: note: while referencing 'sgl' 98 | struct scatterlist sgl[NVME_INLINE_SG_CNT]; | ^~~ I don't know if this is a legitimate warning or a false-positive. If this is just a false alarm, the warning is easily suppressed by interpreting the array as a pointer. Fixes: b1ae1a238900 ("nvme-fc: Avoid preallocating big SGL for data") Signed-off-by: Arnd Bergmann Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/nvme/host/fc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c index 7dfc4a2ecf1e..5ef4a84c442a 100644 --- a/drivers/nvme/host/fc.c +++ b/drivers/nvme/host/fc.c @@ -1771,7 +1771,7 @@ nvme_fc_init_request(struct blk_mq_tag_set *set, struct request *rq, res = __nvme_fc_init_request(ctrl, queue, &op->op, rq, queue->rqcnt++); if (res) return res; - op->op.fcp_req.first_sgl = &op->sgl[0]; + op->op.fcp_req.first_sgl = op->sgl; op->op.fcp_req.private = &op->priv[0]; nvme_req(rq)->ctrl = &ctrl->ctrl; return res;