From patchwork Tue Jun 23 19:58:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191575 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1348526ecs; Tue, 23 Jun 2020 13:54:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxPMPBKU8H57EorVPlEdGSIke8mO+BG3UNjVdxAIei/9bq2KSiRh8GiL5MKzhY0FE+y/m9J X-Received: by 2002:a05:6402:1b01:: with SMTP id by1mr23509221edb.20.1592945687337; Tue, 23 Jun 2020 13:54:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592945687; cv=none; d=google.com; s=arc-20160816; b=NIWooIBBNOMGYHbNT5wPPgfiF7ZYCZrJ7IcBPI2+e3KPDQdDupzMjeIhqDbBELJt1s zuEIWhLOKjhkYsopOyysJL6kpyI4uLnrMpNWhXcR/xzm34uLX8XZWYdXMHzZxVvbC78k t4s34FqUhyrrt4T3slRnc5ANlA1qhI97iql7JsTdIoRba6/G7tRe8UkHMFLP7jsQsdqW wpoMjlCRyuZn382jSiLZIBxuZ7kVabUT00F2nbqEm4FZHL60BobrJGoH0QDYyGEy2HBC zLLlVEAh+PuXRwYYYs9r8sMarxb5WRtZj/ZwX4ev4IuQxRL5SdzQ/P3OO9NpBvq8WxM8 OMJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5PEtt4cAIsd37+QpPcZQpUVowvr6wXAp7e9awd1eik8=; b=ksU6DJUewN0BFWIWkRqqF+41y4e9J+Y8d6z0h0fnbnKYADgZAp/KPOv2oCoKfCIuyO yeVklkSXKnJbIWAeaiNqyf0YnmgzvXIHe65ma1IaiyGFek/y2nxHZVm1Do3uoPLFxUL9 fNsZ1b4HQNeVRAC7SIuczPSOgUNv5l+21G7s0kh455vS4MJ9EI6GFRDwhTfs6GsZgTy0 ULjjvGGS7FkinBbh2zIepDJKRvB5RTXrQ7jZiATY+eGdwPO8g2aMQd4H8j30a3QH62Gl X+DY2ba3opR8UDrAXIpu10i4q9XOUhWmBwisu1N0oEwvcwUtL5e5IM2RvLVbQcCDu/p/ Kvlg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GbytVoX+; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si6290491ejy.58.2020.06.23.13.54.47; Tue, 23 Jun 2020 13:54:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=GbytVoX+; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392394AbgFWUyp (ORCPT + 15 others); Tue, 23 Jun 2020 16:54:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:43230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392651AbgFWUpi (ORCPT ); Tue, 23 Jun 2020 16:45:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B386E20781; Tue, 23 Jun 2020 20:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945139; bh=gXMGaPjzCQIeju5Hb/u1hZJDt2Bem+pqUM5c4cI8O0o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GbytVoX+08OuO4ftjWpVNLgS5MhQruSwQYRVnmWEbjqoAIWp18jVEwUMwlOaJeYel qI6KqIC+3G4aGfxzhnvv4Z6qDQWyTkiUp3snNl17KmJ25FmKZ3vR+YHEgwNwc5Cu2C xvVMq2U+RoQHYBqljzN9lwCtAkSobxr6umMocB3Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Tero Kristo , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.14 054/136] clk: ti: composite: fix memory leak Date: Tue, 23 Jun 2020 21:58:30 +0200 Message-Id: <20200623195306.396249218@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tero Kristo [ Upstream commit c7c1cbbc9217ebb5601b88d138d4a5358548de9d ] The parent_names is never released for a component clock definition, causing some memory leak. Fix by releasing it once it is no longer needed. Reported-by: Tomi Valkeinen Signed-off-by: Tero Kristo Link: https://lkml.kernel.org/r/20200429131341.4697-2-t-kristo@ti.com Acked-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/composite.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/clk/ti/composite.c b/drivers/clk/ti/composite.c index beea89463ca2c..4ea5c08a1eb66 100644 --- a/drivers/clk/ti/composite.c +++ b/drivers/clk/ti/composite.c @@ -240,6 +240,7 @@ cleanup: if (!cclk->comp_clks[i]) continue; list_del(&cclk->comp_clks[i]->link); + kfree(cclk->comp_clks[i]->parent_names); kfree(cclk->comp_clks[i]); }