From patchwork Tue Jun 23 19:50:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191628 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1377586ecs; Tue, 23 Jun 2020 14:44:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyEn+u5nn0mmBwuaA/5BuVdmHwLxeKBqLPER86VaYvkFq2NG259+awB9SMo43KhsSDusM6N X-Received: by 2002:a17:906:c30b:: with SMTP id s11mr3932658ejz.263.1592948657798; Tue, 23 Jun 2020 14:44:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592948657; cv=none; d=google.com; s=arc-20160816; b=KDhz9n3gDCRiMHaCc+sJBHELMJr592uNMDDYDH0SSTiy5+bC3WKC8fOdac5mcYzpHh w2UGzS7SRPnB7fmPgr5GNuVrc3j9rYcaTVf4iturnVOCJFWSsMy0TKi4UMvMOyRwUpS2 SReDWkkKOjR5xJFtcOirBxwqcVYFfcAqWMUgXnEpcsWNV7JoC3ORKvfqk+M3LRxL3c7Y qaQaIOU9SJogSzPLG4vMeJjP39hOCz5eaaYNpfl194+CdrdaRflujISCKv4ky+/JN2NR ojAAFL1/H48A0UgbNqwxfG0xDzy/cC8dbKb8kTEgQjo3rxfO388+xuM9MuTXVY7Ny07u 7I0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w+Yrq6p1G5KOhx0ob5psDiFcsVvKAo3mXoNd1A06OeI=; b=0sAJB+r4G+C2oU6GURVSSzImKRJN9R8r81tjOOrf591UDYgYZPHQNOf12DyxSkrVjW cbLINMk1F1poy34ygWvWYTuWC+HtG8D19rrvmbKhc+kWNVgSZ2oC2EJsjAjlCMecRbql yIiToPZz3Wiv20ZKiQhZa3tqgUgBWRGJHsdbB/lOAwHs6iXGbeYLt5SLIOglqQ92iXZU UmYWGQYoKxtDdcc/rxjDyV4paYuOe16XNaEt/+wratFuUqnmcd96sz+tKLOj3Pw+3/RT CmSolAcQ1NlgkmSNFv9gh1PuJmmNkyFj57/KC2lhB2F9mihlQadr4/efwSFNFd1tP6vX moyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Y/cjwCf1"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h2si11392607ejp.405.2020.06.23.14.44.17; Tue, 23 Jun 2020 14:44:17 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Y/cjwCf1"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387869AbgFWUCh (ORCPT + 15 others); Tue, 23 Jun 2020 16:02:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:39882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387826AbgFWUCe (ORCPT ); Tue, 23 Jun 2020 16:02:34 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0618E20E65; Tue, 23 Jun 2020 20:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592942553; bh=doYIYC1XTHjd9FMy2qF65QBoTFvrKESJox7WLeKKOXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y/cjwCf1Qj5j1IxaJouWRlRf8RaeusGD/95Vd4TMyvBQGXCoiMx2WOLQwCIeNvrPd ww+2zht2XA55XPkPdxmtfvRvyMnGAHfXQfvrL5whD3tbEP4bRK/owlnqIRc1K/wNEX EjXhTSb1R52S8vFKMiuVelL/V3bb37pINm2db6w0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.7 044/477] misc: fastrpc: Fix an incomplete memory release in fastrpc_rpmsg_probe() Date: Tue, 23 Jun 2020 21:50:41 +0200 Message-Id: <20200623195409.688974397@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit 0978de9fc7335c73934ab8fac189fb4cb3f23191 ] fastrpc_channel_ctx is not freed if misc_register() fails, this would lead to a memory leak. Fix this leak by adding kfree in misc_register() error path. Fixes: 278d56f970ae ("misc: fastrpc: Reference count channel context") Signed-off-by: Srinivas Kandagatla Reviewed-by: Bjorn Andersson Link: https://lore.kernel.org/r/20200511162722.2552-1-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/fastrpc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index e3e085e33d46b..9065d3e71ff76 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1613,8 +1613,10 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) domains[domain_id]); data->miscdev.fops = &fastrpc_fops; err = misc_register(&data->miscdev); - if (err) + if (err) { + kfree(data); return err; + } kref_init(&data->refcount);