From patchwork Wed Jun 24 15:07:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191688 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp677316ile; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyW/leNrrcC+wfHgSYnip4OCEq17/dp0RgmBICsYWU3/j9hMZIb5QWZfu9jVcawukhc9gT X-Received: by 2002:a05:6402:642:: with SMTP id u2mr27059951edx.230.1593011267479; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011267; cv=none; d=google.com; s=arc-20160816; b=o+fiQ6iuQhdArQj2DXSLlCxsHTstQzeSIQETwjlV1IRLmD18PC3ldF3vsmqPxGahy0 +nLhKtPvYS+ljrgzdXYCEh2upKd4i240BWHiLtjzeZjhD+cFqhoKebblEiVgMMMP8JEv Lmz7yZqmLXHaU+/ozjK2UmW6bZr/QT8PHWgfN35P4pxVV5AOsivTrpNC3LAJO87Dbmm1 PE+g6dadnIzIsszgFReGMB7iheok/XRbEg/gjHldsqEBWKRl2bdoUTnOhX9F4IqCCDhp ywQnr7xIrL3xBKYb4hC+rc7aTaGviebMWOhDBCblch9AC58UunrCPQSQZPRgkM1C9wFg 9Qqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=dRtVYk13c4HKHT6I6peiG5PkJ+s3rqy5hvZi+pF/DirEeyiVAeCC/OwQydQPEjTEQL 69VhHCI51lAr///tTDvysDhpELnmSKISViO9PgY/TtYx4aD3UqUGFoG6cHqco678Wr9f PPkg5wI/ctiCyEjHoj91hOwwfEskHbOUF4ls+3WBV/RFlfvNsDV6F/6B7YEXBruZbFdV 4eUzcvnur9BfFMkhEdM78vQ7+MRDAbh4kX/BWIj0E31FspHquWVpo8J4bcxADrAJ+PZH cpnVvAzSOVbRFHKqivFaUVMmcqtA3C7OMfqagR7f2VEb/2Hwlt1wDayFyTnxy0W8znt4 pahA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ff5473UI; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si12817081ejd.191.2020.06.24.08.07.47; Wed, 24 Jun 2020 08:07:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ff5473UI; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404408AbgFXPHm (ORCPT + 15 others); Wed, 24 Jun 2020 11:07:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404199AbgFXPHU (ORCPT ); Wed, 24 Jun 2020 11:07:20 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87F6AC061796 for ; Wed, 24 Jun 2020 08:07:20 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id j4so156720wrp.10 for ; Wed, 24 Jun 2020 08:07:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=Ff5473UIxYPsdW4pi6CB5QPFSge/HWs1GPIn1OasdcMvQPjvlEK+g8lSeufiA1UwKm H6KDcmB3IgwAsPz//203sr/5lItNIy2VU8gLEnAju1bDpqSAA+snoMXXBbUKVTtwRhw+ iYvztLUTfNwIJqWObVgXcpCcC997bPMIODvu8fKaIJsBfDZOWCccn9tKIqHndpm41ykY Mq5NnAMV9jctWKT/2bpdtVs0PMXEScf5SNuIIaSmmhtv+vlqdMu/JvyKU4itIlO1CcGf tVbYtwzeO0StF89eiamELfZGSFWzF039y0cQjpkDunjzUqt5nyJcW9aNz0PxKD3gXnrL vAgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ka6N3pIS5SMpHS3Dkd8MuBcyOJ38IwtNTJ67x9HE/gM=; b=drfEJlYizXB7Z5ahGuBRlzaEefSPprf47B47suvBQc5ipI1mWqpXJ2XB9H20AiXdEl ShGsOM28r9Y81RmKhHFvEX5Y6rxFIhwkXu2fncpl+2fIc85Q8Tnjv9HaVccq+6Nxivx8 G06eA7KWHDXGOmW6Vb17AmZKgKa7Ol62VMHGzbJ89D7sxv1vj+56NWiXJvm5hSHgRa7A IIaBLGdJCFTCAEAxf2XESfXny3KmRq2/bIsFQrltpJ41lBFmeon5m74wylJco4wwsP4W 7eIAlTIgOKFPkDpCmFIUWWRFCuUbNcpPJ4/NsXvf2J1c1vgoyk64x5Sa6Xzqa1RILoEr 4bQA== X-Gm-Message-State: AOAM5339YHf9rdFhbNpn7PzvZ+bOeuIM3BV/DRZN4MPgYICPgRxR58cy Fel05A36YXsxMjae73QbvxAJ+l4+2qQ= X-Received: by 2002:a5d:6749:: with SMTP id l9mr31134388wrw.63.1593011239284; Wed, 24 Jun 2020 08:07:19 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id h14sm11543361wrt.36.2020.06.24.08.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:07:18 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Linus Walleij Subject: [PATCH 06/10] mfd: ab3100-core: Fix incompatible types in comparison expression warning Date: Wed, 24 Jun 2020 16:07:00 +0100 Message-Id: <20200624150704.2729736-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624150704.2729736-1-lee.jones@linaro.org> References: <20200624150704.2729736-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Smatch reports: drivers/mfd/ab3100-core.c:501:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab3100-core.c:501:20: unsigned int * drivers/mfd/ab3100-core.c:501:20: unsigned long * drivers/mfd/ab8500-debugfs.c:1804:20: error: incompatible types in comparison expression (different type sizes): drivers/mfd/ab8500-debugfs.c:1804:20: unsigned int * drivers/mfd/ab8500-debugfs.c:1804:20: unsigned long * Since the second min() argument can be less than 0 a signed variable is required for assignment. However, the non-sized type size_t is passed in from the userspace handlers. In order to firstly compare, then assign the smallest value, we firstly need to cast them both to the same as the receiving size_t typed variable. Cc: Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab3100-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 Reviewed-by: Linus Walleij diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c index 57723f116bb58..ee71ae04b5e63 100644 --- a/drivers/mfd/ab3100-core.c +++ b/drivers/mfd/ab3100-core.c @@ -498,7 +498,7 @@ static ssize_t ab3100_get_set_reg(struct file *file, int i = 0; /* Get userspace string and assure termination */ - buf_size = min(count, (sizeof(buf)-1)); + buf_size = min((ssize_t)count, (ssize_t)(sizeof(buf)-1)); if (copy_from_user(buf, user_buf, buf_size)) return -EFAULT; buf[buf_size] = 0;