From patchwork Tue Oct 27 13:49:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 313066 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019B2C63697 for ; Tue, 27 Oct 2020 14:06:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF20C22403 for ; Tue, 27 Oct 2020 14:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807603; bh=5aco8oy2BYD1OxtNSCSojJo7ns14PJmvsSfDuwe65NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ltN3nOmnPYyYxSqaLvREr0bLNLOAkygnNtTh4RMXKQVKmym8aHfVnQAdo8aqFXokE IUDEXQcdA4Pmk1z8gL2NTWkvxFVrJks41muoe61Cl7aRcKgUiPzsNvnyVrdgNZ0DNA VmqDCaRsA9NYGpCKOSZmBkL52Q/nC2jyQHgZA0ms= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504809AbgJ0OEb (ORCPT ); Tue, 27 Oct 2020 10:04:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:52780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2409635AbgJ0OE2 (ORCPT ); Tue, 27 Oct 2020 10:04:28 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CAD0C22264; Tue, 27 Oct 2020 14:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603807468; bh=5aco8oy2BYD1OxtNSCSojJo7ns14PJmvsSfDuwe65NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TWFl0Erp7uWavGW6uzzRJ/J1Ya1Jy+kpXkVQrUczM8UPY5WjbLvwShww43/pZm/jq AcC6un3enJb7bdLigZcI/aXEqO7bJ75HbS8ofBRnkJkR1qDynKzBAzDDujpMWkmrk5 0o9LPraB8ToFBd5fvEzNFgs4g5tpxDNRKjf+PQ38= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michal Kalderon , Jason Gunthorpe , Sasha Levin Subject: [PATCH 4.9 063/139] RDMA/qedr: Fix use of uninitialized field Date: Tue, 27 Oct 2020 14:49:17 +0100 Message-Id: <20201027134905.109080368@linuxfoundation.org> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201027134902.130312227@linuxfoundation.org> References: <20201027134902.130312227@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Michal Kalderon [ Upstream commit a379ad54e55a12618cae7f6333fd1b3071de9606 ] dev->attr.page_size_caps was used uninitialized when setting device attributes Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init") Link: https://lore.kernel.org/r/20200902165741.8355-4-michal.kalderon@marvell.com Signed-off-by: Michal Kalderon Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/qedr/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c index f937873e93dfc..b95f1457c407d 100644 --- a/drivers/infiniband/hw/qedr/main.c +++ b/drivers/infiniband/hw/qedr/main.c @@ -527,7 +527,7 @@ static int qedr_set_device_attr(struct qedr_dev *dev) qed_attr = dev->ops->rdma_query_device(dev->rdma_ctx); /* Part 2 - check capabilities */ - page_size = ~dev->attr.page_size_caps + 1; + page_size = ~qed_attr->page_size_caps + 1; if (page_size > PAGE_SIZE) { DP_ERR(dev, "Kernel PAGE_SIZE is %ld which is smaller than minimum page size (%d) required by qedr\n",