From patchwork Mon Nov 9 12:55:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 322630 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1207C388F7 for ; Mon, 9 Nov 2020 13:34:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7368B2067B for ; Mon, 9 Nov 2020 13:34:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604928859; bh=j6bCoaNE1qOxcaAdaphhyk4Ayzv5g6dyD4DCbCvBu2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NgJPZCw1axvc3Yfsp8jUG668MBV/7oQrJHof0aUQM28Cw+kNhT7cXiMWwQznZBD/s rENjBoG5zmIkglrSkesVxN2RQz/qjlypURVExrU/SimYK3J2YDQSO6qMtOjogiUxVF Ccs5mEZilrbP7qI6U1nWVCCiY0jQCt0YDMsUrJrk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730996AbgKINeQ (ORCPT ); Mon, 9 Nov 2020 08:34:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:58704 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730947AbgKINFw (ORCPT ); Mon, 9 Nov 2020 08:05:52 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2767820789; Mon, 9 Nov 2020 13:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604927151; bh=j6bCoaNE1qOxcaAdaphhyk4Ayzv5g6dyD4DCbCvBu2s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oqeSVjE+CEdmQbt/+AoecOXFa28CNQm9T0oaFqF/yNlrfoXRRW8ProF5KuraopVIC JltG16sPbpf6m9tF9Xo3Q9FSA8VJk8V2Xbxs1pX6hoTu2BzglQUy/ri3AgcLvRd0QN QDlsG1aC7xlBoeB+DIbwCJYlitXM67n1d/8WWSWQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andrew Bowers , Jeff Kirsher , Ben Hutchings Subject: [PATCH 4.14 11/48] i40e: Fix a potential NULL pointer dereference Date: Mon, 9 Nov 2020 13:55:20 +0100 Message-Id: <20201109125017.295641477@linuxfoundation.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201109125016.734107741@linuxfoundation.org> References: <20201109125016.734107741@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Christophe JAILLET commit 54902349ee95045b67e2f0c39b75f5418540064b upstream. If 'kzalloc()' fails, a NULL pointer will be dereferenced. Return an error code (-ENOMEM) instead. Signed-off-by: Christophe JAILLET Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c @@ -423,6 +423,9 @@ static int i40e_config_iwarp_qvlist(stru (sizeof(struct virtchnl_iwarp_qv_info) * (qvlist_info->num_vectors - 1)); vf->qvlist_info = kzalloc(size, GFP_KERNEL); + if (!vf->qvlist_info) + return -ENOMEM; + vf->qvlist_info->num_vectors = qvlist_info->num_vectors; msix_vf = pf->hw.func_caps.num_msix_vectors_vf;