From patchwork Mon Apr 12 08:39:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 419508 Delivered-To: patch@linaro.org Received: by 2002:a02:c4d2:0:0:0:0:0 with SMTP id h18csp1554899jaj; Mon, 12 Apr 2021 01:47:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHoAO3caL2u0ef7v4Y8ZfFJQOAphnOx0PIoKSTkQJG3TRivlagGKMvxyYTutUmAIu7JLTU X-Received: by 2002:a63:30c1:: with SMTP id w184mr25259629pgw.230.1618217223339; Mon, 12 Apr 2021 01:47:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618217223; cv=none; d=google.com; s=arc-20160816; b=kKEsYQ4Bc1bPdXZt7GgrIA8Q0MCtKRyMfM+s7tnkNhAPmSJRjF964eVV8MXO0Pzla5 aMSlfNLH4gwB6mVPijd5WUDgS8tlyh2dmhavLDCPGjOFLOu7DX4KONFDDa38idqnoQGq jVmqsAkUllQQZ5izd/mXp0uE5DYvOB3UiCiRO/d72wlsLJye6T0OR11TEnoEEyREo4Hz m/GFBzToCItExfEp+4NtB+ji76joQ35LS6hGO+UWx5tu0Kknn8Qa3rzaFUVj37ccp8Vf AhKInre5gEi1mid53KSqM6Ic5s7AKpDIXlTjb9owoPu23egTUrs19EBHs4UvdWA4ZU90 KGqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+0QiRoj3fUSNJh0WGs7h6WbiBP6sFh0lb1XbICR1IiM=; b=x7NPI00dG5vM3NGDt+E2KSsEjbYJsIn6wAOEihud0/Q6qOyDhcuPxTrNvWrPu7/eEZ eoRQjHGR7cI3O2jXuYW8wMoFEbnbu63Ig6eds4nzr7J24M69ukmiUPKn9JVhSyyaef+A uCuL/WFD9HlGj6sTT0rGt18phRdhKDRdt7KSKBLNQpwEQqgdgfsQsYqLaIjyFo/IRg/h yD9eBtj4RbHRn+dwlgdSsb9TaV/D7mvT5q2igs7Qxmmvs1c4DD924UaZ15oUtZxEGAVg 5c4CH01F4JCdhGYNGFvjSLkQOsR0LrT5BmJfSbvikwdcc2xenKnC18YxMtsK7s+DvjXg vR8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kLpopw4s; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si12940712plq.105.2021.04.12.01.47.03; Mon, 12 Apr 2021 01:47:03 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=kLpopw4s; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238037AbhDLIrS (ORCPT + 12 others); Mon, 12 Apr 2021 04:47:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:39316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237920AbhDLIqc (ORCPT ); Mon, 12 Apr 2021 04:46:32 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C897661261; Mon, 12 Apr 2021 08:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618217174; bh=kO2E0vSvri/q/aGGjNFCKIdR/saloXrxctn9XBnpA9c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kLpopw4sv4nbHPWPpGLekJzGOygnKwOtu6ADP7Evh3HuWMNto05JPUashOkBX3KNq 36SRvnlNmJugEcE5eiIGHO9c8A4NgYkDy3t/Rg2dr8h+P0vzQH632Z52T1eu2Tf4Tq ILVhUYQK2wR7oYBQQ+TVu9FsEsT5xL4GTKkqhKHE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Prasad Sodagudi , Nick Desaulniers , Nathan Chancellor , Andrew Morton , Linus Torvalds Subject: [PATCH 5.4 013/111] gcov: re-fix clang-11+ support Date: Mon, 12 Apr 2021 10:39:51 +0200 Message-Id: <20210412084004.658480415@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210412084004.200986670@linuxfoundation.org> References: <20210412084004.200986670@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Nick Desaulniers commit 9562fd132985ea9185388a112e50f2a51557827d upstream. LLVM changed the expected function signature for llvm_gcda_emit_function() in the clang-11 release. Users of clang-11 or newer may have noticed their kernels producing invalid coverage information: $ llvm-cov gcov -a -c -u -f -b .gcda -- gcno=.gcno 1 : checksum mismatch, \ (, ) != (, ) 2 Invalid .gcda File! ... Fix up the function signatures so calling this function interprets its parameters correctly and computes the correct cfg checksum. In particular, in clang-11, the additional checksum is no longer optional. Link: https://reviews.llvm.org/rG25544ce2df0daa4304c07e64b9c8b0f7df60c11d Link: https://lkml.kernel.org/r/20210408184631.1156669-1-ndesaulniers@google.com Reported-by: Prasad Sodagudi Tested-by: Prasad Sodagudi Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor Cc: [5.4+] Signed-off-by: Greg Kroah-Hartman Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- kernel/gcov/clang.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) --- a/kernel/gcov/clang.c +++ b/kernel/gcov/clang.c @@ -70,7 +70,9 @@ struct gcov_fn_info { u32 ident; u32 checksum; +#if CONFIG_CLANG_VERSION < 110000 u8 use_extra_checksum; +#endif u32 cfg_checksum; u32 num_counters; @@ -145,10 +147,8 @@ void llvm_gcda_emit_function(u32 ident, list_add_tail(&info->head, ¤t_info->functions); } -EXPORT_SYMBOL(llvm_gcda_emit_function); #else -void llvm_gcda_emit_function(u32 ident, u32 func_checksum, - u8 use_extra_checksum, u32 cfg_checksum) +void llvm_gcda_emit_function(u32 ident, u32 func_checksum, u32 cfg_checksum) { struct gcov_fn_info *info = kzalloc(sizeof(*info), GFP_KERNEL); @@ -158,12 +158,11 @@ void llvm_gcda_emit_function(u32 ident, INIT_LIST_HEAD(&info->head); info->ident = ident; info->checksum = func_checksum; - info->use_extra_checksum = use_extra_checksum; info->cfg_checksum = cfg_checksum; list_add_tail(&info->head, ¤t_info->functions); } -EXPORT_SYMBOL(llvm_gcda_emit_function); #endif +EXPORT_SYMBOL(llvm_gcda_emit_function); void llvm_gcda_emit_arcs(u32 num_counters, u64 *counters) { @@ -293,11 +292,16 @@ int gcov_info_is_compatible(struct gcov_ !list_is_last(&fn_ptr2->head, &info2->functions)) { if (fn_ptr1->checksum != fn_ptr2->checksum) return false; +#if CONFIG_CLANG_VERSION < 110000 if (fn_ptr1->use_extra_checksum != fn_ptr2->use_extra_checksum) return false; if (fn_ptr1->use_extra_checksum && fn_ptr1->cfg_checksum != fn_ptr2->cfg_checksum) return false; +#else + if (fn_ptr1->cfg_checksum != fn_ptr2->cfg_checksum) + return false; +#endif fn_ptr1 = list_next_entry(fn_ptr1, head); fn_ptr2 = list_next_entry(fn_ptr2, head); } @@ -529,17 +533,22 @@ static size_t convert_to_gcda(char *buff list_for_each_entry(fi_ptr, &info->functions, head) { u32 i; - u32 len = 2; - - if (fi_ptr->use_extra_checksum) - len++; pos += store_gcov_u32(buffer, pos, GCOV_TAG_FUNCTION); - pos += store_gcov_u32(buffer, pos, len); +#if CONFIG_CLANG_VERSION < 110000 + pos += store_gcov_u32(buffer, pos, + fi_ptr->use_extra_checksum ? 3 : 2); +#else + pos += store_gcov_u32(buffer, pos, 3); +#endif pos += store_gcov_u32(buffer, pos, fi_ptr->ident); pos += store_gcov_u32(buffer, pos, fi_ptr->checksum); +#if CONFIG_CLANG_VERSION < 110000 if (fi_ptr->use_extra_checksum) pos += store_gcov_u32(buffer, pos, fi_ptr->cfg_checksum); +#else + pos += store_gcov_u32(buffer, pos, fi_ptr->cfg_checksum); +#endif pos += store_gcov_u32(buffer, pos, GCOV_TAG_COUNTER_BASE); pos += store_gcov_u32(buffer, pos, fi_ptr->num_counters * 2);