From patchwork Thu Apr 15 14:47:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 421790 Delivered-To: patch@linaro.org Received: by 2002:a02:6a6f:0:0:0:0:0 with SMTP id m47csp554934jaf; Thu, 15 Apr 2021 08:02:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHWfJYqik0w3qbOf8TydhsP43/LswMTcDHozvA32NbDsCTbSuQ4+1fkn4wVWqBY0NzXzkO X-Received: by 2002:a17:90a:7e03:: with SMTP id i3mr4356538pjl.234.1618498968413; Thu, 15 Apr 2021 08:02:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1618498968; cv=none; d=google.com; s=arc-20160816; b=eeKXLn0eMMRZFARHRxFLKEdrVFrQlyI3WLBPsv96j8kTAq2JAjiUqlfdZUIm+8+YYc NK76wyM9abrh9mCcz85B5a1y/VplKYFtrOhaqp8FZjHleE2qAvtK2RABcHOiM2KeSt47 0j6vY8dio/KlCqpngObZpeg65JgMJ/jseeA9dyfCE8kGQrnanLKdQxIzWU/s1jDm9yIE 5fBEGPBpK2rwoUsz9lPol77iMMh+PHpVVb7VEbrTUmDLo6o3/Mz7onmTg0RXNrTWcQmX vBnJd0aBwpkj20Ize+AlBqrbwpXRdTGrlav2atuTKiKE4pLOTyjiXNAmxbDJiEiDuiB9 xjEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NkPuNmV7YSe3n15YEx7ukaZX59CqnEvgTT1VJHBKf4s=; b=SGHmnpzaT7jjxsaaVPQ62iq07Toi7m8ceXppGyKBDxHYNVwiW9IWoo5Xl+jDJe7W4v UZ8IdUl0MVFEq0c9tljUrTolg76FHse6StcRFV912Qhy8BR3MOEEW+OlCAz97HkoITQC WY0DC8YHqkbQS74f8BNY8R7Y3OO5Qp/049L4+hCsu2tfsDJf0cXBmGM3lwzOxVX/IudF UxcGJtq6S62vH04QLTD4jL1cEnb36mEt1VsNHJGGEd7GcyeICf+yXBFScY4yFJmXixpT k5R67QntSizVTCR9q2JnAXuV2WnHg3wraqFo9DO4ZuEEWS18pfLazKmm7Q8kmgV9HTIh BefA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VB1rF8qL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gc4si3443688pjb.46.2021.04.15.08.02.48; Thu, 15 Apr 2021 08:02:48 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VB1rF8qL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233775AbhDOPDD (ORCPT + 12 others); Thu, 15 Apr 2021 11:03:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:45910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235118AbhDOPAX (ORCPT ); Thu, 15 Apr 2021 11:00:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E72A561411; Thu, 15 Apr 2021 14:56:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1618498585; bh=rXcocIxf7KQVMKaPU8Y9qfB8X7sLiBezInsSrh7HPL8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VB1rF8qLaTwrcXTP7+IOuCiMqhqAp6dPfHim4gTGj/n3iO3zTZi3TkWmFY7T9BUEa +qTi1KwoTvCduIbMOT6ujeEv0aUmS48Nh1owFr4C7ZnlINBr9bS8JFARuRFxiX3lcB 3DhCYu+gaWPVFUeIBGKG/bF9C/KE278JgXjkEpRE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marc Zyngier , Will Deacon , Mark Rutland , Catalin Marinas , Suzuki K Poulose , Sasha Levin Subject: [PATCH 5.4 03/18] KVM: arm64: Disable guest access to trace filter controls Date: Thu, 15 Apr 2021 16:47:56 +0200 Message-Id: <20210415144413.162746201@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210415144413.055232956@linuxfoundation.org> References: <20210415144413.055232956@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Suzuki K Poulose [ Upstream commit a354a64d91eec3e0f8ef0eed575b480fd75b999c ] Disable guest access to the Trace Filter control registers. We do not advertise the Trace filter feature to the guest (ID_AA64DFR0_EL1: TRACE_FILT is cleared) already, but the guest can still access the TRFCR_EL1 unless we trap it. This will also make sure that the guest cannot fiddle with the filtering controls set by a nvhe host. Cc: Marc Zyngier Cc: Will Deacon Cc: Mark Rutland Cc: Catalin Marinas Signed-off-by: Suzuki K Poulose Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20210323120647.454211-3-suzuki.poulose@arm.com Signed-off-by: Sasha Levin --- arch/arm64/include/asm/kvm_arm.h | 1 + arch/arm64/kvm/debug.c | 2 ++ 2 files changed, 3 insertions(+) -- 2.30.2 diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h index a4ffd9b55e72..9be64c0ad31f 100644 --- a/arch/arm64/include/asm/kvm_arm.h +++ b/arch/arm64/include/asm/kvm_arm.h @@ -276,6 +276,7 @@ #define CPTR_EL2_DEFAULT CPTR_EL2_RES1 /* Hyp Debug Configuration Register bits */ +#define MDCR_EL2_TTRF (1 << 19) #define MDCR_EL2_TPMS (1 << 14) #define MDCR_EL2_E2PB_MASK (UL(0x3)) #define MDCR_EL2_E2PB_SHIFT (UL(12)) diff --git a/arch/arm64/kvm/debug.c b/arch/arm64/kvm/debug.c index 7a7e425616b5..dbc890511631 100644 --- a/arch/arm64/kvm/debug.c +++ b/arch/arm64/kvm/debug.c @@ -89,6 +89,7 @@ void kvm_arm_reset_debug_ptr(struct kvm_vcpu *vcpu) * - Debug ROM Address (MDCR_EL2_TDRA) * - OS related registers (MDCR_EL2_TDOSA) * - Statistical profiler (MDCR_EL2_TPMS/MDCR_EL2_E2PB) + * - Self-hosted Trace Filter controls (MDCR_EL2_TTRF) * * Additionally, KVM only traps guest accesses to the debug registers if * the guest is not actively using them (see the KVM_ARM64_DEBUG_DIRTY @@ -112,6 +113,7 @@ void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) vcpu->arch.mdcr_el2 = __this_cpu_read(mdcr_el2) & MDCR_EL2_HPMN_MASK; vcpu->arch.mdcr_el2 |= (MDCR_EL2_TPM | MDCR_EL2_TPMS | + MDCR_EL2_TTRF | MDCR_EL2_TPMCR | MDCR_EL2_TDRA | MDCR_EL2_TDOSA);