From patchwork Tue Jun 8 18:27:00 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 455817 Delivered-To: patch@linaro.org Received: by 2002:a02:735a:0:0:0:0:0 with SMTP id a26csp4021499jae; Tue, 8 Jun 2021 12:00:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1cam4xN1nZtALFPAiB9AB+iLfN858NTLslU3iVuR+QEVpgT5oYhDSn0ePMzRdCqZJK8eG X-Received: by 2002:a05:6402:3585:: with SMTP id y5mr27110272edc.121.1623178847878; Tue, 08 Jun 2021 12:00:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623178847; cv=none; d=google.com; s=arc-20160816; b=Rwhuiklmrgt0G58zu8LtTdK8pj+Xw/Oych94i//jY4WYkQbEF5HO/o2uH2ISXlTlVE nF0cZ3BqPmE/TEr9IldRq6VZzlZFz8BWqjxdVtR1awmKS8/CGtTdI2E/kYqiKo0BFAbD aGdBKOYzBAxoWLCT7TUHQuBkNjRyoWI9jeiEDNSILhpDh9gLFdQk/7VWEuLe/SaiyRP4 vaIsiJrr8t+1CySD9L7KlKUnkD6NXEZQ7nwIfvxrAS2t4oXikPM+vKtHaADPutbSSWAU X5jSVqJDVIKYzEZWudhovxeVKS/UiOaFvX0zrqblZ7QWJat9trppcrGz1znjhNgLO9Mq ScxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Lppqu2tYg+juwz1bl6AFBu0iOdoN70dBcJZGA7POgkM=; b=AMsBxprW5v/eTcSQ2cCv0a7lSotLYn+bHE1BNBItG3sTSSeR5Mnz79dZv2AYvDUk4K rvo7VVxXHxrr5CG++LWzhcpM9Ea6+L9ouRMp0EHK/hyabvwQjsjoMzAxeM/sm74Jtf55 58uj0++lk6UMg/lJaDz5XL8rb2Nx0l79RaYKrooP9lMU7EgxnzbXMjRblGM/WhfSqJgU qdtlSWtYC8+0RnkV0HLeG44gk4uHQKV1NJgExDcPN+0xuabZCQM7kFN3e9DI4FxdHDfP bSFsU77OjPBHlMmI/IM8LnqBf26lEgEWar0M0TEHTYRQ5T6w0cM7cb3HDmjbTuWZLS4K tdsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G+RKU2Ch; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e3si288626ejm.412.2021.06.08.12.00.47; Tue, 08 Jun 2021 12:00:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=G+RKU2Ch; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235801AbhFHTCh (ORCPT + 12 others); Tue, 8 Jun 2021 15:02:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:34008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237414AbhFHTAf (ORCPT ); Tue, 8 Jun 2021 15:00:35 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D7BAC616ED; Tue, 8 Jun 2021 18:43:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623177827; bh=k9qimZzS8pLMIf5jz271FfERmtM2ILCnjbYXe/DJ3QY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=G+RKU2ChyFC0DSVIeHyHWIls/0Uyl9Lt81tBsi58j/YuMhKtLoaCNv6rykFrTiNVu mahLCxokjXrAy/d9RnPdW5Q/1MQtmjkAJKnPGPTuIqBQafZQFChwL47mHioFuGWFwj SmtDKPCboHvSV8sHOIl51ghcIF5c+k1KWVnFaf1s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Torvalds , "Jason A. Donenfeld" , "David S. Miller" Subject: [PATCH 5.10 080/137] wireguard: do not use -O3 Date: Tue, 8 Jun 2021 20:27:00 +0200 Message-Id: <20210608175945.063521105@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210608175942.377073879@linuxfoundation.org> References: <20210608175942.377073879@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jason A. Donenfeld commit cc5060ca0285efe2728bced399a1955a7ce808b2 upstream. Apparently, various versions of gcc have O3-related miscompiles. Looking at the difference between -O2 and -O3 for gcc 11 doesn't indicate miscompiles, but the difference also doesn't seem so significant for performance that it's worth risking. Link: https://lore.kernel.org/lkml/CAHk-=wjuoGyxDhAF8SsrTkN0-YfCx7E6jUN3ikC_tn2AKWTTsA@mail.gmail.com/ Link: https://lore.kernel.org/lkml/CAHmME9otB5Wwxp7H8bR_i2uH2esEMvoBMC8uEXBMH9p0q1s6Bw@mail.gmail.com/ Reported-by: Linus Torvalds Fixes: e7096c131e51 ("net: WireGuard secure network tunnel") Cc: stable@vger.kernel.org Signed-off-by: Jason A. Donenfeld Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireguard/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/net/wireguard/Makefile +++ b/drivers/net/wireguard/Makefile @@ -1,5 +1,4 @@ -ccflags-y := -O3 -ccflags-y += -D'pr_fmt(fmt)=KBUILD_MODNAME ": " fmt' +ccflags-y := -D'pr_fmt(fmt)=KBUILD_MODNAME ": " fmt' ccflags-$(CONFIG_WIREGUARD_DEBUG) += -DDEBUG wireguard-y := main.o wireguard-y += noise.o