From patchwork Mon Jul 12 06:06:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472890 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2655659jao; Sun, 11 Jul 2021 23:42:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynStWrG9WPGAKrnLkfz9+2JTtir1r85Q56U0xqiS36lU3QoSMsyiHlhsKb67Fyqa9JfjWF X-Received: by 2002:a17:906:a019:: with SMTP id p25mr50932742ejy.483.1626072052941; Sun, 11 Jul 2021 23:40:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072052; cv=none; d=google.com; s=arc-20160816; b=PfwGqg4x+bxZZPVkjZC7yk5izb2bWEql+BWpnPNOUZbAdGeiru+D8lA7OetEn3ni5H XAwWYZERCZRYWvYkXu4j3RK71YYX2RO+h6ikyTwc0HY6xti6hIuuzz1TiKYSgjHnUUTh MBPf7wKtm6+AjnBFJD8rlWQhzJdFT/BbKwgMuL87dygI/Jutvj5XNnpWGUd3flK3om62 Zvv80K1J3WOpJHq7IjZzlXgWRpBuT7xuNXScMqY518z68Fj+HTdE+AtU+IU/pojGC7oO rDEhOTyseTapKhw+MvW+kPnnBAkG9k++cOgIEFPItwjyjGRH3UEUbURniLQN9gbBITsQ +1aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+ITHb6PRxkovE/MLnUVGhHzyOOZbG/9U0O0hNR8rG1E=; b=pU0lBGuwVqcxeJAiwRrY3sewaUQsOYGiuCr9ZJSZgzPYq5VcKJkMG8lEMVSlsgeW1Y kI0MuIQBNpM8a2kkF3EElZf1YgAZ8p5yCElkHZFIG5/dkt6s/2Sv8IXvhcC0T0EbISkC SjXJ0Gak449m9D6ZcNMlywKvPLa+/D5SExnFJS14V8oLW1ermcDihimYxvG3a8D3Y847 t83+dNviW7tt3HpfTEdR/jLkyAmK0sLqaDEfGc9l8RUGMAerNdZ3ELb9ApWLJ72b/KaT HMGzBU3dSRtlBWscj8V7JM9NPcRNWbx8Oa4fMXoJZuX1DnXIk8jSUvnYz96oSk9slWAi SDeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2m6Lnxv3; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id en10si16062540ejc.118.2021.07.11.23.40.52; Sun, 11 Jul 2021 23:40:52 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2m6Lnxv3; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237320AbhGLGlo (ORCPT + 12 others); Mon, 12 Jul 2021 02:41:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:36654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238504AbhGLGkR (ORCPT ); Mon, 12 Jul 2021 02:40:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8A6F86052B; Mon, 12 Jul 2021 06:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626071849; bh=8sHLODwNgxAOO6mCyft9rWozkeNFZT2RKo4VMIWnhQM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2m6Lnxv3EL0FWLu9sfPjMQ6ohW70oppqcJjTbr4K+4ckp5TNM9GKtvn/3bUqfSbEl J6hoxBI1huQfCFe5CJH/T/otBvtpdcODGgHY3xiKzdMpbTOfMklpfOYJCx4D4F70pU 2OZlqY5wFaPyLcizPgPiMZHgac9dyq3dBd/5j4Es= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Shawn Guo , Bjorn Andersson , Jassi Brar , Sasha Levin Subject: [PATCH 5.10 204/593] mailbox: qcom: Use PLATFORM_DEVID_AUTO to register platform device Date: Mon, 12 Jul 2021 08:06:04 +0200 Message-Id: <20210712060905.449972659@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Shawn Guo [ Upstream commit 96e39e95c01283ff5695dafe659df88ada802159 ] In adding APCS clock support for MSM8939, the second clock registration fails due to duplicate device name like below. [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk' ... [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk This is because MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big cores) and CCI (Cache Coherent Interconnect). Although only APCS of Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock control bits. That said, 3 'qcom-apcs-msm8916-clk' devices need to be registered to instantiate all 3 clocks. Use PLATFORM_DEVID_AUTO rather than PLATFORM_DEVID_NONE for platform_device_register_data() call to fix the issue above. Signed-off-by: Shawn Guo Reviewed-by: Bjorn Andersson Signed-off-by: Jassi Brar Signed-off-by: Sasha Levin --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom-apcs-ipc-mailbox.c index 077e5c6a9ef7..3d100a004760 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -128,7 +128,7 @@ static int qcom_apcs_ipc_probe(struct platform_device *pdev) if (apcs_data->clk_name) { apcs->clk = platform_device_register_data(&pdev->dev, apcs_data->clk_name, - PLATFORM_DEVID_NONE, + PLATFORM_DEVID_AUTO, NULL, 0); if (IS_ERR(apcs->clk)) dev_err(&pdev->dev, "failed to register APCS clk\n");