From patchwork Mon Jul 12 06:08:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 472900 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2657605jao; Sun, 11 Jul 2021 23:45:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz32Lvy85d2SKBAncYD1/VI92iceKOoKyAWuzHE0MtJRHT3X/n1DiphPuaTcsLxkcaXeDOR X-Received: by 2002:a05:6e02:144c:: with SMTP id p12mr35874294ilo.290.1626072324005; Sun, 11 Jul 2021 23:45:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626072323; cv=none; d=google.com; s=arc-20160816; b=dV6ERKtgYtODaqy/HhfWF0v1nEYGS/ysIyT/gHTTG+WLWJ69/LY+XSe7Mlt/9hQQr+ 80SN6s6yCQwNsOeaiw3ciN1Gmyfz1/cg/fxPLHUBQ0Jst3ks8vu5fyFRTwJ9pnaRwxMi nWF3N1AB7LE1LTSuytKdwkBsSZ9pEUDbckjXfZmT5eNyJXTEDgsSoM/BfEQxsUSeM48K BiR3iwWfiLxJQZx0Rl3yKV1i+LhcAkalV3SJDBLeydVLjUCRCDWhP1WofN4eBjJtuBlu aUozSrbVsmbjv+zVzZ5zAzLi0ORumInJj1+86LoCcil8WqX6s/wsZfRBqzU593uEWyOU KZ7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=C9zDakqRS4yuu1kDW0+Qtvak3XY2/GcAabAY0rNZUuM=; b=qyTqhLtgXTpIdihe3WoEFAwkKBapKc0R0jPDliMrUJ6LRcNB1ArpXG7SSko+Jt+mxY V3v8joZFQ0rY3NppVF+j0nT3eW9FONJ7WD2f3/bXauWzSeA++DbpNLUEthJHY9IEJ5fT sO3dNxWcxYKujz67nuvr6HPr/ILvGfTyuJRqGUhzFpGawa8u93+I9oaG+Rq4U2jTc7PZ eKDSa+Y6YpiFSEBC6UUX4BReBPrMn35aKwVb2NLGhaq8bPmiGmz5wfFKLy/VSLPqJEmq t/BtlPw5EwSabgBDj53nZyZWrKn/vQLRxXUotPcZL5BZf3nQFU3K7JjGMu8WvTDJ3i3T 2aag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q8hV9rOb; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b15si12373908ilj.38.2021.07.11.23.45.23; Sun, 11 Jul 2021 23:45:23 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Q8hV9rOb; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236460AbhGLGsI (ORCPT + 12 others); Mon, 12 Jul 2021 02:48:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:44282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238305AbhGLGrH (ORCPT ); Mon, 12 Jul 2021 02:47:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 77AD161222; Mon, 12 Jul 2021 06:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626072179; bh=N8/33mR8ZNLEt5zuXLYaFUE+geiMIYi5B0boD7dJbEw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q8hV9rObyPOglcGLVl99oThVG6abUXIB2sL3ySKPYZKgThESq1rMVDNSPV+gSYCWx rvnX6Nj1oBucRMMWQILa3UhHObkiCTV0LMHwTqpBlPlA2SWWSAeGhiOGt2R9MDl6Ie wOlg38zYiXXd01gRPVUZpmENIaCIcpbLGjQOKgB4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bryan ODonoghue , Kalle Valo , Sasha Levin Subject: [PATCH 5.10 345/593] wcn36xx: Move hal_buf allocation to devm_kmalloc in probe Date: Mon, 12 Jul 2021 08:08:25 +0200 Message-Id: <20210712060924.033741450@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060843.180606720@linuxfoundation.org> References: <20210712060843.180606720@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bryan O'Donoghue [ Upstream commit ef48667557c53d4b51a1ee3090eab7699324c9de ] Right now wcn->hal_buf is allocated in wcn36xx_start(). This is a problem since we should have setup all of the buffers we required by the time ieee80211_register_hw() is called. struct ieee80211_ops callbacks may run prior to mac_start() and therefore wcn->hal_buf must be initialized. This is easily remediated by moving the allocation to probe() taking the opportunity to tidy up freeing memory by using devm_kmalloc(). Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Bryan O'Donoghue Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/20210605173347.2266003-1-bryan.odonoghue@linaro.org Signed-off-by: Sasha Levin --- drivers/net/wireless/ath/wcn36xx/main.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) -- 2.30.2 diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c index 706728fba72d..9f8e44210e89 100644 --- a/drivers/net/wireless/ath/wcn36xx/main.c +++ b/drivers/net/wireless/ath/wcn36xx/main.c @@ -293,23 +293,16 @@ static int wcn36xx_start(struct ieee80211_hw *hw) goto out_free_dxe_pool; } - wcn->hal_buf = kmalloc(WCN36XX_HAL_BUF_SIZE, GFP_KERNEL); - if (!wcn->hal_buf) { - wcn36xx_err("Failed to allocate smd buf\n"); - ret = -ENOMEM; - goto out_free_dxe_ctl; - } - ret = wcn36xx_smd_load_nv(wcn); if (ret) { wcn36xx_err("Failed to push NV to chip\n"); - goto out_free_smd_buf; + goto out_free_dxe_ctl; } ret = wcn36xx_smd_start(wcn); if (ret) { wcn36xx_err("Failed to start chip\n"); - goto out_free_smd_buf; + goto out_free_dxe_ctl; } if (!wcn36xx_is_fw_version(wcn, 1, 2, 2, 24)) { @@ -336,8 +329,6 @@ static int wcn36xx_start(struct ieee80211_hw *hw) out_smd_stop: wcn36xx_smd_stop(wcn); -out_free_smd_buf: - kfree(wcn->hal_buf); out_free_dxe_ctl: wcn36xx_dxe_free_ctl_blks(wcn); out_free_dxe_pool: @@ -372,8 +363,6 @@ static void wcn36xx_stop(struct ieee80211_hw *hw) wcn36xx_dxe_free_mem_pools(wcn); wcn36xx_dxe_free_ctl_blks(wcn); - - kfree(wcn->hal_buf); } static void wcn36xx_change_ps(struct wcn36xx *wcn, bool enable) @@ -1398,6 +1387,12 @@ static int wcn36xx_probe(struct platform_device *pdev) mutex_init(&wcn->hal_mutex); mutex_init(&wcn->scan_lock); + wcn->hal_buf = devm_kmalloc(wcn->dev, WCN36XX_HAL_BUF_SIZE, GFP_KERNEL); + if (!wcn->hal_buf) { + ret = -ENOMEM; + goto out_wq; + } + ret = dma_set_mask_and_coherent(wcn->dev, DMA_BIT_MASK(32)); if (ret < 0) { wcn36xx_err("failed to set DMA mask: %d\n", ret);