From patchwork Mon Jul 12 06:06:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 472948 Delivered-To: patch@linaro.org Received: by 2002:a02:c94a:0:0:0:0:0 with SMTP id u10csp2673641jao; Mon, 12 Jul 2021 00:10:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPp4c49J3g7pZMbycmSrkAcTRUnRmyOhEksWuULhBYo/Dl3FALklsBsNghiJ0UuVSOoJtz X-Received: by 2002:a92:d990:: with SMTP id r16mr1820750iln.204.1626073822935; Mon, 12 Jul 2021 00:10:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1626073822; cv=none; d=google.com; s=arc-20160816; b=UMorCiyXrUvbuc/mkE96JRMHC+8tQye7vwxe+QnLGifA/QDKMUbBqHsR6zH+FFYmUl KMj3x7BIGCqe5PbrhJmbqr/iVHsNHM8222cloJY8vMKneuCF713uhzDV5Lj68GOqnMKB qw8bzsNtz7zPKCmnyyr8Po/cgodairLUC6QqB1UeGAt/aPfhTu80E86+Y+U/R/XH6frG HfK9esiuEnVdDtY3PSskqsGwBTFFcUjEhBzDhhDUxaOv2/nL0j/5sgltoTjyt2KfRYTO kf5LkuTqDjFdHs1SsYlSrhh4aMoUNg/1DiZ61Qu2TGXyy0PXA7HJhmf9wMXKcX/pEyZP oIKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6ZYUd4MxZoL8o9EEXJOqWWVGD2Iutc5t6wBi6vthZak=; b=o4qMW0IOlfYYv5VWgCY9/DxaA7GZJaL0gVtTRD/OdgNH8Dw165MFwpttIV0d5+ryj9 ag4Ixo71UY/SJiGZSpjnL6fHH39EFKNO6NCY1OHT92f5BjQaQgfCyehDD0DjXDysyooC 3Gc2W38mtEypd9YeX7G4FaK939uKKdQUH2ybIabrwwUCJSKp2u1XyLAiJsh06x/sv7F1 E/HbcXfPwtSjVzuRrfQc4uYNyaKIlOdcnBeJNNZhaL8CfyY9eldV3hc1IGf5aRvEUfUv wcU0/kPPdvBZTHk6wpzKDTtXi+tUxpBXtVDLw37mvwZgtetzI2k9pnvISQejnmT2aK7X bFqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IrauTCgH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si16580694jas.65.2021.07.12.00.10.22; Mon, 12 Jul 2021 00:10:22 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=IrauTCgH; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242466AbhGLHL6 (ORCPT + 12 others); Mon, 12 Jul 2021 03:11:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:42596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244145AbhGLHK1 (ORCPT ); Mon, 12 Jul 2021 03:10:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DC77461154; Mon, 12 Jul 2021 07:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1626073574; bh=nJBxJgmRFblp5PtPkGY4cKuHKRQqMekKlQh+2VtKUzE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IrauTCgHXTXdYazqLWmtODCiEnQx9BZOI0GTxKAmO6xjV7hOsg+Pw6ZcUNKNVeBLV yThWyzakUFLPh5iKTjgUnIpz3VNvkoKu19gAGXlDBAIPVgRBim3zWYh5ekrPt8cBNJ lsRCRTtrLiPZNrQ+6gzf0rOpxCSCLwhHLftVxcZU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Zhen Lei , Ulf Hansson , Sasha Levin Subject: [PATCH 5.12 287/700] mmc: usdhi6rol0: fix error return code in usdhi6_probe() Date: Mon, 12 Jul 2021 08:06:10 +0200 Message-Id: <20210712061006.765983376@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210712060924.797321836@linuxfoundation.org> References: <20210712060924.797321836@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Zhen Lei [ Upstream commit 2f9ae69e5267f53e89e296fccee291975a85f0eb ] Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 75fa9ea6e3c0 ("mmc: add a driver for the Renesas usdhi6rol0 SD/SDIO host controller") Reported-by: Hulk Robot Signed-off-by: Zhen Lei Link: https://lore.kernel.org/r/20210508020321.1677-1-thunder.leizhen@huawei.com Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/usdhi6rol0.c | 1 + 1 file changed, 1 insertion(+) -- 2.30.2 diff --git a/drivers/mmc/host/usdhi6rol0.c b/drivers/mmc/host/usdhi6rol0.c index 615f3d008af1..b9b79b1089a0 100644 --- a/drivers/mmc/host/usdhi6rol0.c +++ b/drivers/mmc/host/usdhi6rol0.c @@ -1801,6 +1801,7 @@ static int usdhi6_probe(struct platform_device *pdev) version = usdhi6_read(host, USDHI6_VERSION); if ((version & 0xfff) != 0xa0d) { + ret = -EPERM; dev_err(dev, "Version not recognized %x\n", version); goto e_clk_off; }