mbox series

[v7,00/10] Add support for loading main_r5fss0_core0

Message ID 20200204063638.28161-1-j-keerthy@ti.com
Headers show
Series Add support for loading main_r5fss0_core0 | expand

Message

Keerthy Feb. 4, 2020, 6:36 a.m. UTC
This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
Tested for firmware loading and execution on J721e.

Changes in v7:

  * Added BSD-2 SPDX on lib/elf.c file.
  * Added Tom's Reviewed-by for the relevant patches.

Changes in v6:

  * Fixed the imx build issue.

Changes in v5:

  * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
  * Added more information on the envnowhere patch.
  * Added help LIB_ELF option and removed user configurable description.

Changes in v4:

  * Changed env variable names, config names and enhanced commit logs.

Changes in v3:

  * Removed saving env in MMC and fixed env saving in SPL when nowhere
    option is set.

Changes in v2:

  * Factored out all the generic elf handling functions under lib/elf.c

Keerthy (10):
  env: nowhere: set default enviroment
  lib: elf: Move the generic elf loading/validating functions to lib
  arm: k3: Add support for loading non linux remote cores
  armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM
  armv7R: K3: Add support for jumping to firmware
  arm: dts: k3-j721e-r5-u-boot: Add fs_loader node
  arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL
  include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 &
    main_r5fss0_core0
  configs: j721e_evm_r5: Enable R5F remoteproc support
  configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC

 .../k3-j721e-r5-common-proc-board-u-boot.dtsi |  27 ++
 .../arm/dts/k3-j721e-r5-common-proc-board.dts |   2 +
 arch/arm/mach-imx/imx_bootaux.c               |  46 ----
 arch/arm/mach-k3/common.c                     | 106 +++++++-
 arch/arm/mach-k3/common.h                     |   2 +
 arch/arm/mach-k3/j721e_init.c                 |  34 +++
 arch/arm/mach-k3/r5_mpu.c                     |   4 +-
 cmd/Kconfig                                   |   1 +
 cmd/elf.c                                     | 229 ----------------
 configs/j721e_evm_r5_defconfig                |   6 +-
 env/nowhere.c                                 |   1 +
 include/configs/j721e_evm.h                   |   4 +
 include/elf.h                                 |   4 +
 lib/Kconfig                                   |   6 +
 lib/Makefile                                  |   1 +
 lib/elf.c                                     | 246 ++++++++++++++++++
 16 files changed, 428 insertions(+), 291 deletions(-)
 create mode 100644 arch/arm/dts/k3-j721e-r5-common-proc-board-u-boot.dtsi
 create mode 100644 lib/elf.c

Comments

Lokesh Vutla Feb. 5, 2020, 9:15 a.m. UTC | #1
On 04/02/20 12:06 PM, Keerthy wrote:
> This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
> Tested for firmware loading and execution on J721e.

I still see build error with multiple imx boards:

===================================================
       arm:  +   mx7dsabresd_qspi
+arch/arm/mach-imx/imx_bootaux.c:18:32: error: 'get_host_mapping' defined but
not used [-Werror=unused-function]
+ static const struct rproc_att *get_host_mapping(unsigned long auxcore)
+                                ^~~~~~~~~~~~~~~~
+cc1: all warnings being treated as errors
+make[2]: *** [arch/arm/mach-imx/imx_bootaux.o] Error 1
+make[1]: *** [arch/arm/mach-imx] Error 2
+make: *** [sub-make] Error 2


Thanks and regards,
Lokesh

> 
> Changes in v7:
> 
>   * Added BSD-2 SPDX on lib/elf.c file.
>   * Added Tom's Reviewed-by for the relevant patches.
> 
> Changes in v6:
> 
>   * Fixed the imx build issue.
> 
> Changes in v5:
> 
>   * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
>   * Added more information on the envnowhere patch.
>   * Added help LIB_ELF option and removed user configurable description.
> 
> Changes in v4:
> 
>   * Changed env variable names, config names and enhanced commit logs.
> 
> Changes in v3:
> 
>   * Removed saving env in MMC and fixed env saving in SPL when nowhere
>     option is set.
> 
> Changes in v2:
> 
>   * Factored out all the generic elf handling functions under lib/elf.c
> 
> Keerthy (10):
>   env: nowhere: set default enviroment
>   lib: elf: Move the generic elf loading/validating functions to lib
>   arm: k3: Add support for loading non linux remote cores
>   armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM
>   armv7R: K3: Add support for jumping to firmware
>   arm: dts: k3-j721e-r5-u-boot: Add fs_loader node
>   arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL
>   include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 &
>     main_r5fss0_core0
>   configs: j721e_evm_r5: Enable R5F remoteproc support
>   configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC
> 
>  .../k3-j721e-r5-common-proc-board-u-boot.dtsi |  27 ++
>  .../arm/dts/k3-j721e-r5-common-proc-board.dts |   2 +
>  arch/arm/mach-imx/imx_bootaux.c               |  46 ----
>  arch/arm/mach-k3/common.c                     | 106 +++++++-
>  arch/arm/mach-k3/common.h                     |   2 +
>  arch/arm/mach-k3/j721e_init.c                 |  34 +++
>  arch/arm/mach-k3/r5_mpu.c                     |   4 +-
>  cmd/Kconfig                                   |   1 +
>  cmd/elf.c                                     | 229 ----------------
>  configs/j721e_evm_r5_defconfig                |   6 +-
>  env/nowhere.c                                 |   1 +
>  include/configs/j721e_evm.h                   |   4 +
>  include/elf.h                                 |   4 +
>  lib/Kconfig                                   |   6 +
>  lib/Makefile                                  |   1 +
>  lib/elf.c                                     | 246 ++++++++++++++++++
>  16 files changed, 428 insertions(+), 291 deletions(-)
>  create mode 100644 arch/arm/dts/k3-j721e-r5-common-proc-board-u-boot.dtsi
>  create mode 100644 lib/elf.c
>
Keerthy Feb. 5, 2020, 2:59 p.m. UTC | #2
On 2/5/2020 2:45 PM, Lokesh Vutla wrote:
> 
> 
> On 04/02/20 12:06 PM, Keerthy wrote:
>> This patch series enables mcu_r5fss0_core0 & main_r5fss0_core0.
>> Tested for firmware loading and execution on J721e.
> 
> I still see build error with multiple imx boards:
> 
> ===================================================
>         arm:  +   mx7dsabresd_qspi
> +arch/arm/mach-imx/imx_bootaux.c:18:32: error: 'get_host_mapping' defined but
> not used [-Werror=unused-function]
> + static const struct rproc_att *get_host_mapping(unsigned long auxcore)
> +                                ^~~~~~~~~~~~~~~~
> +cc1: all warnings being treated as errors
> +make[2]: *** [arch/arm/mach-imx/imx_bootaux.o] Error 1
> +make[1]: *** [arch/arm/mach-imx] Error 2
> +make: *** [sub-make] Error 2

Phew... Local builds did not catch for me. I will make sure i run the 
travis builds before i submit v8.

> 
> 
> Thanks and regards,
> Lokesh
> 
>>
>> Changes in v7:
>>
>>    * Added BSD-2 SPDX on lib/elf.c file.
>>    * Added Tom's Reviewed-by for the relevant patches.
>>
>> Changes in v6:
>>
>>    * Fixed the imx build issue.
>>
>> Changes in v5:
>>
>>    * Moved the fs_loader node under r5-common-proc-board-u-boot.dtsi
>>    * Added more information on the envnowhere patch.
>>    * Added help LIB_ELF option and removed user configurable description.
>>
>> Changes in v4:
>>
>>    * Changed env variable names, config names and enhanced commit logs.
>>
>> Changes in v3:
>>
>>    * Removed saving env in MMC and fixed env saving in SPL when nowhere
>>      option is set.
>>
>> Changes in v2:
>>
>>    * Factored out all the generic elf handling functions under lib/elf.c
>>
>> Keerthy (10):
>>    env: nowhere: set default enviroment
>>    lib: elf: Move the generic elf loading/validating functions to lib
>>    arm: k3: Add support for loading non linux remote cores
>>    armv7R: K3: r5_mpu: Enable execute permission for MCU0 BTCM
>>    armv7R: K3: Add support for jumping to firmware
>>    arm: dts: k3-j721e-r5-u-boot: Add fs_loader node
>>    arm: dts: k3-j721e-r5: Enable r5fss0 cluster in SPL
>>    include: configs: j721e_evm: Add env variables for mcu_r5fss0_core0 &
>>      main_r5fss0_core0
>>    configs: j721e_evm_r5: Enable R5F remoteproc support
>>    configs: j721e_evm_r5_defconfig: Remove saving ENV in eMMC
>>
>>   .../k3-j721e-r5-common-proc-board-u-boot.dtsi |  27 ++
>>   .../arm/dts/k3-j721e-r5-common-proc-board.dts |   2 +
>>   arch/arm/mach-imx/imx_bootaux.c               |  46 ----
>>   arch/arm/mach-k3/common.c                     | 106 +++++++-
>>   arch/arm/mach-k3/common.h                     |   2 +
>>   arch/arm/mach-k3/j721e_init.c                 |  34 +++
>>   arch/arm/mach-k3/r5_mpu.c                     |   4 +-
>>   cmd/Kconfig                                   |   1 +
>>   cmd/elf.c                                     | 229 ----------------
>>   configs/j721e_evm_r5_defconfig                |   6 +-
>>   env/nowhere.c                                 |   1 +
>>   include/configs/j721e_evm.h                   |   4 +
>>   include/elf.h                                 |   4 +
>>   lib/Kconfig                                   |   6 +
>>   lib/Makefile                                  |   1 +
>>   lib/elf.c                                     | 246 ++++++++++++++++++
>>   16 files changed, 428 insertions(+), 291 deletions(-)
>>   create mode 100644 arch/arm/dts/k3-j721e-r5-common-proc-board-u-boot.dtsi
>>   create mode 100644 lib/elf.c
>>