mbox series

[v4,0/5] TI Ethernet PHY changes

Message ID 20200504211440.13385-1-dmurphy@ti.com
Headers show
Series TI Ethernet PHY changes | expand

Message

Dan Murphy May 4, 2020, 9:14 p.m. UTC
Hello

The addition of the DP83867 driver to uboot was done in a generic way that
made it a bit difficult to bring in new PHY drivers.  The difficulty came in the
config flags and the phy_init function.  The change is to make the flags and
init for the DP83867 more specific to the DP83867 device to make way to add
more TI PHYs to uBoot.

In addition the DP8382X PHY is a generic PHY driver that does not need any
special handling to establish a link.  Customers have requested that at the very
least there be a way to know if the PHY attached is the PHY that is connected
as "Generic PHY" is not really descriptive.  These patches adds the
registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.

Porting PHY helper routines to set and clear bits to facilitate easier side
porting of ethernet kernel drivers to uBoot.

Also fixed and added missing or kernel doc documentation in the phy.h file.

Dan

Dan Murphy (5):
  net: phy: Add missing kernel doc to phy functions
  net: phy: Fix kernel doc issues in phy.h
  net: phy: Add helper routines to set and clear bits
  net: phy: Add support for TI PHY init
  net: phy: Add DP8382x phy registration to TI PHY init

 configs/am65x_evm_a53_defconfig      |   2 +-
 configs/am65x_hs_evm_a53_defconfig   |   2 +-
 configs/dra7xx_evm_defconfig         |   2 +-
 configs/dra7xx_hs_evm_defconfig      |   2 +-
 configs/dra7xx_hs_evm_usb_defconfig  |   2 +-
 configs/j721e_evm_a72_defconfig      |   2 +-
 configs/j721e_hs_evm_a72_defconfig   |   2 +-
 configs/k2g_evm_defconfig            |   2 +-
 configs/xilinx_versal_virt_defconfig |   2 +-
 configs/xilinx_zynqmp_virt_defconfig |   2 +-
 drivers/net/phy/Kconfig              |  15 ++++
 drivers/net/phy/Makefile             |   3 +-
 drivers/net/phy/dp83867.c            |   3 +-
 drivers/net/phy/ti_phy_init.c        | 101 ++++++++++++++++++++++++
 drivers/net/phy/ti_phy_init.h        |  15 ++++
 include/phy.h                        | 112 ++++++++++++++++++++++++---
 16 files changed, 246 insertions(+), 23 deletions(-)
 create mode 100644 drivers/net/phy/ti_phy_init.c
 create mode 100644 drivers/net/phy/ti_phy_init.h

Comments

Dan Murphy May 12, 2020, 12:52 a.m. UTC | #1
Bump to the series

On 5/4/20 4:14 PM, Dan Murphy wrote:
> Hello
>
> The addition of the DP83867 driver to uboot was done in a generic way that
> made it a bit difficult to bring in new PHY drivers.  The difficulty came in the
> config flags and the phy_init function.  The change is to make the flags and
> init for the DP83867 more specific to the DP83867 device to make way to add
> more TI PHYs to uBoot.
>
> In addition the DP8382X PHY is a generic PHY driver that does not need any
> special handling to establish a link.  Customers have requested that at the very
> least there be a way to know if the PHY attached is the PHY that is connected
> as "Generic PHY" is not really descriptive.  These patches adds the
> registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.
>
> Porting PHY helper routines to set and clear bits to facilitate easier side
> porting of ethernet kernel drivers to uBoot.
>
> Also fixed and added missing or kernel doc documentation in the phy.h file.
>
> Dan
>
> Dan Murphy (5):
>    net: phy: Add missing kernel doc to phy functions
>    net: phy: Fix kernel doc issues in phy.h
>    net: phy: Add helper routines to set and clear bits
>    net: phy: Add support for TI PHY init
>    net: phy: Add DP8382x phy registration to TI PHY init
>
>   configs/am65x_evm_a53_defconfig      |   2 +-
>   configs/am65x_hs_evm_a53_defconfig   |   2 +-
>   configs/dra7xx_evm_defconfig         |   2 +-
>   configs/dra7xx_hs_evm_defconfig      |   2 +-
>   configs/dra7xx_hs_evm_usb_defconfig  |   2 +-
>   configs/j721e_evm_a72_defconfig      |   2 +-
>   configs/j721e_hs_evm_a72_defconfig   |   2 +-
>   configs/k2g_evm_defconfig            |   2 +-
>   configs/xilinx_versal_virt_defconfig |   2 +-
>   configs/xilinx_zynqmp_virt_defconfig |   2 +-
>   drivers/net/phy/Kconfig              |  15 ++++
>   drivers/net/phy/Makefile             |   3 +-
>   drivers/net/phy/dp83867.c            |   3 +-
>   drivers/net/phy/ti_phy_init.c        | 101 ++++++++++++++++++++++++
>   drivers/net/phy/ti_phy_init.h        |  15 ++++
>   include/phy.h                        | 112 ++++++++++++++++++++++++---
>   16 files changed, 246 insertions(+), 23 deletions(-)
>   create mode 100644 drivers/net/phy/ti_phy_init.c
>   create mode 100644 drivers/net/phy/ti_phy_init.h
>
Grygorii Strashko May 18, 2020, 6:20 p.m. UTC | #2
On 05/05/2020 00:14, Dan Murphy wrote:
> Hello
> 
> The addition of the DP83867 driver to uboot was done in a generic way that
> made it a bit difficult to bring in new PHY drivers.  The difficulty came in the
> config flags and the phy_init function.  The change is to make the flags and
> init for the DP83867 more specific to the DP83867 device to make way to add
> more TI PHYs to uBoot.
> 
> In addition the DP8382X PHY is a generic PHY driver that does not need any
> special handling to establish a link.  Customers have requested that at the very
> least there be a way to know if the PHY attached is the PHY that is connected
> as "Generic PHY" is not really descriptive.  These patches adds the
> registrations for TI Generic PHYs to associcate a TI PHY ID with a PHY name.
> 
> Porting PHY helper routines to set and clear bits to facilitate easier side
> porting of ethernet kernel drivers to uBoot.
> 
> Also fixed and added missing or kernel doc documentation in the phy.h file.
> 
> Dan
> 
> Dan Murphy (5):
>    net: phy: Add missing kernel doc to phy functions
>    net: phy: Fix kernel doc issues in phy.h
>    net: phy: Add helper routines to set and clear bits
>    net: phy: Add support for TI PHY init
>    net: phy: Add DP8382x phy registration to TI PHY init
> 
>   configs/am65x_evm_a53_defconfig      |   2 +-
>   configs/am65x_hs_evm_a53_defconfig   |   2 +-
>   configs/dra7xx_evm_defconfig         |   2 +-
>   configs/dra7xx_hs_evm_defconfig      |   2 +-
>   configs/dra7xx_hs_evm_usb_defconfig  |   2 +-
>   configs/j721e_evm_a72_defconfig      |   2 +-
>   configs/j721e_hs_evm_a72_defconfig   |   2 +-
>   configs/k2g_evm_defconfig            |   2 +-
>   configs/xilinx_versal_virt_defconfig |   2 +-
>   configs/xilinx_zynqmp_virt_defconfig |   2 +-
>   drivers/net/phy/Kconfig              |  15 ++++
>   drivers/net/phy/Makefile             |   3 +-
>   drivers/net/phy/dp83867.c            |   3 +-
>   drivers/net/phy/ti_phy_init.c        | 101 ++++++++++++++++++++++++
>   drivers/net/phy/ti_phy_init.h        |  15 ++++
>   include/phy.h                        | 112 ++++++++++++++++++++++++---
>   16 files changed, 246 insertions(+), 23 deletions(-)
>   create mode 100644 drivers/net/phy/ti_phy_init.c
>   create mode 100644 drivers/net/phy/ti_phy_init.h
> 

Reviewed-by: Grygorii Strashko <grygorii.strashko at ti.com>