mbox series

[v14,0/2] add TCP and HTTP for downloading images

Message ID 20220421165424.168274-1-grandpaul@gmail.com
Headers show
Series add TCP and HTTP for downloading images | expand

Message

Ying-Chun Liu April 21, 2022, 4:54 p.m. UTC 
From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>

This patch is a refresh from previous patches made by
Duncan Hare <DuncanCHare@yahoo.com>. I've contacted him and
continue to work on this patch.

This patch introduce a TCP stack with SACK. And a simple wget command
to download images from http server.

v13: Fix some issues which is reviewed by Christian
v14: Add options to enable/disable SACK.

Ying-Chun Liu (PaulLiu) (2):
  net: Add TCP protocol
  net: Add wget application

 cmd/Kconfig        |   7 +
 cmd/net.c          |  13 +
 include/net.h      |  10 +-
 include/net/tcp.h  | 222 ++++++++++++++
 include/net/wget.h |  19 ++
 net/Kconfig        |  12 +
 net/Makefile       |   2 +
 net/net.c          |  36 +++
 net/tcp.c          | 709 +++++++++++++++++++++++++++++++++++++++++++++
 net/wget.c         | 436 ++++++++++++++++++++++++++++
 10 files changed, 1464 insertions(+), 2 deletions(-)
 create mode 100644 include/net/tcp.h
 create mode 100644 include/net/wget.h
 create mode 100644 net/tcp.c
 create mode 100644 net/wget.c

Comments

Michal Simek May 18, 2022, 9:53 a.m. UTC | #1 
Hi,

On 4/21/22 18:54, Ying-Chun Liu wrote:
> From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
> 
> This patch is a refresh from previous patches made by
> Duncan Hare <DuncanCHare@yahoo.com>. I've contacted him and
> continue to work on this patch.
> 
> This patch introduce a TCP stack with SACK. And a simple wget command
> to download images from http server.
> 
> v13: Fix some issues which is reviewed by Christian
> v14: Add options to enable/disable SACK.

What did you change from v1 to v12?

I think you should clean up the code and in this cover letter I would expect 
more description what you have tried. I have seen demo with downloading efi 
application.
Is there any way to run any OS installer? Or for that you need to have https?

Thanks,
Michal
Paul Liu May 18, 2022, 2:51 p.m. UTC | #2 
Hi Michal,

Thanks for reviewing. I'll make a fix based on your review soon.

However I don't know the change from v1 to v12. The previous version are
made by Duncan, and the patches are one year ago so I lost track of the
changes from v1 to v12.

For booting iso images (installer) from distros I think I'll need to try
it. But it is definitely not related to HTTPS.
What I know is the distro release ISO images. And we need to extract all
efi (EFI shell, grub..) and initrd/kernel from ISO
image's eltorito section. I need to figure that out how to do it by
commands if we load the iso images to the memory.

Yours,
Paul


On Wed, 18 May 2022 at 17:54, Michal Simek <michal.simek@xilinx.com> wrote:

> Hi,
>
> On 4/21/22 18:54, Ying-Chun Liu wrote:
> > From: "Ying-Chun Liu (PaulLiu)" <paul.liu@linaro.org>
> >
> > This patch is a refresh from previous patches made by
> > Duncan Hare <DuncanCHare@yahoo.com>. I've contacted him and
> > continue to work on this patch.
> >
> > This patch introduce a TCP stack with SACK. And a simple wget command
> > to download images from http server.
> >
> > v13: Fix some issues which is reviewed by Christian
> > v14: Add options to enable/disable SACK.
>
> What did you change from v1 to v12?
>
> I think you should clean up the code and in this cover letter I would
> expect
> more description what you have tried. I have seen demo with downloading
> efi
> application.
> Is there any way to run any OS installer? Or for that you need to have
> https?
>
> Thanks,
> Michal
>
>
>
>