| Message ID | 20220914100956.480554-1-sughosh.ganu@linaro.org |
|---|---|
| Headers | show |
| Series | rockpi4: Add capsule update support | expand |
hi Tom, On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > Add capsule update support for the RockPi4B and RockPi4C > boards. Support is being added for updating the idbloader.img and > u-boot.itb firmware images on configurations with the firmware images > stored on GPT partitioned uSD card device. > > Changes since V2: > * Use rockchip in the commit message summary instead of rockpi > * Use num_image_type_guids instead of ROCKPI4_UPDATABLE_IMAGES macro > * Move the board specific code out of this file into evb_rk3399.c > * Add a function rockchip_capsule_update_board_setup() for setting up > the board specific part needed for capsule updates These patches have been given a R-b by Kever. I see them being assigned to you. Can these be merged into master. Thanks. -sughosh > > Sughosh Ganu (3): > rockchip: capsule: Add functions for supporting capsule updates > rockpi4: board: Add firmware image information for capsule updates > rockpi4: capsule: Enable UEFI capsule update on RockPi4 boards > > arch/arm/include/asm/arch-rockchip/misc.h | 1 + > arch/arm/mach-rockchip/Kconfig | 1 + > arch/arm/mach-rockchip/board.c | 152 ++++++++++++++++++++++ > board/rockchip/evb_rk3399/evb-rk3399.c | 55 +++++++- > configs/rock-pi-4-rk3399_defconfig | 8 ++ > configs/rock-pi-4c-rk3399_defconfig | 8 ++ > include/configs/rk3399_common.h | 16 +++ > 7 files changed, 240 insertions(+), 1 deletion(-) > > -- > 2.34.1 > >
On 2022/11/2 14:21, Sughosh Ganu wrote: > hi Tom, > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: >> >> Add capsule update support for the RockPi4B and RockPi4C >> boards. Support is being added for updating the idbloader.img and >> u-boot.itb firmware images on configurations with the firmware images >> stored on GPT partitioned uSD card device. >> >> Changes since V2: >> * Use rockchip in the commit message summary instead of rockpi >> * Use num_image_type_guids instead of ROCKPI4_UPDATABLE_IMAGES macro >> * Move the board specific code out of this file into evb_rk3399.c >> * Add a function rockchip_capsule_update_board_setup() for setting up >> the board specific part needed for capsule updates > These patches have been given a R-b by Kever. I see them being > assigned to you. Can these be merged into master. Thanks. Interesting, I don't think I had re-assign this patch set to Tom after I give the review tag, I can take it later if there is no objection to this from Tom. Thanks, - Kever > > -sughosh > >> Sughosh Ganu (3): >> rockchip: capsule: Add functions for supporting capsule updates >> rockpi4: board: Add firmware image information for capsule updates >> rockpi4: capsule: Enable UEFI capsule update on RockPi4 boards >> >> arch/arm/include/asm/arch-rockchip/misc.h | 1 + >> arch/arm/mach-rockchip/Kconfig | 1 + >> arch/arm/mach-rockchip/board.c | 152 ++++++++++++++++++++++ >> board/rockchip/evb_rk3399/evb-rk3399.c | 55 +++++++- >> configs/rock-pi-4-rk3399_defconfig | 8 ++ >> configs/rock-pi-4c-rk3399_defconfig | 8 ++ >> include/configs/rk3399_common.h | 16 +++ >> 7 files changed, 240 insertions(+), 1 deletion(-) >> >> -- >> 2.34.1 >> >>
On Wed, Nov 02, 2022 at 05:23:48PM +0800, Kever Yang wrote: > > On 2022/11/2 14:21, Sughosh Ganu wrote: > > hi Tom, > > > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > > > > Add capsule update support for the RockPi4B and RockPi4C > > > boards. Support is being added for updating the idbloader.img and > > > u-boot.itb firmware images on configurations with the firmware images > > > stored on GPT partitioned uSD card device. > > > > > > Changes since V2: > > > * Use rockchip in the commit message summary instead of rockpi > > > * Use num_image_type_guids instead of ROCKPI4_UPDATABLE_IMAGES macro > > > * Move the board specific code out of this file into evb_rk3399.c > > > * Add a function rockchip_capsule_update_board_setup() for setting up > > > the board specific part needed for capsule updates > > These patches have been given a R-b by Kever. I see them being > > assigned to you. Can these be merged into master. Thanks. > > Interesting, I don't think I had re-assign this patch set to Tom after I > give the review tag, > > I can take it later if there is no objection to this from Tom. Is there any refactoring / updating to these patches required based on the overall feedback given either (a) as part of the follow-up changes to the FWU core that've been done or (b) that is similar to the feedback given to the Developerbox series?
hi Tom, On Wed, 2 Nov 2022 at 18:52, Tom Rini <trini@konsulko.com> wrote: > > On Wed, Nov 02, 2022 at 05:23:48PM +0800, Kever Yang wrote: > > > > On 2022/11/2 14:21, Sughosh Ganu wrote: > > > hi Tom, > > > > > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > > > > > > Add capsule update support for the RockPi4B and RockPi4C > > > > boards. Support is being added for updating the idbloader.img and > > > > u-boot.itb firmware images on configurations with the firmware images > > > > stored on GPT partitioned uSD card device. > > > > > > > > Changes since V2: > > > > * Use rockchip in the commit message summary instead of rockpi > > > > * Use num_image_type_guids instead of ROCKPI4_UPDATABLE_IMAGES macro > > > > * Move the board specific code out of this file into evb_rk3399.c > > > > * Add a function rockchip_capsule_update_board_setup() for setting up > > > > the board specific part needed for capsule updates > > > These patches have been given a R-b by Kever. I see them being > > > assigned to you. Can these be merged into master. Thanks. > > > > Interesting, I don't think I had re-assign this patch set to Tom after I > > give the review tag, > > > > I can take it later if there is no objection to this from Tom. > > Is there any refactoring / updating to these patches required based on > the overall feedback given either (a) as part of the follow-up changes > to the FWU core that've been done or (b) that is similar to the feedback > given to the Developerbox series? These patches are enabling capsule update support on the boards, and are not related to the FWU update functionality. -sughosh > > -- > Tom
On Wed, Nov 02, 2022 at 08:12:23PM +0530, Sughosh Ganu wrote: > hi Tom, > > On Wed, 2 Nov 2022 at 18:52, Tom Rini <trini@konsulko.com> wrote: > > > > On Wed, Nov 02, 2022 at 05:23:48PM +0800, Kever Yang wrote: > > > > > > On 2022/11/2 14:21, Sughosh Ganu wrote: > > > > hi Tom, > > > > > > > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > > > > > > > > > > Add capsule update support for the RockPi4B and RockPi4C > > > > > boards. Support is being added for updating the idbloader.img and > > > > > u-boot.itb firmware images on configurations with the firmware images > > > > > stored on GPT partitioned uSD card device. > > > > > > > > > > Changes since V2: > > > > > * Use rockchip in the commit message summary instead of rockpi > > > > > * Use num_image_type_guids instead of ROCKPI4_UPDATABLE_IMAGES macro > > > > > * Move the board specific code out of this file into evb_rk3399.c > > > > > * Add a function rockchip_capsule_update_board_setup() for setting up > > > > > the board specific part needed for capsule updates > > > > These patches have been given a R-b by Kever. I see them being > > > > assigned to you. Can these be merged into master. Thanks. > > > > > > Interesting, I don't think I had re-assign this patch set to Tom after I > > > give the review tag, > > > > > > I can take it later if there is no objection to this from Tom. > > > > Is there any refactoring / updating to these patches required based on > > the overall feedback given either (a) as part of the follow-up changes > > to the FWU core that've been done or (b) that is similar to the feedback > > given to the Developerbox series? > > These patches are enabling capsule update support on the boards, and > are not related to the FWU update functionality. OK, I just had them mentally conflated then, I'll re-assign them to Kever shortly.
hi Kever, On Wed, 2 Nov 2022 at 14:53, Kever Yang <kever.yang@rock-chips.com> wrote: > > > On 2022/11/2 14:21, Sughosh Ganu wrote: > > hi Tom, > > > > On Wed, 14 Sept 2022 at 15:40, Sughosh Ganu <sughosh.ganu@linaro.org> wrote: > >> > >> Add capsule update support for the RockPi4B and RockPi4C > >> boards. Support is being added for updating the idbloader.img and > >> u-boot.itb firmware images on configurations with the firmware images > >> stored on GPT partitioned uSD card device. > >> > >> Changes since V2: > >> * Use rockchip in the commit message summary instead of rockpi > >> * Use num_image_type_guids instead of ROCKPI4_UPDATABLE_IMAGES macro > >> * Move the board specific code out of this file into evb_rk3399.c > >> * Add a function rockchip_capsule_update_board_setup() for setting up > >> the board specific part needed for capsule updates > > These patches have been given a R-b by Kever. I see them being > > assigned to you. Can these be merged into master. Thanks. > > Interesting, I don't think I had re-assign this patch set to Tom after I > give the review tag, > > I can take it later if there is no objection to this from Tom. I need to rebase the patches, as one of the API (blk_get_if_type_name) used has changed since 8149b1500d8. I will send a rebased V4. Please merge that version. Thanks. -sughosh > > > Thanks, > > - Kever > > > > > -sughosh > > > >> Sughosh Ganu (3): > >> rockchip: capsule: Add functions for supporting capsule updates > >> rockpi4: board: Add firmware image information for capsule updates > >> rockpi4: capsule: Enable UEFI capsule update on RockPi4 boards > >> > >> arch/arm/include/asm/arch-rockchip/misc.h | 1 + > >> arch/arm/mach-rockchip/Kconfig | 1 + > >> arch/arm/mach-rockchip/board.c | 152 ++++++++++++++++++++++ > >> board/rockchip/evb_rk3399/evb-rk3399.c | 55 +++++++- > >> configs/rock-pi-4-rk3399_defconfig | 8 ++ > >> configs/rock-pi-4c-rk3399_defconfig | 8 ++ > >> include/configs/rk3399_common.h | 16 +++ > >> 7 files changed, 240 insertions(+), 1 deletion(-) > >> > >> -- > >> 2.34.1 > >> > >>