mbox series

[0/4] smpi: msm: fix version 5 and add version 7 support

Message ID 20240405-topic-sm8x50-spmi-fixes-v1-0-031a9e5efab4@linaro.org
Headers show
Series smpi: msm: fix version 5 and add version 7 support | expand

Message

Neil Armstrong April 5, 2024, 8:21 a.m. UTC
First, fix version 5 support by using the right ch_offset in
then msm_spmi_write() reg accesses.

Then:
- properly format command by importing helpers from Linux driver and
  use a switch/case to handle all versions in msm_spmi_write/read() command.
- handle peripheral ownership by poking into the cnfg registers and
  mark periperal as read-only when the owner id doesn't match
- finally add version 7 defines

SPMI Arbiter Version 7 is present on SM8450, SM8550 and SM8650 SoC.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Neil Armstrong (4):
      spmi: msm: fix version 5 support
      spmi: msm: properly format command
      spmi: msm: handle peripheral ownership
      spmi: msm: support controller version 7

 drivers/spmi/spmi-msm.c | 148 +++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 116 insertions(+), 32 deletions(-)
---
base-commit: f0e6aba1218bca578605697eed8aa94582bf57bb
change-id: 20240404-topic-sm8x50-spmi-fixes-aec9b392813b

Best regards,

Comments

Caleb Connolly April 11, 2024, 12:40 p.m. UTC | #1
On 05/04/2024 10:21, Neil Armstrong wrote:
> First, fix version 5 support by using the right ch_offset in
> then msm_spmi_write() reg accesses.
> 
> Then:
> - properly format command by importing helpers from Linux driver and
>    use a switch/case to handle all versions in msm_spmi_write/read() command.
> - handle peripheral ownership by poking into the cnfg registers and
>    mark periperal as read-only when the owner id doesn't match
> - finally add version 7 defines
> 
> SPMI Arbiter Version 7 is present on SM8450, SM8550 and SM8650 SoC.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Acked-by: Caleb Connolly <caleb.connolly@linaro.org>

Mateusz: do you prefer to take these? I'm just as happy to take then 
through the qcom tree.

Kind regards,
> ---
> Neil Armstrong (4):
>        spmi: msm: fix version 5 support
>        spmi: msm: properly format command
>        spmi: msm: handle peripheral ownership
>        spmi: msm: support controller version 7
> 
>   drivers/spmi/spmi-msm.c | 148 +++++++++++++++++++++++++++++++++++++-----------
>   1 file changed, 116 insertions(+), 32 deletions(-)
> ---
> base-commit: f0e6aba1218bca578605697eed8aa94582bf57bb
> change-id: 20240404-topic-sm8x50-spmi-fixes-aec9b392813b
> 
> Best regards,
Caleb Connolly April 23, 2024, 11:43 a.m. UTC | #2
On Fri, 05 Apr 2024 10:21:52 +0200, Neil Armstrong wrote:
> First, fix version 5 support by using the right ch_offset in
> then msm_spmi_write() reg accesses.
> 
> Then:
> - properly format command by importing helpers from Linux driver and
>   use a switch/case to handle all versions in msm_spmi_write/read() command.
> - handle peripheral ownership by poking into the cnfg registers and
>   mark periperal as read-only when the owner id doesn't match
> - finally add version 7 defines
> 
> [...]

Applied, thanks!

[1/4] spmi: msm: fix version 5 support
      commit: c2de620d64d462c1404ca383ad55aecf3f5a972e
[2/4] spmi: msm: properly format command
      commit: f0b604d9491dc92c9cb092a9e4c0fdf2036cdb8d
[3/4] spmi: msm: handle peripheral ownership
      commit: 59e0482b5edc1fceded3967306561a57f60ba4b3
[4/4] spmi: msm: support controller version 7
      commit: ee1d8aa5ecf77991d3bbcfea2d5b37d88bb19473

Best regards,