mbox series

[v2,0/5] usb: meson: switch to set_mode callback and other cleanup

Message ID 20240620-u-boot-usb-gxl-phy-set-mode-v2-0-b81c027bc02c@linaro.org
Headers show
Series usb: meson: switch to set_mode callback and other cleanup | expand

Message

Neil Armstrong June 20, 2024, 7:42 a.m. UTC
Switch to set_mode callback now it's available and in the same
time make public functions static and drop useless mach-meson
headers that are no more needed.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
Changes in v2:
- Update commit message in patch 1 to specify why we use _ in the set_mode callback
- Link to v1: https://lore.kernel.org/r/20240618-u-boot-usb-gxl-phy-set-mode-v1-0-6b41efa46e35@linaro.org

---
Neil Armstrong (5):
      phy: meson-gxl-usb2: add set_mode callback
      usb: dwc3: meson-gxl: switch to generic_phy_set_mode
      phy: meson-gxl-usb2: remove phy_meson_gxl_usb2_set_mode
      usb: dwc3: meson-gxl: drop usb-gx.h and make dwc3_meson_gxl_force_mode static
      usb: dwc3: meson-g12a: drop usb.h and make dwc3_meson_g12a_force_mode static

 arch/arm/include/asm/arch-meson/usb-gx.h | 17 -----------------
 arch/arm/include/asm/arch-meson/usb.h    | 12 ------------
 drivers/phy/meson-gxl-usb2.c             | 30 ++++++++++++++++++------------
 drivers/usb/dwc3/dwc3-meson-g12a.c       |  2 +-
 drivers/usb/dwc3/dwc3-meson-gxl.c        | 18 ++++++++++--------
 5 files changed, 29 insertions(+), 50 deletions(-)
---
base-commit: f1de28e67aa9b66bfca0fad3dc18446a6ec0b504
change-id: 20240618-u-boot-usb-gxl-phy-set-mode-c3991c5f1da2

Best regards,

Comments

Neil Armstrong June 24, 2024, 9:11 a.m. UTC | #1
Hi Marek,

On 20/06/2024 09:42, Neil Armstrong wrote:
> Switch to set_mode callback now it's available and in the same
> time make public functions static and drop useless mach-meson
> headers that are no more needed.

Thanks for the review, is it ok to apply it via my tree ?

Thanks,
Neil

> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
> Changes in v2:
> - Update commit message in patch 1 to specify why we use _ in the set_mode callback
> - Link to v1: https://lore.kernel.org/r/20240618-u-boot-usb-gxl-phy-set-mode-v1-0-6b41efa46e35@linaro.org
> 
> ---
> Neil Armstrong (5):
>        phy: meson-gxl-usb2: add set_mode callback
>        usb: dwc3: meson-gxl: switch to generic_phy_set_mode
>        phy: meson-gxl-usb2: remove phy_meson_gxl_usb2_set_mode
>        usb: dwc3: meson-gxl: drop usb-gx.h and make dwc3_meson_gxl_force_mode static
>        usb: dwc3: meson-g12a: drop usb.h and make dwc3_meson_g12a_force_mode static
> 
>   arch/arm/include/asm/arch-meson/usb-gx.h | 17 -----------------
>   arch/arm/include/asm/arch-meson/usb.h    | 12 ------------
>   drivers/phy/meson-gxl-usb2.c             | 30 ++++++++++++++++++------------
>   drivers/usb/dwc3/dwc3-meson-g12a.c       |  2 +-
>   drivers/usb/dwc3/dwc3-meson-gxl.c        | 18 ++++++++++--------
>   5 files changed, 29 insertions(+), 50 deletions(-)
> ---
> base-commit: f1de28e67aa9b66bfca0fad3dc18446a6ec0b504
> change-id: 20240618-u-boot-usb-gxl-phy-set-mode-c3991c5f1da2
> 
> Best regards,
Marek Vasut June 24, 2024, 12:12 p.m. UTC | #2
On 6/24/24 11:11 AM, Neil Armstrong wrote:
> Hi Marek,

Hi,

> On 20/06/2024 09:42, Neil Armstrong wrote:
>> Switch to set_mode callback now it's available and in the same
>> time make public functions static and drop useless mach-meson
>> headers that are no more needed.
> 
> Thanks for the review, is it ok to apply it via my tree ?

Yes please
Neil Armstrong June 26, 2024, 9:43 a.m. UTC | #3
Hi,

On Thu, 20 Jun 2024 09:42:49 +0200, Neil Armstrong wrote:
> Switch to set_mode callback now it's available and in the same
> time make public functions static and drop useless mach-meson
> headers that are no more needed.
> 
> 

Thanks, Applied to https://source.denx.de/u-boot/custodians/u-boot-amlogic (u-boot-amlogic-next)

[1/5] phy: meson-gxl-usb2: add set_mode callback
      https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/commit/e7265f62aa6bf20c9011d0848926d6206fdf7d51
[2/5] usb: dwc3: meson-gxl: switch to generic_phy_set_mode
      https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/commit/8c58c35048cb47a999c050aad9c6c9785fc5870e
[3/5] phy: meson-gxl-usb2: remove phy_meson_gxl_usb2_set_mode
      https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/commit/affb461d9aa235d12075fbd943cb11e481ada79d
[4/5] usb: dwc3: meson-gxl: drop usb-gx.h and make dwc3_meson_gxl_force_mode static
      https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/commit/98ce6d3e322c428f37e75956d316fb76479472ea
[5/5] usb: dwc3: meson-g12a: drop usb.h and make dwc3_meson_g12a_force_mode static
      https://source.denx.de/u-boot/custodians/u-boot-amlogic/-/commit/93b6a52f5a9754e3077c31590a7d5fcc2858d415